Skip to content

Commit df49fd6

Browse files
committed
build: remove existing commit message validation
The shared dev-infra toolset is now used to perform commit message validation.
1 parent bcbfc9c commit df49fd6

File tree

5 files changed

+2
-264
lines changed

5 files changed

+2
-264
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"lint": "tslint --project tsconfig.json",
3333
"templates": "node ./bin/devkit-admin templates",
3434
"validate": "node ./bin/devkit-admin validate",
35-
"validate-commits": "./bin/devkit-admin validate-commits",
3635
"preinstall": "node ./tools/yarn/check-yarn.js",
3736
"postinstall": "yarn webdriver-update && yarn ngcc",
3837
"//webdriver-update-README": "ChromeDriver version must match Puppeteer Chromium version, see https://github.com/GoogleChrome/puppeteer/releases http://chromedriver.chromium.org/downloads",
@@ -240,8 +239,7 @@
240239
"husky": {
241240
"hooks": {
242241
"commit-msg": "yarn -s ng-dev commit-message pre-commit-validate --file-env-variable HUSKY_GIT_PARAMS",
243-
"prepare-commit-msg": "yarn -s ng-dev commit-message restore-commit-message-draft --file-env-variable HUSKY_GIT_PARAMS",
244-
"pre-push": "node ./bin/devkit-admin hooks/pre-push"
242+
"prepare-commit-msg": "yarn -s ng-dev commit-message restore-commit-message-draft --file-env-variable HUSKY_GIT_PARAMS"
245243
}
246244
}
247245
}

scripts/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Run integration tests using Bazel.
123123

124124
## validate
125125

126-
Performs BUILD files, commit messages and license validation.
126+
Performs BUILD files and license validation.
127127

128128
Flags:
129129

scripts/hooks/pre-push.ts

Lines changed: 0 additions & 44 deletions
This file was deleted.

scripts/validate-commits.ts

Lines changed: 0 additions & 210 deletions
This file was deleted.

scripts/validate.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import { logging, tags } from '@angular-devkit/core';
1010
import { execSync } from 'child_process';
1111
import templates from './templates';
1212
import validateBuildFiles from './validate-build-files';
13-
import validateCommits from './validate-commits';
1413
import validateDoNotSubmit from './validate-do-not-submit';
1514
import validateLicenses from './validate-licenses';
1615
import validateUserAnalytics from './validate-user-analytics';
@@ -41,11 +40,6 @@ export default async function (options: { verbose: boolean; ci: boolean }, logge
4140
}
4241

4342
if (!options.ci) {
44-
logger.info('');
45-
logger.info('Running commit validation...');
46-
error = validateCommits({}, logger.createChild('validate-commits')) != 0
47-
|| error;
48-
4943
logger.info('');
5044
logger.info(`Running DO_NOT${''}_SUBMIT validation...`);
5145
error = await validateDoNotSubmit({}, logger.createChild('validate-do-not-submit')) != 0

0 commit comments

Comments
 (0)