test: remove non-bazel test setup

Author: filipesilva

.circleci/config.yml

@@ -175,12 +175,6 @@ jobs:
       - custom_attach_workspace
       - run: yarn validate --ci
 
-  test:
-    executor: action-executor
-    steps:
-      - custom_attach_workspace
-      - run: yarn test --full
-
   integration:
     executor: heavy-test-executor
     steps:
@@ -324,7 +318,6 @@ jobs:
     steps:
       - custom_attach_workspace
       - setup_windows
-      - run: yarn test --full
       # Run partial e2e suite on PRs only. Master will run the full e2e suite with sharding.
       - run: if (Test-Path env:CIRCLE_PR_NUMBER) { node tests\legacy-cli\run_e2e.js "--glob=tests/{basic,ivy}/**" }
 
@@ -358,10 +351,6 @@ workflows:
       - build-bazel:
           requires:
             - build
-      - test:
-          requires:
-            - build
-      # TODO: ng-packagr spec large also needs to be moved to bazel
       - integration:
           requires:
             - build
@@ -417,8 +406,8 @@ workflows:
             - build
       - test-win:
           requires:
+            - build-bazel
             - setup-and-build-win
-            - test
       - e2e-cli-win:
           <<: *only_release_branches
           requires:
@@ -429,13 +418,13 @@ workflows:
       - snapshot_publish:
           <<: *only_release_branches
           requires:
-            - test
             - build
+            - build-bazel
             - e2e-cli
       - publish:
           requires:
-            - test
             - build
+            - build-bazel
             - e2e-cli
             - snapshot_publish
           filters:

integration/build_angular/package.json

@@ -6,26 +6,26 @@
   "scripts": {
     "postinstall": "tsc -p tests/tsconfig.json",
     "pretest-app-shell": "yarn webdriver-update",
-    "test-app-shell": "jasmine \"tests-tsc-out/app-shell/**/*_spec_large.js\"",
-    "test-browser-1": "jasmine \"tests-tsc-out/browser-1/**/*_spec_large.js\"",
-    "test-browser-2": "jasmine \"tests-tsc-out/browser-2/**/*_spec_large.js\"",
-    "test-browser-3": "jasmine \"tests-tsc-out/browser-3/**/*_spec_large.js\"",
-    "test-browser-4": "jasmine \"tests-tsc-out/browser-4/**/*_spec_large.js\"",
-    "test-dev-server": "jasmine \"tests-tsc-out/dev-server/**/*_spec_large.js\"",
-    "test-extract-i18n": "jasmine \"tests-tsc-out/extract-i18n/**/*_spec_large.js\"",
-    "test-karma": "jasmine \"tests-tsc-out/karma/**/*_spec_large.js\"",
+    "test-app-shell": "jasmine \"tests-tsc-out/app-shell/**/*_spec.js\"",
+    "test-browser-1": "jasmine \"tests-tsc-out/browser-1/**/*_spec.js\"",
+    "test-browser-2": "jasmine \"tests-tsc-out/browser-2/**/*_spec.js\"",
+    "test-browser-3": "jasmine \"tests-tsc-out/browser-3/**/*_spec.js\"",
+    "test-browser-4": "jasmine \"tests-tsc-out/browser-4/**/*_spec.js\"",
+    "test-dev-server": "jasmine \"tests-tsc-out/dev-server/**/*_spec.js\"",
+    "test-extract-i18n": "jasmine \"tests-tsc-out/extract-i18n/**/*_spec.js\"",
+    "test-karma": "jasmine \"tests-tsc-out/karma/**/*_spec.js\"",
     "pretest-protractor": "yarn webdriver-update",
-    "test-protractor": "jasmine \"tests-tsc-out/protractor/**/*_spec_large.js\"",
-    "test-server": "jasmine \"tests-tsc-out/server/**/*_spec_large.js\"",
-    "test-tslint": "jasmine \"tests-tsc-out/tslint/**/*_spec_large.js\"",
+    "test-protractor": "jasmine \"tests-tsc-out/protractor/**/*_spec.js\"",
+    "test-server": "jasmine \"tests-tsc-out/server/**/*_spec.js\"",
+    "test-tslint": "jasmine \"tests-tsc-out/tslint/**/*_spec.js\"",
     "//view-engine-suites": "",
     "jasmine-ve": "jasmine --helper=./tests-tsc-out/enable-ve.js",
-    "test-browser-1-ve": "yarn jasmine-ve \"tests-tsc-out/browser-1/**/*_spec_large.js\"",
-    "test-browser-2-ve": "yarn jasmine-ve \"tests-tsc-out/browser-2/**/*_spec_large.js\"",
-    "test-browser-3-ve": "yarn jasmine-ve \"tests-tsc-out/browser-3/**/*_spec_large.js\"",
-    "test-browser-4-ve": "yarn jasmine-ve \"tests-tsc-out/browser-4/**/*_spec_large.js\"",
-    "test-extract-i18n-ve": "yarn jasmine-ve \"tests-tsc-out/extract-i18n/**/*_spec_large.js\"",
-    "test-server-ve": "yarn jasmine-ve \"tests-tsc-out/server/**/*_spec_large.js\"",
+    "test-browser-1-ve": "yarn jasmine-ve \"tests-tsc-out/browser-1/**/*_spec.js\"",
+    "test-browser-2-ve": "yarn jasmine-ve \"tests-tsc-out/browser-2/**/*_spec.js\"",
+    "test-browser-3-ve": "yarn jasmine-ve \"tests-tsc-out/browser-3/**/*_spec.js\"",
+    "test-browser-4-ve": "yarn jasmine-ve \"tests-tsc-out/browser-4/**/*_spec.js\"",
+    "test-extract-i18n-ve": "yarn jasmine-ve \"tests-tsc-out/extract-i18n/**/*_spec.js\"",
+    "test-server-ve": "yarn jasmine-ve \"tests-tsc-out/server/**/*_spec.js\"",
     "//webdriver-update-README": "ChromeDriver version must match Puppeteer Chromium version, see https://github.com/GoogleChrome/puppeteer/releases http://chromedriver.chromium.org/downloads",
     "webdriver-update": "webdriver-manager update --standalone false --gecko false --versions.chrome 79.0.3945.16"
   },

integration/build_angular/tests/app-shell/app-shell_spec_large.ts renamed to integration/build_angular/tests/app-shell/app-shell_spec.ts

@@ -32,8 +32,6 @@
     "fix": "node ./bin/devkit-admin lint --fix",
     "lint": "node ./bin/devkit-admin lint",
     "templates": "node ./bin/devkit-admin templates",
-    "test": "node ./bin/devkit-admin test",
-    "test-large": "node ./bin/devkit-admin test --large --spec-reporter",
     "validate": "node ./bin/devkit-admin validate",
     "validate-commits": "./bin/devkit-admin validate-commits",
     "preinstall": "node ./tools/yarn/check-yarn.js",

integration/build_angular/tests/browser-1/allow-js_spec_large.ts renamed to integration/build_angular/tests/browser-1/allow-js_spec.ts

@@ -15,10 +15,7 @@ ts_library(
     name = "angular-cli",
     srcs = glob(
         ["**/*.ts"],
-        exclude = [
-            "**/*_spec.ts",
-            "**/*_spec_large.ts",
-        ],
+        exclude = ["**/*_spec.ts"],
     ) + [
         "//packages/angular/cli:lib/config/schema.ts",
         "//packages/angular/cli:commands/analytics.ts",
@@ -226,12 +223,7 @@ ts_json_schema(
 ts_library(
     name = "angular-cli_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "**/*_spec.ts",
-            "**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["**/*_spec.ts"]),
     # strict_checks = False,
     tsconfig = "//:tsconfig-test.json",
     deps = [

integration/build_angular/tests/browser-1/aot_spec_large.ts renamed to integration/build_angular/tests/browser-1/aot_spec.ts

@@ -23,7 +23,6 @@ ts_library(
         exclude = [
             "pwa/files/**/*",
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
         ],
     ) + [
         "//packages/angular/pwa:pwa/schema.ts",
@@ -54,12 +53,7 @@ ts_json_schema(
 ts_library(
     name = "pwa_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "pwa/**/*_spec.ts",
-            "pwa/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["pwa/**/*_spec.ts"]),
     # strict_checks = False,
     tsconfig = "//:tsconfig-test.json",
     deps = [

integration/build_angular/tests/browser-1/assets_spec_large.ts renamed to integration/build_angular/tests/browser-1/assets_spec.ts

@@ -41,10 +41,7 @@ ts_library(
     name = "architect",
     srcs = glob(
         include = ["src/**/*.ts"],
-        exclude = [
-            "**/*_spec.ts",
-            "**/*_spec_large.ts",
-        ],
+        exclude = ["**/*_spec.ts"],
     ) + [
         "//packages/angular_devkit/architect:src/input-schema.ts",
         "//packages/angular_devkit/architect:src/output-schema.ts",
@@ -66,12 +63,7 @@ ts_library(
 ts_library(
     name = "architect_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["src/**/*_spec.ts"]),
     # strict_checks = False,
     tsconfig = "//:tsconfig-test.json",
     deps = [

integration/build_angular/tests/browser-1/base-href_spec_large.ts renamed to integration/build_angular/tests/browser-1/base-href_spec.ts

@@ -13,10 +13,7 @@ ts_library(
     name = "node",
     srcs = glob(
         include = ["**/*.ts"],
-        exclude = [
-            "**/*_spec.ts",
-            "**/*_spec_large.ts",
-        ],
+        exclude = ["**/*_spec.ts"],
     ),
     module_name = "@angular-devkit/architect/node",
     module_root = "index.d.ts",

integration/build_angular/tests/browser-1/build-optimizer_spec_large.ts renamed to integration/build_angular/tests/browser-1/build-optimizer_spec.ts

@@ -13,10 +13,7 @@ ts_library(
     name = "testing",
     srcs = glob(
         include = ["**/*.ts"],
-        exclude = [
-            "**/*_spec.ts",
-            "**/*_spec_large.ts",
-        ],
+        exclude = ["**/*_spec.ts"],
     ),
     module_name = "@angular-devkit/architect/testing",
     module_root = "index.d.ts",

integration/build_angular/tests/browser-1/bundle-budgets_spec_large.ts renamed to integration/build_angular/tests/browser-1/bundle-budgets_spec.ts

@@ -18,7 +18,6 @@ ts_library(
         include = ["src/**/*.ts"],
         exclude = [
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
             "src/**/*_benchmark.ts",
         ],
     ),
@@ -36,12 +35,7 @@ ts_library(
 ts_library(
     name = "benchmark_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["src/**/*_spec.ts"]),
     data = [
         "src/test/exit-code-one.js",
         "src/test/fibonacci.js",

integration/build_angular/tests/browser-1/circular-dependency_spec_large.ts renamed to integration/build_angular/tests/browser-1/circular-dependency_spec.ts

@@ -180,7 +180,6 @@ ts_library(
         include = [
             "plugins/**/*_spec.ts",
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
         ],
     ),
     data = glob(["test/**/*"]),

integration/build_angular/tests/browser-1/common-js-warning_spec_large.ts renamed to integration/build_angular/tests/browser-1/common-js-warning_spec.ts

@@ -21,7 +21,6 @@ ts_library(
             # from jasmine_node_test.
             "src/**/cli.ts",
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
             "src/**/*_benchmark.ts",
         ],
     ),
@@ -46,12 +45,7 @@ ts_library(
 ts_library(
     name = "build_optimizer_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["src/**/*_spec.ts"]),
     # @external_begin
     tsconfig = "//:tsconfig-test.json",
     deps = [

integration/build_angular/tests/browser-1/cross-origin_spec_large.ts renamed to integration/build_angular/tests/browser-1/cross-origin_spec.ts

@@ -64,7 +64,6 @@ ts_library(
         include = [
             "src/test-utils.ts",
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
         ],
     ),
     data = glob(

integration/build_angular/tests/browser-1/deploy-url_spec_large.ts renamed to integration/build_angular/tests/browser-1/deploy-url_spec.ts

@@ -22,7 +22,6 @@ ts_library(
         include = ["src/**/*.ts"],
         exclude = [
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
             "src/**/*_benchmark.ts",
         ],
     ),
@@ -51,12 +50,7 @@ ts_library(
 ts_library(
     name = "core_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["src/**/*_spec.ts"]),
     data = glob(["src/workspace/json/test/**/*.json"]) + [
         "src/experimental/workspace/test/test-workspace.json",
         "src/experimental/workspace/workspace-schema.json",

integration/build_angular/tests/browser-1/differential_loading_spec_large.ts renamed to integration/build_angular/tests/browser-1/differential_loading_spec.ts

@@ -16,7 +16,6 @@ ts_library(
         exclude = [
             "testing/**/*.ts",
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "**/*_benchmark.ts",
         ],
     ),
@@ -37,7 +36,6 @@ ts_library(
     srcs = glob(
         include = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
         ],
         exclude = [
             "testing/**/*.ts",

integration/build_angular/tests/browser-1/scripts-array_spec_large.ts renamed to integration/build_angular/tests/browser-1/scripts-array_spec.ts

@@ -14,7 +14,6 @@ ts_library(
         include = ["**/*.ts"],
         exclude = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "**/*_benchmark.ts",
         ],
     ),

integration/build_angular/tests/browser-2/errors_spec_large.ts renamed to integration/build_angular/tests/browser-2/errors_spec.ts

@@ -22,7 +22,6 @@ ts_library(
         include = ["src/**/*.ts"],
         exclude = [
             "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
             "src/**/*_benchmark.ts",
         ],
     ),
@@ -42,12 +41,7 @@ ts_library(
 ts_library(
     name = "schematics_test_lib",
     testonly = True,
-    srcs = glob(
-        include = [
-            "src/**/*_spec.ts",
-            "src/**/*_spec_large.ts",
-        ],
-    ),
+    srcs = glob(["src/**/*_spec.ts"]),
     # @external_begin
     tsconfig = "//:tsconfig-test.json",
     # @external_end

integration/build_angular/tests/browser-2/i18n_spec_large.ts renamed to integration/build_angular/tests/browser-2/i18n_spec.ts

@@ -42,7 +42,6 @@ ts_library(
     srcs = glob(
         include = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "tslint-fix/test/**/*.ts",
         ],
         exclude = [

integration/build_angular/tests/browser-2/index_spec_large.ts renamed to integration/build_angular/tests/browser-2/index_spec.ts

@@ -40,7 +40,6 @@ ts_library(
     srcs = glob(
         include = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "test/**/*.ts",
         ],
     ),

integration/build_angular/tests/browser-2/lazy-module_spec_large.ts renamed to integration/build_angular/tests/browser-2/lazy-module_spec.ts

@@ -17,7 +17,6 @@ ts_library(
         include = ["bin/**/*.ts"],
         exclude = [
             "bin/**/*_spec.ts",
-            "bin/**/*_spec_large.ts",
             "bin/**/*_benchmark.ts",
         ],
     ),

integration/build_angular/tests/browser-2/license-extraction_spec_large.ts renamed to integration/build_angular/tests/browser-2/license-extraction_spec.ts

@@ -35,7 +35,6 @@ ts_library(
         include = ["**/*.ts"],
         exclude = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "**/*_benchmark.ts",
             # Also exclude templated files.
             "*/files/**/*.ts",
@@ -85,7 +84,6 @@ ts_library(
     srcs = glob(
         include = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "utility/test/**/*.ts",
         ],
     ),

integration/build_angular/tests/browser-2/no-entry-module_spec_large.ts renamed to integration/build_angular/tests/browser-2/no-entry-module_spec.ts

@@ -16,7 +16,6 @@ ts_library(
         include = ["**/*.ts"],
         exclude = [
             "**/*_spec.ts",
-            "**/*_spec_large.ts",
             "**/*_benchmark.ts",
             "schematic/files/**",
             "blank/project-files/**",