refactor: consistently import MatCommonModule everywhere

The `MatCommonModule` is inteded to be imported in all Material modules since it includes some sanity checks and RTL handling, however we weren't importing it consistently. These changes add it to all the places where it was missing.

Author: crisbeto

src/material-experimental/column-resize/column-resize-module.ts

@@ -7,6 +7,7 @@
  */
 
 import {NgModule} from '@angular/core';
+import {MatCommonModule} from '@angular/material/core';
 import {OverlayModule} from '@angular/cdk/overlay';
 
 import {MatColumnResize} from './column-resize-directives/column-resize';
@@ -33,6 +34,7 @@ const ENTRY_COMMON_COMPONENTS = [
 export class MatColumnResizeCommonModule {}
 
 const IMPORTS = [
+  MatCommonModule,
   OverlayModule,
   MatColumnResizeCommonModule,
 ];

src/material-experimental/mdc-list/module.ts

@@ -8,7 +8,12 @@
 
 import {CommonModule} from '@angular/common';
 import {NgModule} from '@angular/core';
-import {MatLineModule, MatPseudoCheckboxModule, MatRippleModule} from '@angular/material/core';
+import {
+  MatLineModule,
+  MatPseudoCheckboxModule,
+  MatRippleModule,
+  MatCommonModule,
+} from '@angular/material/core';
 import {MatDividerModule} from '@angular/material/divider';
 import {MatActionList} from './action-list';
 import {
@@ -24,6 +29,7 @@ import {MatListOption, MatSelectionList} from './selection-list';
 @NgModule({
   imports: [
     CommonModule,
+    MatCommonModule,
     MatLineModule,
     MatRippleModule,
     MatPseudoCheckboxModule,

src/material-experimental/popover-edit/BUILD.bazel

@@ -17,6 +17,7 @@ ng_module(
     module_name = "@angular/material-experimental/popover-edit",
     deps = [
         "//src/cdk-experimental/popover-edit",
+        "//src/material/core",
         "@npm//@angular/core",
         "@npm//@angular/forms",
     ],

src/material-experimental/popover-edit/popover-edit-module.ts

@@ -7,6 +7,7 @@
  */
 
 import {NgModule} from '@angular/core';
+import {MatCommonModule} from '@angular/material/core';
 import {CdkEditable, CdkPopoverEditModule} from '@angular/cdk-experimental/popover-edit';
 import {
   MatPopoverEdit,
@@ -33,6 +34,7 @@ const EXPORTED_DECLARATIONS = [
 @NgModule({
   imports: [
     CdkPopoverEditModule,
+    MatCommonModule,
   ],
   exports: [
     ...EXPORTED_DECLARATIONS,

src/material/chips/chips-module.ts

@@ -8,7 +8,7 @@
 
 import {ENTER} from '@angular/cdk/keycodes';
 import {NgModule} from '@angular/core';
-import {ErrorStateMatcher} from '@angular/material/core';
+import {ErrorStateMatcher, MatCommonModule} from '@angular/material/core';
 import {MatChip, MatChipAvatar, MatChipRemove, MatChipTrailingIcon} from './chip';
 import {MAT_CHIPS_DEFAULT_OPTIONS, MatChipsDefaultOptions} from './chip-default-options';
 import {MatChipInput} from './chip-input';
@@ -24,6 +24,7 @@ const CHIP_DECLARATIONS = [
 ];
 
 @NgModule({
+  imports: [MatCommonModule],
   exports: CHIP_DECLARATIONS,
   declarations: CHIP_DECLARATIONS,
   providers: [

src/material/core/option/index.ts

@@ -10,12 +10,13 @@ import {NgModule} from '@angular/core';
 import {CommonModule} from '@angular/common';
 import {MatRippleModule} from '../ripple/index';
 import {MatPseudoCheckboxModule} from '../selection/index';
+import {MatCommonModule} from '../common-behaviors';
 import {MatOption} from './option';
 import {MatOptgroup} from './optgroup';
 
 
 @NgModule({
-  imports: [MatRippleModule, CommonModule, MatPseudoCheckboxModule],
+  imports: [MatRippleModule, CommonModule, MatCommonModule, MatPseudoCheckboxModule],
   exports: [MatOption, MatOptgroup],
   declarations: [MatOption, MatOptgroup]
 })

src/material/core/selection/index.ts

@@ -8,9 +8,11 @@
 
 import {NgModule} from '@angular/core';
 import {MatPseudoCheckbox} from './pseudo-checkbox/pseudo-checkbox';
+import {MatCommonModule} from '../common-behaviors';
 
 
 @NgModule({
+  imports: [MatCommonModule],
   exports: [MatPseudoCheckbox],
   declarations: [MatPseudoCheckbox]
 })

src/material/datepicker/datepicker-module.ts

@@ -14,6 +14,7 @@ import {NgModule} from '@angular/core';
 import {MatButtonModule} from '@angular/material/button';
 import {MatDialogModule} from '@angular/material/dialog';
 import {CdkScrollableModule} from '@angular/cdk/scrolling';
+import {MatCommonModule} from '@angular/material/core';
 import {MatCalendar, MatCalendarHeader} from './calendar';
 import {MatCalendarBody} from './calendar-body';
 import {MatDatepicker} from './datepicker';
@@ -44,6 +45,7 @@ import {
     OverlayModule,
     A11yModule,
     PortalModule,
+    MatCommonModule,
   ],
   exports: [
     CdkScrollableModule,

src/material/expansion/BUILD.bazel

@@ -30,6 +30,7 @@ ng_module(
         "//src/cdk/collections",
         "//src/cdk/keycodes",
         "//src/cdk/portal",
+        "//src/material/core",
         "@npm//@angular/animations",
         "@npm//@angular/common",
         "@npm//@angular/core",

src/material/expansion/expansion-module.ts

@@ -10,6 +10,7 @@ import {CdkAccordionModule} from '@angular/cdk/accordion';
 import {PortalModule} from '@angular/cdk/portal';
 import {CommonModule} from '@angular/common';
 import {NgModule} from '@angular/core';
+import {MatCommonModule} from '@angular/material/core';
 import {MatAccordion} from './accordion';
 import {MatExpansionPanel, MatExpansionPanelActionRow} from './expansion-panel';
 import {MatExpansionPanelContent} from './expansion-panel-content';
@@ -21,7 +22,7 @@ import {
 
 
 @NgModule({
-  imports: [CommonModule, CdkAccordionModule, PortalModule],
+  imports: [CommonModule, MatCommonModule, CdkAccordionModule, PortalModule],
   exports: [
     MatAccordion,
     MatExpansionPanel,

src/material/input/input-module.ts

@@ -8,7 +8,7 @@
 
 import {TextFieldModule} from '@angular/cdk/text-field';
 import {NgModule} from '@angular/core';
-import {ErrorStateMatcher} from '@angular/material/core';
+import {ErrorStateMatcher, MatCommonModule} from '@angular/material/core';
 import {MatFormFieldModule} from '@angular/material/form-field';
 import {MatTextareaAutosize} from './autosize';
 import {MatInput} from './input';
@@ -18,6 +18,7 @@ import {MatInput} from './input';
   imports: [
     TextFieldModule,
     MatFormFieldModule,
+    MatCommonModule,
   ],
   exports: [
     TextFieldModule,

src/material/paginator/paginator-module.ts

@@ -8,6 +8,7 @@
 
 import {CommonModule} from '@angular/common';
 import {NgModule} from '@angular/core';
+import {MatCommonModule} from '@angular/material/core';
 import {MatButtonModule} from '@angular/material/button';
 import {MatSelectModule} from '@angular/material/select';
 import {MatTooltipModule} from '@angular/material/tooltip';
@@ -21,6 +22,7 @@ import {MAT_PAGINATOR_INTL_PROVIDER} from './paginator-intl';
     MatButtonModule,
     MatSelectModule,
     MatTooltipModule,
+    MatCommonModule,
   ],
   exports: [MatPaginator],
   declarations: [MatPaginator],

src/material/sort/sort-module.ts

@@ -11,10 +11,11 @@ import {MatSortHeader} from './sort-header';
 import {MatSort} from './sort';
 import {MAT_SORT_HEADER_INTL_PROVIDER} from './sort-header-intl';
 import {CommonModule} from '@angular/common';
+import {MatCommonModule} from '@angular/material/core';
 
 
 @NgModule({
-  imports: [CommonModule],
+  imports: [CommonModule, MatCommonModule],
   exports: [MatSort, MatSortHeader],
   declarations: [MatSort, MatSortHeader],
   providers: [MAT_SORT_HEADER_INTL_PROVIDER]

tools/public_api_guard/material/chips.d.ts

@@ -214,7 +214,7 @@ export declare class MatChipSelectionChange {
 
 export declare class MatChipsModule {
     static ɵinj: i0.ɵɵInjectorDef<MatChipsModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatChipsModule, [typeof i1.MatChipList, typeof i2.MatChip, typeof i3.MatChipInput, typeof i2.MatChipRemove, typeof i2.MatChipAvatar, typeof i2.MatChipTrailingIcon], never, [typeof i1.MatChipList, typeof i2.MatChip, typeof i3.MatChipInput, typeof i2.MatChipRemove, typeof i2.MatChipAvatar, typeof i2.MatChipTrailingIcon]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatChipsModule, [typeof i1.MatChipList, typeof i2.MatChip, typeof i3.MatChipInput, typeof i2.MatChipRemove, typeof i2.MatChipAvatar, typeof i2.MatChipTrailingIcon], [typeof i4.MatCommonModule], [typeof i1.MatChipList, typeof i2.MatChip, typeof i3.MatChipInput, typeof i2.MatChipRemove, typeof i2.MatChipAvatar, typeof i2.MatChipTrailingIcon]>;
 }
 
 export declare class MatChipTrailingIcon {

tools/public_api_guard/material/core.d.ts

@@ -232,7 +232,7 @@ export declare class MatOption implements FocusableOption, AfterViewChecked, OnD
 
 export declare class MatOptionModule {
     static ɵinj: i0.ɵɵInjectorDef<MatOptionModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatOptionModule, [typeof i1.MatOption, typeof i2.MatOptgroup], [typeof i3.MatRippleModule, typeof i4.CommonModule, typeof i5.MatPseudoCheckboxModule], [typeof i1.MatOption, typeof i2.MatOptgroup]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatOptionModule, [typeof i1.MatOption, typeof i2.MatOptgroup], [typeof i3.MatRippleModule, typeof i4.CommonModule, typeof i5.MatCommonModule, typeof i6.MatPseudoCheckboxModule], [typeof i1.MatOption, typeof i2.MatOptgroup]>;
 }
 
 export interface MatOptionParentComponent {
@@ -259,7 +259,7 @@ export declare class MatPseudoCheckbox {
 
 export declare class MatPseudoCheckboxModule {
     static ɵinj: i0.ɵɵInjectorDef<MatPseudoCheckboxModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatPseudoCheckboxModule, [typeof i1.MatPseudoCheckbox], never, [typeof i1.MatPseudoCheckbox]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatPseudoCheckboxModule, [typeof i1.MatPseudoCheckbox], [typeof i2.MatCommonModule], [typeof i1.MatPseudoCheckbox]>;
 }
 
 export declare type MatPseudoCheckboxState = 'unchecked' | 'checked' | 'indeterminate';

tools/public_api_guard/material/datepicker.d.ts

@@ -258,7 +258,7 @@ export declare class MatDatepickerIntl {
 
 export declare class MatDatepickerModule {
     static ɵinj: i0.ɵɵInjectorDef<MatDatepickerModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatDatepickerModule, [typeof i1.MatCalendar, typeof i2.MatCalendarBody, typeof i3.MatDatepicker, typeof i4.MatDatepickerContent, typeof i5.MatDatepickerInput, typeof i6.MatDatepickerToggle, typeof i6.MatDatepickerToggleIcon, typeof i7.MatMonthView, typeof i8.MatYearView, typeof i9.MatMultiYearView, typeof i1.MatCalendarHeader, typeof i10.MatDateRangeInput, typeof i11.MatStartDate, typeof i11.MatEndDate, typeof i12.MatDateRangePicker], [typeof i13.CommonModule, typeof i14.MatButtonModule, typeof i15.MatDialogModule, typeof i16.OverlayModule, typeof i17.A11yModule, typeof i18.PortalModule], [typeof i19.CdkScrollableModule, typeof i1.MatCalendar, typeof i2.MatCalendarBody, typeof i3.MatDatepicker, typeof i4.MatDatepickerContent, typeof i5.MatDatepickerInput, typeof i6.MatDatepickerToggle, typeof i6.MatDatepickerToggleIcon, typeof i7.MatMonthView, typeof i8.MatYearView, typeof i9.MatMultiYearView, typeof i1.MatCalendarHeader, typeof i10.MatDateRangeInput, typeof i11.MatStartDate, typeof i11.MatEndDate, typeof i12.MatDateRangePicker]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatDatepickerModule, [typeof i1.MatCalendar, typeof i2.MatCalendarBody, typeof i3.MatDatepicker, typeof i4.MatDatepickerContent, typeof i5.MatDatepickerInput, typeof i6.MatDatepickerToggle, typeof i6.MatDatepickerToggleIcon, typeof i7.MatMonthView, typeof i8.MatYearView, typeof i9.MatMultiYearView, typeof i1.MatCalendarHeader, typeof i10.MatDateRangeInput, typeof i11.MatStartDate, typeof i11.MatEndDate, typeof i12.MatDateRangePicker], [typeof i13.CommonModule, typeof i14.MatButtonModule, typeof i15.MatDialogModule, typeof i16.OverlayModule, typeof i17.A11yModule, typeof i18.PortalModule, typeof i19.MatCommonModule], [typeof i20.CdkScrollableModule, typeof i1.MatCalendar, typeof i2.MatCalendarBody, typeof i3.MatDatepicker, typeof i4.MatDatepickerContent, typeof i5.MatDatepickerInput, typeof i6.MatDatepickerToggle, typeof i6.MatDatepickerToggleIcon, typeof i7.MatMonthView, typeof i8.MatYearView, typeof i9.MatMultiYearView, typeof i1.MatCalendarHeader, typeof i10.MatDateRangeInput, typeof i11.MatStartDate, typeof i11.MatEndDate, typeof i12.MatDateRangePicker]>;
 }
 
 export declare class MatDatepickerToggle<D> implements AfterContentInit, OnChanges, OnDestroy {

tools/public_api_guard/material/expansion.d.ts

@@ -37,7 +37,7 @@ export declare const matExpansionAnimations: {
 
 export declare class MatExpansionModule {
     static ɵinj: i0.ɵɵInjectorDef<MatExpansionModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatExpansionModule, [typeof i1.MatAccordion, typeof i2.MatExpansionPanel, typeof i2.MatExpansionPanelActionRow, typeof i3.MatExpansionPanelHeader, typeof i3.MatExpansionPanelTitle, typeof i3.MatExpansionPanelDescription, typeof i4.MatExpansionPanelContent], [typeof i5.CommonModule, typeof i6.CdkAccordionModule, typeof i7.PortalModule], [typeof i1.MatAccordion, typeof i2.MatExpansionPanel, typeof i2.MatExpansionPanelActionRow, typeof i3.MatExpansionPanelHeader, typeof i3.MatExpansionPanelTitle, typeof i3.MatExpansionPanelDescription, typeof i4.MatExpansionPanelContent]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatExpansionModule, [typeof i1.MatAccordion, typeof i2.MatExpansionPanel, typeof i2.MatExpansionPanelActionRow, typeof i3.MatExpansionPanelHeader, typeof i3.MatExpansionPanelTitle, typeof i3.MatExpansionPanelDescription, typeof i4.MatExpansionPanelContent], [typeof i5.CommonModule, typeof i6.MatCommonModule, typeof i7.CdkAccordionModule, typeof i8.PortalModule], [typeof i1.MatAccordion, typeof i2.MatExpansionPanel, typeof i2.MatExpansionPanelActionRow, typeof i3.MatExpansionPanelHeader, typeof i3.MatExpansionPanelTitle, typeof i3.MatExpansionPanelDescription, typeof i4.MatExpansionPanelContent]>;
 }
 
 export declare class MatExpansionPanel extends CdkAccordionItem implements AfterContentInit, OnChanges, OnDestroy {

tools/public_api_guard/material/input.d.ts

@@ -64,7 +64,7 @@ export declare class MatInput extends _MatInputMixinBase implements MatFormField
 
 export declare class MatInputModule {
     static ɵinj: i0.ɵɵInjectorDef<MatInputModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatInputModule, [typeof i1.MatInput, typeof i2.MatTextareaAutosize], [typeof i3.TextFieldModule, typeof i4.MatFormFieldModule], [typeof i3.TextFieldModule, typeof i4.MatFormFieldModule, typeof i1.MatInput, typeof i2.MatTextareaAutosize]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatInputModule, [typeof i1.MatInput, typeof i2.MatTextareaAutosize], [typeof i3.TextFieldModule, typeof i4.MatFormFieldModule, typeof i5.MatCommonModule], [typeof i3.TextFieldModule, typeof i4.MatFormFieldModule, typeof i1.MatInput, typeof i2.MatTextareaAutosize]>;
 }
 
 export declare class MatTextareaAutosize extends CdkTextareaAutosize {

tools/public_api_guard/material/paginator.d.ts

@@ -69,7 +69,7 @@ export declare class MatPaginatorIntl {
 
 export declare class MatPaginatorModule {
     static ɵinj: i0.ɵɵInjectorDef<MatPaginatorModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatPaginatorModule, [typeof i1.MatPaginator], [typeof i2.CommonModule, typeof i3.MatButtonModule, typeof i4.MatSelectModule, typeof i5.MatTooltipModule], [typeof i1.MatPaginator]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatPaginatorModule, [typeof i1.MatPaginator], [typeof i2.CommonModule, typeof i3.MatButtonModule, typeof i4.MatSelectModule, typeof i5.MatTooltipModule, typeof i6.MatCommonModule], [typeof i1.MatPaginator]>;
 }
 
 export declare class PageEvent {

tools/public_api_guard/material/sort.d.ts

@@ -93,7 +93,7 @@ export declare class MatSortHeaderIntl {
 
 export declare class MatSortModule {
     static ɵinj: i0.ɵɵInjectorDef<MatSortModule>;
-    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatSortModule, [typeof i1.MatSort, typeof i2.MatSortHeader], [typeof i3.CommonModule], [typeof i1.MatSort, typeof i2.MatSortHeader]>;
+    static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatSortModule, [typeof i1.MatSort, typeof i2.MatSortHeader], [typeof i3.CommonModule, typeof i4.MatCommonModule], [typeof i1.MatSort, typeof i2.MatSortHeader]>;
 }
 
 export interface Sort {