Skip to content

Commit 0402d55

Browse files
devversionjelbourn
authored andcommitted
build: use older rules_nodejs version with uglify (#15613)
We recently updated to a more recent "rules_nodejs" version that no longer runs with `uglify`. This is problematic as we didn't update the `@angular/bazel` package. Our current version of `@angular/bazel` depends on the rollup-uglify build targets in the NodeJS Bazel repository.
1 parent d739c67 commit 0402d55

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

WORKSPACE

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
55
# Add NodeJS rules (explicitly used for sass bundle rules)
66
http_archive(
77
name = "build_bazel_rules_nodejs",
8-
sha256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16",
9-
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.8/rules_nodejs-0.27.8.tar.gz"],
8+
sha256 = "5c86b055c57e15bf32d9009a15bcd6d8e190c41b1ff2fb18037b75e0012e4e7c",
9+
# Temporarily locked to a version of the NodeJS rules that still comes with rollup-uglify. This
10+
# is necessary until we update "@angular/bazel" to the latest version that uses rollup-terser.
11+
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.26.0/rules_nodejs-0.26.0.tar.gz"],
1012
)
1113

1214
# Add sass rules

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
"@angular/upgrade": "8.0.0-beta.9",
5959
"@bazel/ibazel": "^0.9.0",
6060
"@bazel/jasmine": "0.26.0",
61-
"@bazel/karma": "0.27.8",
62-
"@bazel/typescript": "0.27.8",
61+
"@bazel/karma": "0.26.0",
62+
"@bazel/typescript": "0.26.0",
6363
"@firebase/app-types": "^0.3.2",
6464
"@octokit/rest": "^15.9.4",
6565
"@schematics/angular": "7.3.6",

yarn.lock

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,10 @@
326326
dependencies:
327327
jasmine "~3.3.1"
328328

329-
"@bazel/karma@0.27.8":
330-
version "0.27.8"
331-
resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-0.27.8.tgz#e9c4ef4190b2da3c23b01bc7b79830c3985cfb1f"
332-
integrity sha512-H6TDIUcP+nW4dvjQeCINAyGLMnEV45maAM0HxModAe0cKfVxBpZrVKwG6ZuKChvQWY2nLDtN3C9K/GGISxP7hg==
329+
"@bazel/karma@0.26.0":
330+
version "0.26.0"
331+
resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-0.26.0.tgz#6ad796686f5775df33a96fa5ef3df76a66aed3b2"
332+
integrity sha512-yZv0fgAjVrfrM0ld8e+wNaPIpYCpwBzVQi2GUErsKStUZXPUUofpBwBjlYsdY1Osn5/FmAF9e6xDkk1JWn/wSg==
333333
dependencies:
334334
jasmine-core "2.8.0"
335335
karma "^4.0.0"
@@ -343,11 +343,12 @@
343343
semver "5.6.0"
344344
tmp "0.0.33"
345345

346-
"@bazel/typescript@0.27.8":
347-
version "0.27.8"
348-
resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-0.27.8.tgz#b9a566e4a95c0425b52961e9e899b59c7b22efcf"
349-
integrity sha512-beApzTtgm+lKrhQf5OgPk1amGfi5PJ1DCVVWYbNsbJP/Joi+NgCrgykG55NbaJIzEc+6IQoh8y0QUVMYRt562Q==
346+
"@bazel/typescript@0.26.0":
347+
version "0.26.0"
348+
resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-0.26.0.tgz#c06139d76c8b9d3a3ed98a721b776fedb4b11c82"
349+
integrity sha512-dh/Y/SZzmeChsLap8FVHYl0FuaeLh/6t9WBVhm5nOgyVrqfEyVpNzy4W20E4NqnmJY2/PqmD5qncf+Oo1q9h1A==
350350
dependencies:
351+
jasmine-core "2.8.0"
351352
protobufjs "5.0.3"
352353
semver "5.6.0"
353354
source-map-support "0.5.9"

0 commit comments

Comments
 (0)