build: add global types to api golden tests of youtube-player and google-maps

We refactored how type resolution works in the API golden test. The Bazel NodeJS
linker no longer runs for API golden tests, making the API golden tests more
reliable and less reliant on unexpected behavior/side-effects.

A consequence is that Microsofts API extractor is no longer able to automatically
resolve type definitions like `@types/google.maps`. These now need to be explicity
referenced/loaded similar to how it would happen if we'd test the API goldens through
the NPM package (using `api_golden_test_npm_package` -- so this is more consistent now).

Author: devversion

tools/public_api_guard/BUILD.bazel

@@ -4,14 +4,25 @@ load(":generate-guard-tests.bzl", "generate_test_targets")
 
 package(default_visibility = ["//visibility:public"])
 
-golden_files = [
-                   # Primary entry-points.
-                   "cdk/cdk.md",
-                   "material/material.md",
-                   "youtube-player/youtube-player.md",
-                   "google-maps/google-maps.md",
-               ] + ["cdk/%s.md" % e for e in CDK_ENTRYPOINTS] + \
-               ["material/%s.md" % e for e in MATERIAL_ENTRYPOINTS + MATERIAL_TESTING_ENTRYPOINTS]
+generate_test_targets(
+    targets =
+        [
+            "//src/cdk",
+            "//src/material",
+        ] + ["//src/cdk/%s" % e for e in CDK_ENTRYPOINTS] +
+        ["//src/material/%s" % e for e in MATERIAL_ENTRYPOINTS + MATERIAL_TESTING_ENTRYPOINTS],
+)
 
-# Generate the API guard test targets for each golden file in the current package.
-generate_test_targets(targets = golden_files)
+generate_test_targets(
+    targets = [
+        "//src/youtube-player",
+    ],
+    types = ["@npm//@types/youtube"],
+)
+
+generate_test_targets(
+    targets = [
+        "//src/google-maps",
+    ],
+    types = ["@npm//@types/google.maps"],
+)

tools/public_api_guard/generate-guard-tests.bzl

@@ -1,37 +1,32 @@
 load("@npm//@angular/dev-infra-private/bazel/api-golden:index.bzl", "api_golden_test")
 
-"""
-  Macro for generating `api_golden_test` Bazel test targets. Since there are multiple golden files
-  in this package, we don't want to manually set up all golden files. In order to make this
-  more maintainable, we allow passing a list of golden files that will be automatically verified
-  against the associated source entry point.
-"""
+def generate_test_targets(targets, types = []):
+    """Macro for generating `api_golden_test` Bazel test targets. Since there are multiple
+    golden files in this package, we don't want to manually set up all golden files.
+
+    In order to make this more maintainable, we allow passing a list of targets that will
+    be automatically verified against the corresponding golden report file.
+    """
+
+    for target in targets:
+        label = Label(target)
 
-def generate_test_targets(targets):
-    for target_name in targets:
         # Splits the path that is relative to the current directory into the package name and
         # entry point tail path. The package name is always the first path segment (e.g. "cdk/")
-        [package_name, entry_point_tail] = target_name.split("/", 1)
-
-        # Name of the entry-point (e.g. "a11y", "drag-drop", "platform")
-        entry_point = entry_point_tail[:-len(".md")]
+        segments = label.package[len("src/"):].split("/", 1)
+        package_name = segments[0]
 
-        # Name of the .d.ts file that will be produced. We replace the slashes in the entry
-        # point name with underscores so that we can get a flat directory of golden files.
-        golden_file = "%s/%s" % (package_name, entry_point_tail.replace("/", "-"))
+        # Name of the entry-point if not the primary-one (e.g. "a11y", "drag-drop", "platform")
+        entry_point = segments[1] if len(segments) > 1 else None
 
-        # Construct the path to the given entry-point. Note that we also need to find a way to
-        # allow guards for the primary entry-point of a package. e.g. "//src/cdk:cdk" should be also
-        # validated. We achieve this by checking if the package_name is equal to the entry_point name.
-        # For example: "public_api_guard/cdk/cdk.d.ts" will be the golden for the primary entry-point.
-        entry_point_path = "%s" % (package_name if entry_point == package_name else "%s/%s" % (package_name, entry_point))
+        golden_basename = (entry_point if entry_point else package_name).replace("/", "-")
+        golden_file = "%s/%s.md" % (package_name, golden_basename)
 
         # Create the test rule that compares the build output with the golden file.
         api_golden_test(
             name = "%s_api" % golden_file,
-            entry_point = "angular_material/src/%s/index.d.ts" % entry_point_path,
-            data = [golden_file] + [
-                "//src/%s" % (entry_point_path),
-            ],
+            entry_point = "angular_material/%s/index.d.ts" % label.package,
+            data = [golden_file] + [target],
             golden = "angular_material/tools/public_api_guard/%s" % golden_file,
+            types = types,
         )