Skip to content

Commit 1328307

Browse files
devversionjelbourn
authored andcommitted
build: remove outdated tslint rule (#4121)
* At some point in tslint the `no-unused-variable` rule has been deprecated in favor of `noUnusedLocals` and `noUnusedParameters`. Since we don't want to have compilation errors for unused variables we re-implemented the `no-unused-variable` rule ourself and used it as a custom rule. * Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm).
1 parent 8826d67 commit 1328307

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,7 @@
114114
"stylelint": "^7.8.0",
115115
"travis-after-modes": "0.0.7",
116116
"ts-node": "^3.0.0",
117-
"tslint": "^5.0.0",
118-
"tslint-no-unused-var": "0.0.6",
117+
"tslint": "^5.1.0",
119118
"typescript": "~2.2.1",
120119
"uglify-js": "^2.8.14",
121120
"web-animations-js": "^2.2.2"

tslint.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"rulesDirectory": [
3-
"./node_modules/tslint-no-unused-var/",
43
"./tools/tslint-rules/"
54
],
65
"rules": {
@@ -27,7 +26,6 @@
2726
"no-bitwise": true,
2827
"no-shadowed-variable": true,
2928
"no-unused-expression": true,
30-
"no-unused-var": [true, {"ignore-pattern": "^(_.*)$"}],
3129
"no-var-keyword": true,
3230
"no-exposed-todo": true,
3331
"no-debugger": true,

0 commit comments

Comments
 (0)