fixup! fix(cdk-experimental/listbox): address comments

Author: mmalerba

src/cdk/collections/selection-model.ts

@@ -58,8 +58,9 @@ export class SelectionModel<T> {
    * Selects a value or an array of values.
    * @param values The values to select
    * @return Whether the selection changed as a result of this call
+   * @breaking-change 16.0.0 make return type boolean
    */
-  select(...values: T[]) {
+  select(...values: T[]): boolean | void {
     this._verifyValueAssignment(values);
     values.forEach(value => this._markSelected(value));
     const changed = this._hasQueuedChanges();
@@ -71,8 +72,9 @@ export class SelectionModel<T> {
    * Deselects a value or an array of values.
    * @param values The values to deselect
    * @return Whether the selection changed as a result of this call
+   * @breaking-change 16.0.0 make return type boolean
    */
-  deselect(...values: T[]) {
+  deselect(...values: T[]): boolean | void {
     this._verifyValueAssignment(values);
     values.forEach(value => this._unmarkSelected(value));
     const changed = this._hasQueuedChanges();
@@ -84,8 +86,9 @@ export class SelectionModel<T> {
    * Sets the selected values
    * @param values The new selected values
    * @return Whether the selection changed as a result of this call
+   * @breaking-change 16.0.0 make return type boolean
    */
-  setSelection(...values: T[]): boolean {
+  setSelection(...values: T[]): boolean | void {
     this._verifyValueAssignment(values);
     const oldValues = this.selected;
     const newSelectedSet = new Set(values);
@@ -102,8 +105,9 @@ export class SelectionModel<T> {
    * Toggles a value between selected and deselected.
    * @param value The value to toggle
    * @return Whether the selection changed as a result of this call
+   * @breaking-change 16.0.0 make return type boolean
    */
-  toggle(value: T) {
+  toggle(value: T): boolean | void {
     return this.isSelected(value) ? this.deselect(value) : this.select(value);
   }
 
@@ -112,8 +116,9 @@ export class SelectionModel<T> {
    * @param flushEvent Whether to flush the changes in an event.
    *   If false, the changes to the selection will be flushed along with the next event.
    * @return Whether the selection changed as a result of this call
+   * @breaking-change 16.0.0 make return type boolean
    */
-  clear(flushEvent = true) {
+  clear(flushEvent = true): boolean | void {
     this._unmarkAll();
     const changed = this._hasQueuedChanges();
     if (flushEvent) {

tools/public_api_guard/cdk/collections.md

@@ -73,19 +73,19 @@ export interface SelectionChange<T> {
 export class SelectionModel<T> {
     constructor(_multiple?: boolean, initiallySelectedValues?: T[], _emitChanges?: boolean, compareWith?: ((o1: T, o2: T) => boolean) | undefined);
     readonly changed: Subject<SelectionChange<T>>;
-    clear(flushEvent?: boolean): boolean;
+    clear(flushEvent?: boolean): boolean | void;
     // (undocumented)
     compareWith?: ((o1: T, o2: T) => boolean) | undefined;
-    deselect(...values: T[]): boolean;
+    deselect(...values: T[]): boolean | void;
     hasValue(): boolean;
     isEmpty(): boolean;
     isMultipleSelection(): boolean;
     isSelected(value: T): boolean;
-    select(...values: T[]): boolean;
+    select(...values: T[]): boolean | void;
     get selected(): T[];
-    setSelection(...values: T[]): boolean;
+    setSelection(...values: T[]): boolean | void;
     sort(predicate?: (a: T, b: T) => number): void;
-    toggle(value: T): boolean;
+    toggle(value: T): boolean | void;
 }
 
 // @public