Always include prebuilt theme. Rebase changes for paginator spec

Author: devversion

src/lib/autocomplete/BUILD.bazel

@@ -67,5 +67,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":autocomplete_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/badge/BUILD.bazel

@@ -40,6 +40,5 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":badge_test_sources"],
-  prebuilt_theme = True,
 )
 

src/lib/bottom-sheet/BUILD.bazel

@@ -62,6 +62,5 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":bottom_sheet_test_sources"],
-  prebuilt_theme = True,
 )
 

src/lib/button-toggle/BUILD.bazel

@@ -49,6 +49,5 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":button_toggle_test_sources"],
-  prebuilt_theme = True,
 )
 

src/lib/button/BUILD.bazel

@@ -55,5 +55,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":button_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/checkbox/BUILD.bazel

@@ -52,5 +52,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":checkbox_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/chips/BUILD.bazel

@@ -63,5 +63,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":chips_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/core/BUILD.bazel

@@ -125,5 +125,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":core_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/datepicker/BUILD.bazel

@@ -93,5 +93,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":datepicker_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/dialog/BUILD.bazel

@@ -61,5 +61,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":dialog_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/divider/BUILD.bazel

@@ -53,6 +53,5 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":divider_test_sources"],
-  prebuilt_theme = True,
 )
 

src/lib/expansion/BUILD.bazel

@@ -66,5 +66,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":expansion_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/grid-list/BUILD.bazel

@@ -47,5 +47,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":grid_list_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/icon/BUILD.bazel

@@ -51,5 +51,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":icon_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/input/BUILD.bazel

@@ -60,5 +60,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":input_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/list/BUILD.bazel

@@ -55,5 +55,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":list_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/menu/BUILD.bazel

@@ -61,6 +61,5 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":menu_test_sources"],
-  prebuilt_theme = True,
 )
 

src/lib/paginator/BUILD.bazel

@@ -41,15 +41,16 @@ ng_test_library(
   name = "paginator_test_sources",
   srcs = glob(["**/*.spec.ts"]),
   deps = [
+    "@angular//packages/platform-browser",
     "@angular//packages/platform-browser/animations",
     "//src/cdk/testing",
     "//src/lib/core",
+    "//src/lib/select",
     ":paginator",
   ]
 )
 
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":paginator_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/progress-bar/BUILD.bazel

@@ -49,5 +49,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":progress_bar_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/progress-spinner/BUILD.bazel

@@ -46,7 +46,6 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":progress_spinner_test_sources"],
-  prebuilt_theme = True,
 )
 
 

src/lib/radio/BUILD.bazel

@@ -51,5 +51,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":radio_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/select/BUILD.bazel

@@ -68,5 +68,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":select_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/sidenav/BUILD.bazel

@@ -61,5 +61,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":sidenav_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/slide-toggle/BUILD.bazel

@@ -57,5 +57,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":slide_toggle_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/slider/BUILD.bazel

@@ -56,5 +56,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":slider_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/snack-bar/BUILD.bazel

@@ -65,5 +65,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":snack_bar_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/sort/BUILD.bazel

@@ -54,5 +54,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":sort_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/stepper/BUILD.bazel

@@ -74,5 +74,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":stepper_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/table/BUILD.bazel

@@ -54,5 +54,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":table_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/tabs/BUILD.bazel

@@ -108,5 +108,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":tabs_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/toolbar/BUILD.bazel

@@ -44,7 +44,6 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":toolbar_test_sources"],
-  prebuilt_theme = True,
 )
 
 

src/lib/tooltip/BUILD.bazel

@@ -65,5 +65,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":tooltip_test_sources"],
-  prebuilt_theme = True,
 )

src/lib/tree/BUILD.bazel

@@ -49,5 +49,4 @@ ng_test_library(
 ng_web_test_suite(
   name = "unit_tests",
   deps = [":tree_test_sources"],
-  prebuilt_theme = True,
 )

tools/defaults.bzl

@@ -72,13 +72,12 @@ def ng_test_library(deps = [], tsconfig = None, **kwargs):
     **kwargs
   )
 
-def ng_web_test_suite(deps = [], srcs = [], static_css = [], prebuilt_theme = False,
-                      bootstrap = [], **kwargs):
-
-  # We add a option for including a prebuilt theme in the test suite because otherwise there
-  # will be a lot of code duplication and it just requires more work to setup a test suite.
-  if prebuilt_theme:
-    static_css = static_css + ["//src/lib/prebuilt-themes:indigo-pink"]
+def ng_web_test_suite(deps = [], srcs = [], static_css = [], bootstrap = [], **kwargs):
+  # Always include a prebuilt theme in the test suite because otherwise tests, which depend on CSS
+  # that is needed for measuring, will unexpectedly fail. Also always adding a prebuilt theme
+  # reduces the amount of setup that is needed to create a test suite Bazel target. Note that the
+  # prebuilt theme will be also added to CDK test suites but shouldn't affect anything.
+  static_css = static_css + ["//src/lib/prebuilt-themes:indigo-pink"]
 
   # Workaround for https://github.com/bazelbuild/rules_typescript/issues/301
   # Since some of our tests depend on CSS files which are not part of the `ng_module` rule,