Skip to content

Commit 1e9d6ea

Browse files
committed
build: use specific MDC version
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing #22504 yesterday, because it ended up installing a version that was too old. These changes lock us to a specific version.
1 parent 3fc4e78 commit 1e9d6ea

File tree

3 files changed

+622
-621
lines changed

3 files changed

+622
-621
lines changed

package.json

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"@types/googlemaps": "^3.43.1",
6464
"@types/youtube": "^0.0.42",
6565
"core-js-bundle": "^3.8.2",
66-
"material-components-web": "^12.0.0-canary.00b5899dc.0",
66+
"material-components-web": "12.0.0-canary.b87ebf74d.0",
6767
"rxjs": "^6.5.3",
6868
"rxjs-tslint-rules": "^4.33.1",
6969
"systemjs": "0.19.43",
@@ -95,53 +95,53 @@
9595
"@bazel/terser": "3.5.0",
9696
"@bazel/typescript": "3.5.0",
9797
"@firebase/app-types": "^0.6.1",
98-
"@material/animation": "^12.0.0-canary.00b5899dc.0",
99-
"@material/auto-init": "^12.0.0-canary.00b5899dc.0",
100-
"@material/banner": "^12.0.0-canary.00b5899dc.0",
101-
"@material/base": "^12.0.0-canary.00b5899dc.0",
102-
"@material/button": "^12.0.0-canary.00b5899dc.0",
103-
"@material/card": "^12.0.0-canary.00b5899dc.0",
104-
"@material/checkbox": "^12.0.0-canary.00b5899dc.0",
105-
"@material/chips": "^12.0.0-canary.00b5899dc.0",
106-
"@material/circular-progress": "^12.0.0-canary.00b5899dc.0",
107-
"@material/data-table": "^12.0.0-canary.00b5899dc.0",
108-
"@material/density": "^12.0.0-canary.00b5899dc.0",
109-
"@material/dialog": "^12.0.0-canary.00b5899dc.0",
110-
"@material/dom": "^12.0.0-canary.00b5899dc.0",
111-
"@material/drawer": "^12.0.0-canary.00b5899dc.0",
112-
"@material/elevation": "^12.0.0-canary.00b5899dc.0",
113-
"@material/fab": "^12.0.0-canary.00b5899dc.0",
114-
"@material/feature-targeting": "^12.0.0-canary.00b5899dc.0",
115-
"@material/floating-label": "^12.0.0-canary.00b5899dc.0",
116-
"@material/form-field": "^12.0.0-canary.00b5899dc.0",
117-
"@material/icon-button": "^12.0.0-canary.00b5899dc.0",
118-
"@material/image-list": "^12.0.0-canary.00b5899dc.0",
119-
"@material/layout-grid": "^12.0.0-canary.00b5899dc.0",
120-
"@material/line-ripple": "^12.0.0-canary.00b5899dc.0",
121-
"@material/linear-progress": "^12.0.0-canary.00b5899dc.0",
122-
"@material/list": "^12.0.0-canary.00b5899dc.0",
123-
"@material/menu": "^12.0.0-canary.00b5899dc.0",
124-
"@material/menu-surface": "^12.0.0-canary.00b5899dc.0",
125-
"@material/notched-outline": "^12.0.0-canary.00b5899dc.0",
126-
"@material/radio": "^12.0.0-canary.00b5899dc.0",
127-
"@material/ripple": "^12.0.0-canary.00b5899dc.0",
128-
"@material/rtl": "^12.0.0-canary.00b5899dc.0",
129-
"@material/segmented-button": "^12.0.0-canary.00b5899dc.0",
130-
"@material/select": "^12.0.0-canary.00b5899dc.0",
131-
"@material/shape": "^12.0.0-canary.00b5899dc.0",
132-
"@material/slider": "^12.0.0-canary.00b5899dc.0",
133-
"@material/snackbar": "^12.0.0-canary.00b5899dc.0",
134-
"@material/switch": "^12.0.0-canary.00b5899dc.0",
135-
"@material/tab": "^12.0.0-canary.00b5899dc.0",
136-
"@material/tab-bar": "^12.0.0-canary.00b5899dc.0",
137-
"@material/tab-indicator": "^12.0.0-canary.00b5899dc.0",
138-
"@material/tab-scroller": "^12.0.0-canary.00b5899dc.0",
139-
"@material/textfield": "^12.0.0-canary.00b5899dc.0",
140-
"@material/theme": "^12.0.0-canary.00b5899dc.0",
141-
"@material/tooltip": "^12.0.0-canary.00b5899dc.0",
142-
"@material/top-app-bar": "^12.0.0-canary.00b5899dc.0",
143-
"@material/touch-target": "^12.0.0-canary.00b5899dc.0",
144-
"@material/typography": "^12.0.0-canary.00b5899dc.0",
98+
"@material/animation": "12.0.0-canary.b87ebf74d.0",
99+
"@material/auto-init": "12.0.0-canary.b87ebf74d.0",
100+
"@material/banner": "12.0.0-canary.b87ebf74d.0",
101+
"@material/base": "12.0.0-canary.b87ebf74d.0",
102+
"@material/button": "12.0.0-canary.b87ebf74d.0",
103+
"@material/card": "12.0.0-canary.b87ebf74d.0",
104+
"@material/checkbox": "12.0.0-canary.b87ebf74d.0",
105+
"@material/chips": "12.0.0-canary.b87ebf74d.0",
106+
"@material/circular-progress": "12.0.0-canary.b87ebf74d.0",
107+
"@material/data-table": "12.0.0-canary.b87ebf74d.0",
108+
"@material/density": "12.0.0-canary.b87ebf74d.0",
109+
"@material/dialog": "12.0.0-canary.b87ebf74d.0",
110+
"@material/dom": "12.0.0-canary.b87ebf74d.0",
111+
"@material/drawer": "12.0.0-canary.b87ebf74d.0",
112+
"@material/elevation": "12.0.0-canary.b87ebf74d.0",
113+
"@material/fab": "12.0.0-canary.b87ebf74d.0",
114+
"@material/feature-targeting": "12.0.0-canary.b87ebf74d.0",
115+
"@material/floating-label": "12.0.0-canary.b87ebf74d.0",
116+
"@material/form-field": "12.0.0-canary.b87ebf74d.0",
117+
"@material/icon-button": "12.0.0-canary.b87ebf74d.0",
118+
"@material/image-list": "12.0.0-canary.b87ebf74d.0",
119+
"@material/layout-grid": "12.0.0-canary.b87ebf74d.0",
120+
"@material/line-ripple": "12.0.0-canary.b87ebf74d.0",
121+
"@material/linear-progress": "12.0.0-canary.b87ebf74d.0",
122+
"@material/list": "12.0.0-canary.b87ebf74d.0",
123+
"@material/menu": "12.0.0-canary.b87ebf74d.0",
124+
"@material/menu-surface": "12.0.0-canary.b87ebf74d.0",
125+
"@material/notched-outline": "12.0.0-canary.b87ebf74d.0",
126+
"@material/radio": "12.0.0-canary.b87ebf74d.0",
127+
"@material/ripple": "12.0.0-canary.b87ebf74d.0",
128+
"@material/rtl": "12.0.0-canary.b87ebf74d.0",
129+
"@material/segmented-button": "12.0.0-canary.b87ebf74d.0",
130+
"@material/select": "12.0.0-canary.b87ebf74d.0",
131+
"@material/shape": "12.0.0-canary.b87ebf74d.0",
132+
"@material/slider": "12.0.0-canary.b87ebf74d.0",
133+
"@material/snackbar": "12.0.0-canary.b87ebf74d.0",
134+
"@material/switch": "12.0.0-canary.b87ebf74d.0",
135+
"@material/tab": "12.0.0-canary.b87ebf74d.0",
136+
"@material/tab-bar": "12.0.0-canary.b87ebf74d.0",
137+
"@material/tab-indicator": "12.0.0-canary.b87ebf74d.0",
138+
"@material/tab-scroller": "12.0.0-canary.b87ebf74d.0",
139+
"@material/textfield": "12.0.0-canary.b87ebf74d.0",
140+
"@material/theme": "12.0.0-canary.b87ebf74d.0",
141+
"@material/tooltip": "12.0.0-canary.b87ebf74d.0",
142+
"@material/top-app-bar": "12.0.0-canary.b87ebf74d.0",
143+
"@material/touch-target": "12.0.0-canary.b87ebf74d.0",
144+
"@material/typography": "12.0.0-canary.b87ebf74d.0",
145145
"@octokit/rest": "18.3.5",
146146
"@rollup/plugin-babel": "^5.3.0",
147147
"@rollup/plugin-commonjs": "^18.0.0",

packages.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# all in-sync. This map is passed to each ng_package rule to stamp out the appropriate
33
# version for the placeholders.
44
ANGULAR_PACKAGE_VERSION = "^12.0.0 || ^13.0.0-0"
5-
MDC_PACKAGE_VERSION = "^12.0.0-canary.00b5899dc.0"
5+
MDC_PACKAGE_VERSION = "12.0.0-canary.b87ebf74d.0"
66
TSLIB_PACKAGE_VERSION = "^2.2.0"
77
RXJS_PACKAGE_VERSION = "^6.5.3"
88

0 commit comments

Comments
 (0)