Skip to content

Commit 248dee8

Browse files
devversionjelbourn
authored andcommitted
chore: remove cdk testing from rollup globals (#7169)
Previously the `missingRollupGlobals` tslint rule checked every TS file in the `src/` directory. This meant that the `@angular/cdk/testing` package from spec files needs to be added there as well. With the recent switcht to Minimatch for our custom TSLint rules, the spec files are no longer linted and the testing package can be removed there.
1 parent 3948381 commit 248dee8

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

tools/package-tools/rollup-globals.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,15 @@ export const rollupGlobals = {
4242
'@angular/common/testing': 'ng.common.testing',
4343
'@angular/http/testing': 'ng.http.testing',
4444

45-
45+
// Some packages are not really needed for the UMD bundles, but for the missingRollupGlobals rule.
46+
'@angular/material-examples': 'ng.materialExamples',
4647
'@angular/material': 'ng.material',
4748
'@angular/cdk': 'ng.cdk',
4849

4950
// Include secondary entry-points of the cdk and material packages
5051
...rollupCdkEntryPoints,
5152
...rollupMatEntryPoints,
5253

53-
// Some packages are not really needed for the UMD bundles, but for the missingRollupGlobals rule.
54-
// TODO(devversion): remove by adding minimatch and better globbing to rules
55-
'@angular/cdk/testing': 'ng.cdk.testing',
56-
'@angular/material-examples': 'ng.materialExamples',
57-
5854
'rxjs/BehaviorSubject': 'Rx',
5955
'rxjs/Observable': 'Rx',
6056
'rxjs/Subject': 'Rx',

tools/tslint-rules/tsLoaderRule.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ require('ts-node').register({
1010
// Add a noop rule so tslint doesn't complain.
1111
exports.Rule = class Rule extends Lint.Rules.AbstractRule {
1212
apply() {}
13-
}
13+
};

0 commit comments

Comments
 (0)