Skip to content

Commit 299d8aa

Browse files
committed
build: update shared dev-infra package
Updates the shared dev-infra package to take advanatge of recent improvements for the release tool. This also fixes the issue where the merge tooling requires the `breaking change` label, while there also is the `state: breaking change` label. The ng-dev tool no longer accepts custom configuration of that label. Also the merge configuration no longer accepts custom labels, in order to achieve consistent labeling as specified in the Angular versioning/branching/labeling spec.
1 parent 8103d9b commit 299d8aa

File tree

3 files changed

+153
-167
lines changed

3 files changed

+153
-167
lines changed

.ng-dev/merge.ts

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,22 @@
1-
import {DevInfraMergeConfig} from '@angular/dev-infra-private/ng-dev/pr/merge/config';
2-
import {getDefaultTargetLabelConfiguration} from '@angular/dev-infra-private/ng-dev/pr/merge/defaults';
3-
import {github} from './github';
4-
import {release} from './release';
1+
import {MergeConfig} from '@angular/dev-infra-private/ng-dev/pr/merge/config';
52

63
/**
74
* Configuration for the merge tool in `ng-dev`. This sets up the labels which
85
* are respected by the merge script (e.g. the target labels).
96
*/
10-
export const merge: DevInfraMergeConfig['merge'] = async api => {
11-
return {
12-
// By default, the merge script merges locally with `git cherry-pick` and autosquash.
13-
// This has the downside of pull requests showing up as `Closed` instead of `Merged`.
14-
// In the components repository, since we don't use fixup or squash commits, we can
15-
// use the Github API merge strategy. That way we ensure that PRs show up as `Merged`.
16-
githubApiMerge: {
17-
default: 'squash',
18-
labels: [
19-
{pattern: 'preserve commits', method: 'rebase'}
20-
]
21-
},
22-
claSignedLabel: 'cla: yes',
23-
mergeReadyLabel: 'merge ready',
24-
commitMessageFixupLabel: 'commit message fixup',
25-
caretakerNoteLabel: 'caretaker note',
26-
labels: await getDefaultTargetLabelConfiguration(api, github, release),
27-
};
7+
export const merge: MergeConfig = {
8+
// By default, the merge script merges locally with `git cherry-pick` and autosquash.
9+
// This has the downside of pull requests showing up as `Closed` instead of `Merged`.
10+
// In the components repository, since we don't use fixup or squash commits, we can
11+
// use the Github API merge strategy. That way we ensure that PRs show up as `Merged`.
12+
githubApiMerge: {
13+
default: 'squash',
14+
labels: [
15+
{pattern: 'preserve commits', method: 'rebase'}
16+
]
17+
},
18+
claSignedLabel: 'cla: yes',
19+
mergeReadyLabel: 'merge ready',
20+
commitMessageFixupLabel: 'commit message fixup',
21+
caretakerNoteLabel: 'caretaker note',
2822
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"@angular-devkit/schematics": "12.1.2",
7878
"@angular/bazel": "https://github.com/angular/bazel-builds.git#2566cc859235399edc72749a957f1cdcba2dc121",
7979
"@angular/compiler-cli": "12.1.2",
80-
"@angular/dev-infra-private": "https://github.com/angular/dev-infra-private-builds.git#6254699cc7ccff62be948dc5edcdea87a936ff24",
80+
"@angular/dev-infra-private": "https://github.com/angular/dev-infra-private-builds.git#56655ed6ccf24b7f3ad6b9ccdd1ef2896c7fa9f4",
8181
"@angular/localize": "12.1.2",
8282
"@angular/platform-browser-dynamic": "12.1.2",
8383
"@angular/platform-server": "12.1.2",

0 commit comments

Comments
 (0)