Skip to content

Commit 29f4739

Browse files
committed
chore: remove FakeViewportRuler
Now that all tests have been moved away from the `FakeViewportRuler`, we can safely get rid of it. In general we should avoid stubbing out the window dimensions, because it can be unreliable and it doesn't work well when something is positioned using `bottom` and `right`.
1 parent 60b0625 commit 29f4739

File tree

5 files changed

+1
-37
lines changed

5 files changed

+1
-37
lines changed

src/cdk/testing/fake-viewport-ruler.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

src/cdk/testing/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,4 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
10-
119
export * from './public-api';

src/cdk/testing/public-api.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ export * from './dispatch-events';
1010
export * from './event-objects';
1111
export * from './type-in-element';
1212
export * from './wrapped-error-message';
13-
export * from './fake-viewport-ruler';
1413
export * from './mock-ng-zone';

src/lib/button/button.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
22
import {Component, DebugElement} from '@angular/core';
33
import {By} from '@angular/platform-browser';
4-
import {ViewportRuler} from '@angular/cdk/scrolling';
5-
import {FakeViewportRuler} from '@angular/cdk/testing';
64
import {MatButtonModule} from './index';
75
import {MatRipple} from '@angular/material/core';
86

@@ -13,9 +11,6 @@ describe('MatButton', () => {
1311
TestBed.configureTestingModule({
1412
imports: [MatButtonModule],
1513
declarations: [TestApp],
16-
providers: [
17-
{provide: ViewportRuler, useClass: FakeViewportRuler},
18-
]
1914
});
2015

2116
TestBed.compileComponents();

src/lib/radio/radio.spec.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/t
22
import {FormControl, FormsModule, NgModel, ReactiveFormsModule} from '@angular/forms';
33
import {Component, DebugElement} from '@angular/core';
44
import {By} from '@angular/platform-browser';
5-
import {ViewportRuler} from '@angular/cdk/scrolling';
6-
import {dispatchFakeEvent, FakeViewportRuler} from '@angular/cdk/testing';
5+
import {dispatchFakeEvent} from '@angular/cdk/testing';
76
import {RIPPLE_FADE_IN_DURATION, RIPPLE_FADE_OUT_DURATION} from '@angular/material/core';
87
import {MatRadioButton, MatRadioChange, MatRadioGroup, MatRadioModule} from './index';
98

@@ -20,9 +19,6 @@ describe('MatRadio', () => {
2019
StandaloneRadioButtons,
2120
InterleavedRadioGroup,
2221
TranscludingWrapper
23-
],
24-
providers: [
25-
{provide: ViewportRuler, useClass: FakeViewportRuler}
2622
]
2723
});
2824

0 commit comments

Comments
 (0)