Skip to content

Commit 2ed6b9c

Browse files
committed
fix observable type
1 parent 1904c26 commit 2ed6b9c

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/lib/core/data-table/data-table.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {BehaviorSubject} from 'rxjs/BehaviorSubject';
1919
import 'rxjs/add/operator/let';
2020
import 'rxjs/add/operator/debounceTime';
2121
import 'rxjs/add/observable/combineLatest';
22+
import {Subject} from 'rxjs/Subject';
2223

2324
/**
2425
* Provides a handle for the table to grab the view container's ng-container to insert data rows.
@@ -72,7 +73,7 @@ export class CdkTable implements CollectionViewer {
7273
new BehaviorSubject<{start: number, end: number}>({start: 0, end: Number.MAX_VALUE});
7374

7475
/** Stream that emits when a row def has a change to its array of columns to render. */
75-
columnsChange = new Observable<void[]>();
76+
_columnsChange = new Observable<void>();
7677

7778
/**
7879
* Map of all the user's defined columns identified by name.
@@ -119,23 +120,24 @@ export class CdkTable implements CollectionViewer {
119120

120121
// Get and merge the streams for column changes made to the row defs
121122
const rowDefs = [...this._rowDefinitions.toArray(), this._headerDefinition];
122-
const columnChangeStreams = rowDefs.map((rowDef: BaseRowDef) => rowDef.columnsChange);
123-
this.columnsChange = Observable.combineLatest(columnChangeStreams);
123+
const columnChangeStreams =
124+
rowDefs.map((rowDef: BaseRowDef) => rowDef.columnsChange);
125+
this._columnsChange = Observable.merge(...columnChangeStreams);
124126
}
125127

126128
ngAfterViewInit() {
127129
this.renderHeaderRow();
128130

129131
// Re-render the header row if the columns changed.
130-
this.columnsChange.subscribe(() => {
132+
this._columnsChange.subscribe(() => {
131133
this._headerRowPlaceholder.viewContainer.clear();
132134
this.renderHeaderRow();
133135
});
134136

135137
// TODO(andrewseguin): If the data source is not
136138
// present after view init, connect it when it is defined.
137139
// TODO(andrewseguin): Unsubscribe from this on destroy.
138-
const renderChange = [this.dataSource.connect(this), this.columnsChange];
140+
const renderChange = [this.dataSource.connect(this), this._columnsChange];
139141
Observable.combineLatest(renderChange).subscribe(([data]) => {
140142
// TODO(andrewseguin): Add a differ that will check if the data has changed,
141143
// rather than re-rendering all rows

0 commit comments

Comments
 (0)