build: enforce consistent spacing in curly braces

Adds a rule to enforce that we have consistent spacing inside curly braces and fixes any violations.

Relates to #6615 (comment).

Author: crisbeto

package-lock.json

@@ -115,6 +115,7 @@
     "ts-node": "^3.0.4",
     "tsconfig-paths": "^2.2.0",
     "tslint": "^5.7.0",
+    "tslint-eslint-rules": "^4.1.1",
     "tsutils": "^2.6.0",
     "typescript": "~2.2.1",
     "uglify-js": "^2.8.14",

package.json

@@ -400,7 +400,7 @@ describe('Key managers', () => {
       it('should throw if the items do not implement the getLabel method', () => {
         const invalidQueryList = new FakeQueryList();
 
-        invalidQueryList.items = [{ disabled: false }];
+        invalidQueryList.items = [{disabled: false}];
 
         const invalidManager = new ListKeyManager(invalidQueryList);
 

src/cdk/a11y/list-key-manager.spec.ts

@@ -93,13 +93,13 @@ describe('Observe content', () => {
 });
 
 
-@Component({ template: `<div (cdkObserveContent)="doSomething()">{{text}}</div>` })
+@Component({template: `<div (cdkObserveContent)="doSomething()">{{text}}</div>`})
 class ComponentWithTextContent {
   text = '';
   doSomething() {}
 }
 
-@Component({ template: `<div (cdkObserveContent)="doSomething()"><div>{{text}}<div></div>` })
+@Component({template: `<div (cdkObserveContent)="doSomething()"><div>{{text}}<div></div>`})
 class ComponentWithChildTextContent {
   text = '';
   doSomething() {}

src/cdk/observers/observe-content.spec.ts

@@ -25,7 +25,7 @@ describe('Overlay directives', () => {
           return {getContainerElement: () => overlayContainerElement};
         }},
         {provide: Directionality, useFactory: () => {
-          return dir = { value: 'ltr' };
+          return dir = {value: 'ltr'};
         }}
       ],
     });

src/cdk/overlay/overlay-directives.spec.ts

@@ -480,7 +480,7 @@ describe('OverlayContainer theming', () => {
   let overlayContainerElement: HTMLElement;
 
   beforeEach(async(() => {
-    TestBed.configureTestingModule({ imports: [OverlayContainerThemingTestModule] });
+    TestBed.configureTestingModule({imports: [OverlayContainerThemingTestModule]});
     TestBed.compileComponents();
   }));
 

src/cdk/overlay/overlay.spec.ts

@@ -13,7 +13,7 @@ import {ViewportRuler} from '@angular/cdk/scrolling';
  * Strategy that will prevent the user from scrolling while the overlay is visible.
  */
 export class BlockScrollStrategy implements ScrollStrategy {
-  private _previousHTMLStyles = { top: '', left: '' };
+  private _previousHTMLStyles = {top: '', left: ''};
   private _previousScrollPosition: { top: number, left: number };
   private _isEnabled = false;
 

src/cdk/overlay/scroll/block-scroll-strategy.ts

@@ -482,7 +482,7 @@ class ArbitraryViewContainerRefComponent {
 class PortalTestApp {
   @ViewChildren(TemplatePortalDirective) portals: QueryList<TemplatePortalDirective>;
   @ViewChild(PortalHostDirective) portalHost: PortalHostDirective;
-  @ViewChild('templateRef', { read: TemplateRef }) templateRef: TemplateRef<any>;
+  @ViewChild('templateRef', {read: TemplateRef}) templateRef: TemplateRef<any>;
 
   selectedPortal: Portal<any>;
   fruit: string = 'Banana';

src/cdk/portal/portal.spec.ts

@@ -4,7 +4,7 @@ import {RxChain, map, filter, first} from './index';
 
 describe('RxChain', () => {
   it('should call all of the operators in the chain', () => {
-    let operators = { map, filter, first };
+    let operators = {map, filter, first};
 
     spyOn(operators, 'map');
     spyOn(operators, 'filter');

src/cdk/rxjs/rx-chain.spec.ts

@@ -41,14 +41,14 @@ export function createKeyboardEvent(type: string, keyCode: number, target?: Elem
   // Webkit Browsers don't set the keyCode when calling the init function.
   // See related bug https://bugs.webkit.org/show_bug.cgi?id=16735
   Object.defineProperties(event, {
-    keyCode: { get: () => keyCode },
-    key: { get: () => key },
-    target: { get: () => target }
+    keyCode: {get: () => keyCode},
+    key: {get: () => key},
+    target: {get: () => target}
   });
 
   // IE won't set `defaultPrevented` on synthetic events so we need to do it manually.
   event.preventDefault = function() {
-    Object.defineProperty(event, 'defaultPrevented', { get: () => true });
+    Object.defineProperty(event, 'defaultPrevented', {get: () => true});
     return originalPreventDefault.apply(this, arguments);
   };
 

src/cdk/testing/event-objects.ts

@@ -19,18 +19,18 @@ export class CheckboxAccessibilityDemo {
       name: 'Reminders',
       completed: false,
       subtasks: [
-        { name: 'Cook Dinner', completed: false },
-        { name: 'Read the Material Design Spec', completed: false },
-        { name: 'Upgrade Application to Angular', completed: false }
+        {name: 'Cook Dinner', completed: false},
+        {name: 'Read the Material Design Spec', completed: false},
+        {name: 'Upgrade Application to Angular', completed: false}
       ]
     },
     {
       name: 'Groceries',
       completed: false,
       subtasks: [
-        { name: 'Organic Eggs', completed: false },
-        { name: 'Protein Powder', completed: false },
-        { name: 'Almond Meal Flour', completed: false }
+        {name: 'Organic Eggs', completed: false},
+        {name: 'Protein Powder', completed: false},
+        {name: 'Almond Meal Flour', completed: false}
       ]
     }
   ];

src/demo-app/a11y/checkbox/checkbox-a11y.ts

@@ -21,12 +21,12 @@ export class ChipsAccessibilityDemo {
   message: string = '';
 
   people: Person[] = [
-    { name: 'Kara' },
-    { name: 'Jeremy' },
-    { name: 'Topher' },
-    { name: 'Elad' },
-    { name: 'Kristiyan' },
-    { name: 'Paul' }
+    {name: 'Kara'},
+    {name: 'Jeremy'},
+    {name: 'Topher'},
+    {name: 'Elad'},
+    {name: 'Kristiyan'},
+    {name: 'Paul'}
   ];
 
   displayMessage(message: string): void {
@@ -39,7 +39,7 @@ export class ChipsAccessibilityDemo {
 
     // Add our person
     if ((value || '').trim()) {
-      this.people.push({ name: value.trim() });
+      this.people.push({name: value.trim()});
     }
 
     // Reset the input value
@@ -62,9 +62,9 @@ export class ChipsAccessibilityDemo {
 
 
   availableColors = [
-    { name: 'none', color: '' },
-    { name: 'Primary', color: 'primary' },
-    { name: 'Accent', color: 'accent' },
-    { name: 'Warn', color: 'warn' }
+    {name: 'none', color: ''},
+    {name: 'Primary', color: 'primary'},
+    {name: 'Accent', color: 'accent'},
+    {name: 'Warn', color: 'warn'}
   ];
 }

src/demo-app/a11y/chips/chips-a11y.ts

@@ -13,12 +13,12 @@ export interface Dog {
 })
 export class GridListAccessibilityDemo {
   dogs: Dog[] = [
-    { name: 'Porter', human: 'Kara' },
-    { name: 'Mal', human: 'Jeremy' },
-    { name: 'Koby', human: 'Igor' },
-    { name: 'Razzle', human: 'Ward' },
-    { name: 'Molly', human: 'Rob' },
-    { name: 'Husi', human: 'Matias' },
+    {name: 'Porter', human: 'Kara'},
+    {name: 'Mal', human: 'Jeremy'},
+    {name: 'Koby', human: 'Igor'},
+    {name: 'Razzle', human: 'Ward'},
+    {name: 'Molly', human: 'Rob'},
+    {name: 'Husi', human: 'Matias'},
   ];
 
   tiles = [

src/demo-app/a11y/grid-list/grid-list-a11y.ts

@@ -100,11 +100,11 @@ export class AutocompleteDemo {
       let group = groups.find(g => g.letter === state.name[0]);
 
       if (!group) {
-        group = { letter: state.name[0], states: [] };
+        group = {letter: state.name[0], states: []};
         groups.push(group);
       }
 
-      group.states.push({ code: state.code, name: state.name });
+      group.states.push({code: state.code, name: state.name});
 
       return groups;
     }, [] as StateGroup[]);
@@ -121,7 +121,7 @@ export class AutocompleteDemo {
   filterStateGroups(val: string) {
     if (val) {
       return this.groupedStates
-        .map(group => ({ letter: group.letter, states: this._filter(group.states, val) }))
+        .map(group => ({letter: group.letter, states: this._filter(group.states, val)}))
         .filter(group => group.states.length > 0);
     }
 

src/demo-app/autocomplete/autocomplete-demo.ts

@@ -23,18 +23,18 @@ export class MdCheckboxDemoNestedChecklist {
       name: 'Reminders',
       completed: false,
       subtasks: [
-        { name: 'Cook Dinner', completed: false },
-        { name: 'Read the Material Design Spec', completed: false },
-        { name: 'Upgrade Application to Angular', completed: false }
+        {name: 'Cook Dinner', completed: false},
+        {name: 'Read the Material Design Spec', completed: false},
+        {name: 'Upgrade Application to Angular', completed: false}
       ]
     },
     {
       name: 'Groceries',
       completed: false,
       subtasks: [
-        { name: 'Organic Eggs', completed: false },
-        { name: 'Protein Powder', completed: false },
-        { name: 'Almond Meal Flour', completed: false }
+        {name: 'Organic Eggs', completed: false},
+        {name: 'Protein Powder', completed: false},
+        {name: 'Almond Meal Flour', completed: false}
       ]
     }
   ];

src/demo-app/checkbox/checkbox-demo.ts

@@ -30,19 +30,19 @@ export class ChipsDemo {
   separatorKeysCodes = [ENTER, COMMA, 186];
 
   people: Person[] = [
-    { name: 'Kara' },
-    { name: 'Jeremy' },
-    { name: 'Topher' },
-    { name: 'Elad' },
-    { name: 'Kristiyan' },
-    { name: 'Paul' }
+    {name: 'Kara'},
+    {name: 'Jeremy'},
+    {name: 'Topher'},
+    {name: 'Elad'},
+    {name: 'Kristiyan'},
+    {name: 'Paul'}
   ];
 
   availableColors: DemoColor[] = [
-    { name: 'none', color: '' },
-    { name: 'Primary', color: 'primary' },
-    { name: 'Accent', color: 'accent' },
-    { name: 'Warn', color: 'warn' }
+    {name: 'none', color: ''},
+    {name: 'Primary', color: 'primary'},
+    {name: 'Accent', color: 'accent'},
+    {name: 'Warn', color: 'warn'}
   ];
 
   displayMessage(message: string): void {
@@ -55,7 +55,7 @@ export class ChipsDemo {
 
     // Add our person
     if ((value || '').trim()) {
-      this.people.push({ name: value.trim() });
+      this.people.push({name: value.trim()});
     }
 
     // Reset the input value

src/demo-app/chips/chips-demo.ts

@@ -99,7 +99,7 @@ export class JazzDialog {
     if (this._dimesionToggle) {
       this.dialogRef
         .updateSize('500px', '500px')
-        .updatePosition({ top: '25px', left: '25px' });
+        .updatePosition({top: '25px', left: '25px'});
     } else {
       this.dialogRef
         .updateSize()

src/demo-app/dialog/dialog-demo.ts

@@ -16,12 +16,12 @@ export class GridListDemo {
   ];
 
   dogs: Object[] = [
-    { name: 'Porter', human: 'Kara' },
-    { name: 'Mal', human: 'Jeremy' },
-    { name: 'Koby', human: 'Igor' },
-    { name: 'Razzle', human: 'Ward' },
-    { name: 'Molly', human: 'Rob' },
-    { name: 'Husi', human: 'Matias' },
+    {name: 'Porter', human: 'Kara'},
+    {name: 'Mal', human: 'Jeremy'},
+    {name: 'Koby', human: 'Igor'},
+    {name: 'Razzle', human: 'Ward'},
+    {name: 'Molly', human: 'Rob'},
+    {name: 'Husi', human: 'Matias'},
   ];
 
   basicRowHeight = 80;

src/demo-app/grid-list/grid-list-demo.ts

@@ -1,4 +1,4 @@
-import { Component, ChangeDetectionStrategy } from '@angular/core';
+import {Component, ChangeDetectionStrategy} from '@angular/core';
 import {FormControl, Validators} from '@angular/forms';
 
 
@@ -30,11 +30,11 @@ export class InputDemo {
   dividerColorExample2: string;
   dividerColorExample3: string;
   items: any[] = [
-    { value: 10 },
-    { value: 20 },
-    { value: 30 },
-    { value: 40 },
-    { value: 50 },
+    {value: 10},
+    {value: 20},
+    {value: 30},
+    {value: 40},
+    {value: 50},
   ];
   rows = 8;
   formControl = new FormControl('hello', Validators.required);
@@ -48,7 +48,7 @@ export class InputDemo {
 
   addABunch(n: number) {
     for (let x = 0; x < n; x++) {
-      this.items.push({ value: ++max });
+      this.items.push({value: ++max});
     }
   }
 

src/demo-app/input/input-demo.ts

@@ -23,7 +23,7 @@ export class RippleDemo {
 
   launchRipple(persistent = false) {
     if (this.ripple) {
-      this.ripple.launch(0, 0, { centered: true, persistent });
+      this.ripple.launch(0, 0, {centered: true, persistent});
     }
   }