feat(material/tabs): Responded to PR feedback.

Author: zelliott

src/material-experimental/mdc-tabs/testing/tab-link-harness.ts

@@ -33,12 +33,6 @@ export class MatTabLinkHarness extends ComponentHarness {
     return (await this.host()).text();
   }
 
-  /** Gets the value of the `aria-controls` attribute. */
-  async getAriaControls(): Promise<string | null> {
-    const host = await this.host();
-    return host.getAttribute('aria-controls');
-  }
-
   /** Whether the link is active. */
   async isActive(): Promise<boolean> {
     const host = await this.host();

src/material-experimental/mdc-tabs/testing/tab-nav-bar-harness.ts

@@ -66,7 +66,8 @@ export class MatTabNavBarHarness extends ComponentHarness {
   /** Gets the panel associated with the nav bar. */
   async getPanel(): Promise<MatTabNavPanelHarness> {
     const link = await this.getActiveLink();
-    const panelId = await link.getAriaControls();
+    const host = await link.host();
+    const panelId = await host.getAttribute('aria-controls');
     if (!panelId) {
       throw Error('No panel is controlled by the nav bar.');
     }

src/material-experimental/mdc-tabs/testing/tab-nav-panel-harness.ts

@@ -6,11 +6,11 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ComponentHarness, HarnessPredicate} from '@angular/cdk/testing';
+import {ContentContainerComponentHarness, HarnessPredicate} from '@angular/cdk/testing';
 import {TabNavPanelHarnessFilters} from './tab-harness-filters';
 
 /** Harness for interacting with a standard mat-tab-nav-panel in tests. */
-export class MatTabNavPanelHarness extends ComponentHarness {
+export class MatTabNavPanelHarness extends ContentContainerComponentHarness {
   /** The selector for the host element of a `MatTabNavPanel` instance. */
   static hostSelector = '.mat-mdc-tab-nav-panel';
 

src/material/tabs/testing/tab-link-harness.ts

@@ -33,12 +33,6 @@ export class MatTabLinkHarness extends ComponentHarness {
     return (await this.host()).text();
   }
 
-  /** Gets the value of the `aria-controls` attribute. */
-  async getAriaControls(): Promise<string | null> {
-    const host = await this.host();
-    return host.getAttribute('aria-controls');
-  }
-
   /** Whether the link is active. */
   async isActive(): Promise<boolean> {
     const host = await this.host();

src/material/tabs/testing/tab-nav-bar-harness.ts

@@ -66,7 +66,8 @@ export class MatTabNavBarHarness extends ComponentHarness {
   /** Gets the panel associated with the nav bar. */
   async getPanel(): Promise<MatTabNavPanelHarness> {
     const link = await this.getActiveLink();
-    const panelId = await link.getAriaControls();
+    const host = await link.host();
+    const panelId = await host.getAttribute('aria-controls');
     if (!panelId) {
       throw Error('No panel is controlled by the nav bar.');
     }

src/material/tabs/testing/tab-nav-bar-shared.spec.ts

@@ -65,14 +65,6 @@ export function runTabNavBarHarnessTests(
     expect(await links[2].getLabel()).toBe('Third');
   });
 
-  it('should be able to get the `aria-controls` attribute value of link', async () => {
-    const navBar = await loader.getHarness(tabNavBarHarness);
-    const links = await navBar.getLinks();
-    expect(await links[0].getAriaControls()).toBe('tab-panel');
-    expect(await links[1].getAriaControls()).toBe('tab-panel');
-    expect(await links[2].getAriaControls()).toBe('tab-panel');
-  });
-
   it('should be able to get disabled state of link', async () => {
     const navBar = await loader.getHarness(tabNavBarHarness);
     const links = await navBar.getLinks();

src/material/tabs/testing/tab-nav-panel-harness.ts

@@ -6,11 +6,11 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ComponentHarness, HarnessPredicate} from '@angular/cdk/testing';
+import {ContentContainerComponentHarness, HarnessPredicate} from '@angular/cdk/testing';
 import {TabNavPanelHarnessFilters} from './tab-harness-filters';
 
 /** Harness for interacting with a standard mat-tab-nav-panel in tests. */
-export class MatTabNavPanelHarness extends ComponentHarness {
+export class MatTabNavPanelHarness extends ContentContainerComponentHarness {
   /** The selector for the host element of a `MatTabNavPanel` instance. */
   static hostSelector = '.mat-tab-nav-panel';
 

tools/public_api_guard/material/tabs-testing.md

@@ -37,7 +37,6 @@ export class MatTabHarness extends ContentContainerComponentHarness<string> {
 // @public
 export class MatTabLinkHarness extends ComponentHarness {
     click(): Promise<void>;
-    getAriaControls(): Promise<string | null>;
     getLabel(): Promise<string>;
     static hostSelector: string;
     isActive(): Promise<boolean>;