Skip to content

Commit 3acd6c1

Browse files
devversionandrewseguin
authored andcommitted
fix(ng-update): imports to MatProgressSpinnerModule not migrated (#17717)
For v9 we generated a mapping of symbols and their corresponding secondary entry-points. This map was based on the public API goldens we generate with ts-api-guardian. Unfortunately ts-api-guardian has known limitations with aliased exports which do not have the export keyword on the actual declaration. This means that we currently do not have a mapping for such exports. Temporarily changing ts-api-guardian to handle such cases showed that the progress-bar module is the only instance in the project. Fixes #17715.
1 parent 4794c60 commit 3acd6c1

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/material/progress-spinner/progress-spinner-module.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,4 @@ import {MatProgressSpinner, MatSpinner} from './progress-spinner';
2323
MatSpinner
2424
],
2525
})
26-
class MatProgressSpinnerModule {}
27-
28-
export {MatProgressSpinnerModule};
26+
export class MatProgressSpinnerModule {}

src/material/schematics/ng-update/upgrade-rules/package-imports-v8/material-symbols.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@
313313
"MAT_PROGRESS_SPINNER_DEFAULT_OPTIONS_FACTORY": "progress-spinner",
314314
"MatProgressSpinner": "progress-spinner",
315315
"MatProgressSpinnerDefaultOptions": "progress-spinner",
316+
"MatProgressSpinnerModule": "progress-spinner",
316317
"MatSpinner": "progress-spinner",
317318
"ProgressSpinnerMode": "progress-spinner",
318319
"MAT_RADIO_DEFAULT_OPTIONS": "radio",

tools/public_api_guard/material/progress-spinner.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ export interface MatProgressSpinnerDefaultOptions {
2929
strokeWidth?: number;
3030
}
3131

32+
export declare class MatProgressSpinnerModule {
33+
static ɵinj: i0.ɵɵInjectorDef<MatProgressSpinnerModule>;
34+
static ɵmod: i0.ɵɵNgModuleDefWithMeta<MatProgressSpinnerModule, [typeof i1.MatProgressSpinner, typeof i1.MatSpinner], [typeof i2.MatCommonModule, typeof i3.CommonModule], [typeof i1.MatProgressSpinner, typeof i1.MatSpinner, typeof i2.MatCommonModule]>;
35+
}
36+
3237
export declare class MatSpinner extends MatProgressSpinner {
3338
constructor(elementRef: ElementRef<HTMLElement>, platform: Platform, document: any, animationMode: string, defaults?: MatProgressSpinnerDefaultOptions);
3439
static ngAcceptInputType_diameter: number | string | null | undefined;

0 commit comments

Comments
 (0)