Skip to content

Commit 3be5d0e

Browse files
committed
build: switch progress spinner e2e to MDC
Removes the e2e app entry for the legacy progress spinner and renames the MDC progress spinner.
1 parent a19b01f commit 3be5d0e

File tree

14 files changed

+14
-94
lines changed

14 files changed

+14
-94
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@
249249
/src/e2e-app/expansion/** @andrewseguin
250250
/src/e2e-app/grid-list/** @andrewseguin
251251
/src/e2e-app/icon/** @andrewseguin
252-
/src/e2e-app/legacy-progress-spinner/** @andrewseguin @crisbeto
253252
/src/e2e-app/legacy-radio/** @andrewseguin @devversion
254253
/src/e2e-app/legacy-slide-toggle/** @devversion
255254
/src/e2e-app/legacy-tabs/** @andrewseguin
@@ -261,7 +260,7 @@
261260
/src/e2e-app/input/** @devversion
262261
/src/e2e-app/menu/** @crisbeto
263262
/src/e2e-app/progress-bar/** @crisbeto
264-
/src/e2e-app/mdc-progress-spinner/** @mmalerba
263+
/src/e2e-app/progress-spinner/** @mmalerba
265264
/src/e2e-app/mdc-radio/** @mmalerba
266265
/src/e2e-app/mdc-slide-toggle/** @crisbeto
267266
/src/e2e-app/mdc-slider/** @andrewseguin

src/e2e-app/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ ng_module(
5252
"//src/material/input",
5353
"//src/material/legacy-form-field",
5454
"//src/material/legacy-list",
55-
"//src/material/legacy-progress-spinner",
5655
"//src/material/legacy-radio",
5756
"//src/material/legacy-slide-toggle",
5857
"//src/material/legacy-tabs",

src/e2e-app/e2e-app/e2e-app-layout.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@ export class E2eAppLayout {
3939
{path: 'mdc-slide-toggle', title: 'MDC Slide Toggle'},
4040
{path: 'mdc-table', title: 'MDC Table'},
4141
{path: 'mdc-tabs', title: 'MDC Tabs'},
42-
{path: 'mdc-progress-spinner', title: 'MDC Progress spinner'},
4342
];
4443
}

src/e2e-app/legacy-progress-spinner/legacy-progress-spinner-e2e-module.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/e2e-app/legacy-progress-spinner/legacy-progress-spinner-e2e.html

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/e2e-app/legacy-progress-spinner/legacy-progress-spinner-e2e.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/e2e-app/main-module.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {E2eAppModule} from './e2e-app/e2e-app-module';
1111
import {ExpansionE2eModule} from './expansion/expansion-e2e-module';
1212
import {GridListE2eModule} from './grid-list/grid-list-e2e-module';
1313
import {IconE2eModule} from './icon/icon-e2e-module';
14-
import {LegacyProgressSpinnerE2eModule} from './legacy-progress-spinner/legacy-progress-spinner-e2e-module';
1514
import {LegacyRadioE2eModule} from './legacy-radio/legacy-radio-e2e-module';
1615
import {LegacySlideToggleE2eModule} from './legacy-slide-toggle/legacy-slide-toggle-e2e-module';
1716
import {LegacyTabsE2eModule} from './legacy-tabs/legacy-tabs-e2e-module';
@@ -21,7 +20,7 @@ import {CheckboxE2eModule} from './checkbox/checkbox-e2e-module';
2120
import {DialogE2eModule} from './dialog/dialog-e2e-module';
2221
import {MenuE2eModule} from './menu/menu-e2e-module';
2322
import {ProgressBarE2eModule} from './progress-bar/progress-bar-e2e-module';
24-
import {MdcProgressSpinnerE2eModule} from './mdc-progress-spinner/mdc-progress-spinner-module';
23+
import {ProgressSpinnerE2eModule} from './progress-spinner/progress-spinner-module';
2524
import {MdcRadioE2eModule} from './mdc-radio/mdc-radio-e2e-module';
2625
import {MdcSlideToggleE2eModule} from './mdc-slide-toggle/mdc-slide-toggle-e2e-module';
2726
import {MdcSliderE2eModule} from './mdc-slider/mdc-slider-e2e-module';
@@ -51,7 +50,6 @@ const enableAnimations = window.location.search.includes('animations=true');
5150
ExpansionE2eModule,
5251
GridListE2eModule,
5352
IconE2eModule,
54-
LegacyProgressSpinnerE2eModule,
5553
LegacyRadioE2eModule,
5654
LegacySlideToggleE2eModule,
5755
LegacyTabsE2eModule,
@@ -61,7 +59,7 @@ const enableAnimations = window.location.search.includes('animations=true');
6159
DialogE2eModule,
6260
MenuE2eModule,
6361
ProgressBarE2eModule,
64-
MdcProgressSpinnerE2eModule,
62+
ProgressSpinnerE2eModule,
6563
MdcRadioE2eModule,
6664
MdcSliderE2eModule,
6765
MdcSlideToggleE2eModule,

src/e2e-app/mdc-progress-spinner/mdc-progress-spinner-e2e.ts renamed to src/e2e-app/progress-spinner/progress-spinner-e2e.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
import {Component} from '@angular/core';
1010

1111
@Component({
12-
selector: 'mdc-progress-spinner-e2e',
13-
templateUrl: 'mdc-progress-spinner-e2e.html',
12+
selector: 'progress-spinner-e2e',
13+
templateUrl: 'progress-spinner-e2e.html',
1414
})
15-
export class MdcProgressSpinnerE2e {
15+
export class ProgressSpinnerE2e {
1616
value = 65;
1717
diameter = 37;
1818
strokeWidth = 6;

src/e2e-app/mdc-progress-spinner/mdc-progress-spinner-module.ts renamed to src/e2e-app/progress-spinner/progress-spinner-module.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
import {NgModule} from '@angular/core';
1010
import {MatProgressSpinnerModule} from '@angular/material/progress-spinner';
11-
import {MdcProgressSpinnerE2e} from './mdc-progress-spinner-e2e';
11+
import {ProgressSpinnerE2e} from './progress-spinner-e2e';
1212

1313
@NgModule({
1414
imports: [MatProgressSpinnerModule],
15-
declarations: [MdcProgressSpinnerE2e],
15+
declarations: [ProgressSpinnerE2e],
1616
})
17-
export class MdcProgressSpinnerE2eModule {}
17+
export class ProgressSpinnerE2eModule {}

src/e2e-app/routes.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {Home} from './e2e-app/e2e-app-layout';
77
import {ExpansionE2e} from './expansion/expansion-e2e';
88
import {GridListE2E} from './grid-list/grid-list-e2e';
99
import {IconE2E} from './icon/icon-e2e';
10-
import {LegacyProgressSpinnerE2e} from './legacy-progress-spinner/legacy-progress-spinner-e2e';
1110
import {LegacyRadioE2e} from './legacy-radio/legacy-radio-e2e';
1211
import {LegacySlideToggleE2e} from './legacy-slide-toggle/legacy-slide-toggle-e2e';
1312
import {LegacyTabsE2e} from './legacy-tabs/legacy-tabs-e2e';
@@ -18,7 +17,7 @@ import {DialogE2E} from './dialog/dialog-e2e';
1817
import {InputE2E} from './input/input-e2e';
1918
import {MenuE2e} from './menu/menu-e2e';
2019
import {ProgressBarE2E} from './progress-bar/progress-bar-e2e';
21-
import {MdcProgressSpinnerE2e} from './mdc-progress-spinner/mdc-progress-spinner-e2e';
20+
import {ProgressSpinnerE2e} from './progress-spinner/progress-spinner-e2e';
2221
import {MdcRadioE2e} from './mdc-radio/mdc-radio-e2e';
2322
import {MdcSlideToggleE2e} from './mdc-slide-toggle/mdc-slide-toggle-e2e';
2423
import {MdcSliderE2e} from './mdc-slider/mdc-slider-e2e';
@@ -43,14 +42,13 @@ export const E2E_APP_ROUTES: Routes = [
4342
{path: 'input', component: InputE2E},
4443
{path: 'menu', component: MenuE2e},
4544
{path: 'progress-bar', component: ProgressBarE2E},
46-
{path: 'legacy-progress-spinner', component: LegacyProgressSpinnerE2e},
45+
{path: 'progress-spinner', component: ProgressSpinnerE2e},
4746
{path: 'legacy-radio', component: LegacyRadioE2e},
4847
{path: 'legacy-slide-toggle', component: LegacySlideToggleE2e},
4948
{path: 'legacy-tabs', component: LegacyTabsE2e},
5049
{path: 'list', component: ListE2e},
5150
{path: 'button', component: ButtonE2e},
5251
{path: 'dialog', component: DialogE2E},
53-
{path: 'mdc-progress-spinner', component: MdcProgressSpinnerE2e},
5452
{path: 'mdc-radio', component: MdcRadioE2e},
5553
{path: 'mdc-slide-toggle', component: MdcSlideToggleE2e},
5654
{path: 'mdc-slider', component: MdcSliderE2e},

src/material/legacy-progress-spinner/BUILD.bazel

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
21
load(
32
"//tools:defaults.bzl",
4-
"ng_e2e_test_library",
53
"ng_module",
64
"ng_test_library",
75
"ng_web_test_suite",
@@ -48,10 +46,7 @@ sass_binary(
4846

4947
ng_test_library(
5048
name = "unit_test_sources",
51-
srcs = glob(
52-
["**/*.spec.ts"],
53-
exclude = ["**/*.e2e.spec.ts"],
54-
),
49+
srcs = glob(["**/*.spec.ts"]),
5550
deps = [
5651
":legacy-progress-spinner",
5752
"//src/cdk/platform",
@@ -65,22 +60,6 @@ ng_web_test_suite(
6560
deps = [":unit_test_sources"],
6661
)
6762

68-
ng_e2e_test_library(
69-
name = "e2e_test_sources",
70-
srcs = glob(["**/*.e2e.spec.ts"]),
71-
deps = [
72-
"//src/cdk/testing/private/e2e",
73-
],
74-
)
75-
76-
e2e_test_suite(
77-
name = "e2e_tests",
78-
deps = [
79-
":e2e_test_sources",
80-
"//src/cdk/testing/private/e2e",
81-
],
82-
)
83-
8463
filegroup(
8564
name = "source-files",
8665
srcs = glob(["**/*.ts"]),

src/material/legacy-progress-spinner/progress-spinner.e2e.spec.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/material/progress-spinner/progress-spinner.e2e.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {browser, by, element} from 'protractor';
22

3-
describe('MDC-based progress-spinner', () => {
4-
beforeEach(async () => await browser.get('/mdc-progress-spinner'));
3+
describe('progress-spinner', () => {
4+
beforeEach(async () => await browser.get('/progress-spinner'));
55

66
it('should render a determinate progress spinner', async () => {
77
expect(await element(by.css('mat-progress-spinner')).isPresent()).toBe(true);

0 commit comments

Comments
 (0)