Skip to content

Commit 4b70890

Browse files
crisbetojelbourn
authored andcommitted
chore: move OverlayModule and related providers into index file
Moves the `OverlayModule` and the `OVERLAY_PROVIDERS` into the `index.ts`, as opposed to the `overlay-directives.ts`, in order to match the setup in the rest of the modules.
1 parent aee984a commit 4b70890

File tree

9 files changed

+45
-43
lines changed

9 files changed

+45
-43
lines changed

src/lib/core/core.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {BidiModule} from './bidi/index';
1212
import {ObserveContentModule} from './observe-content/observe-content';
1313
import {MdOptionModule} from './option/index';
1414
import {PortalModule} from './portal/portal-directives';
15-
import {OverlayModule} from './overlay/overlay-directives';
15+
import {OverlayModule} from './overlay/index';
1616
import {A11yModule} from './a11y/index';
1717
import {MdSelectionModule} from './selection/index';
1818
import {MdRippleModule} from './ripple/index';

src/lib/core/overlay/index.ts

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,38 @@
55
* Use of this source code is governed by an MIT-style license that can be
66
* found in the LICENSE file at https://angular.io/license
77
*/
8+
import {NgModule, Provider} from '@angular/core';
9+
import {Overlay} from './overlay';
10+
import {ScrollDispatchModule} from './scroll/index';
11+
import {PortalModule} from '../portal/portal-directives';
12+
import {ConnectedOverlayDirective, OverlayOrigin} from './overlay-directives';
13+
import {OverlayPositionBuilder} from './position/overlay-position-builder';
14+
import {VIEWPORT_RULER_PROVIDER} from './position/viewport-ruler';
15+
import {OVERLAY_CONTAINER_PROVIDER} from './overlay-container';
816

9-
export {Overlay, OVERLAY_PROVIDERS} from './overlay';
17+
18+
export const OVERLAY_PROVIDERS: Provider[] = [
19+
Overlay,
20+
OverlayPositionBuilder,
21+
VIEWPORT_RULER_PROVIDER,
22+
OVERLAY_CONTAINER_PROVIDER,
23+
];
24+
25+
@NgModule({
26+
imports: [PortalModule, ScrollDispatchModule],
27+
exports: [ConnectedOverlayDirective, OverlayOrigin, ScrollDispatchModule],
28+
declarations: [ConnectedOverlayDirective, OverlayOrigin],
29+
providers: [OVERLAY_PROVIDERS],
30+
})
31+
export class OverlayModule {}
32+
33+
34+
export {Overlay} from './overlay';
1035
export {OverlayContainer} from './overlay-container';
1136
export {FullscreenOverlayContainer} from './fullscreen-overlay-container';
1237
export {OverlayRef} from './overlay-ref';
1338
export {OverlayState} from './overlay-state';
14-
export {ConnectedOverlayDirective, OverlayOrigin, OverlayModule} from './overlay-directives';
39+
export {ConnectedOverlayDirective, OverlayOrigin} from './overlay-directives';
1540
export {ViewportRuler} from './position/viewport-ruler';
1641

1742
export * from './position/connected-position';

src/lib/core/overlay/overlay-directives.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {ComponentFixture, TestBed, async} from '@angular/core/testing';
22
import {Component, ViewChild} from '@angular/core';
33
import {By} from '@angular/platform-browser';
4-
import {ConnectedOverlayDirective, OverlayModule, OverlayOrigin} from './overlay-directives';
4+
import {ConnectedOverlayDirective, OverlayModule, OverlayOrigin} from './index';
55
import {OverlayContainer} from './overlay-container';
66
import {ConnectedPositionStrategy} from './position/connected-position-strategy';
77
import {ConnectedOverlayPositionChange} from './position/connected-position';

src/lib/core/overlay/overlay-directives.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*/
88

99
import {
10-
NgModule,
1110
Directive,
1211
EventEmitter,
1312
TemplateRef,
@@ -21,23 +20,21 @@ import {
2120
OnChanges,
2221
SimpleChanges,
2322
} from '@angular/core';
24-
import {Overlay, OVERLAY_PROVIDERS} from './overlay';
23+
import {Overlay} from './overlay';
2524
import {OverlayRef} from './overlay-ref';
2625
import {TemplatePortal} from '../portal/portal';
2726
import {OverlayState} from './overlay-state';
2827
import {
2928
ConnectionPositionPair,
3029
ConnectedOverlayPositionChange
3130
} from './position/connected-position';
32-
import {PortalModule} from '../portal/portal-directives';
3331
import {ConnectedPositionStrategy} from './position/connected-position-strategy';
3432
import {Directionality, Direction} from '../bidi/index';
3533
import {Scrollable} from './scroll/scrollable';
3634
import {ScrollStrategy} from './scroll/scroll-strategy';
3735
import {coerceBooleanProperty} from '../coercion/boolean-property';
3836
import {ESCAPE} from '../keyboard/keycodes';
3937
import {Subscription} from 'rxjs/Subscription';
40-
import {ScrollDispatchModule} from './scroll/index';
4138

4239

4340
/** Default set of positions for the overlay. Follows the behavior of a dropdown. */
@@ -326,12 +323,3 @@ export class ConnectedOverlayDirective implements OnDestroy, OnChanges {
326323
});
327324
}
328325
}
329-
330-
331-
@NgModule({
332-
imports: [PortalModule, ScrollDispatchModule],
333-
exports: [ConnectedOverlayDirective, OverlayOrigin, ScrollDispatchModule],
334-
declarations: [ConnectedOverlayDirective, OverlayOrigin],
335-
providers: [OVERLAY_PROVIDERS],
336-
})
337-
export class OverlayModule {}

src/lib/core/overlay/overlay.spec.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,17 @@ import {inject, TestBed, async, ComponentFixture} from '@angular/core/testing';
22
import {NgModule, Component, ViewChild, ViewContainerRef} from '@angular/core';
33
import {TemplatePortalDirective, PortalModule} from '../portal/portal-directives';
44
import {TemplatePortal, ComponentPortal} from '../portal/portal';
5-
import {Overlay} from './overlay';
6-
import {OverlayContainer} from './overlay-container';
7-
import {OverlayState} from './overlay-state';
8-
import {OverlayRef} from './overlay-ref';
9-
import {PositionStrategy} from './position/position-strategy';
10-
import {OverlayModule} from './overlay-directives';
11-
import {ViewportRuler} from './position/viewport-ruler';
12-
import {ScrollStrategy, ScrollDispatcher} from './scroll/index';
5+
import {
6+
OverlayModule,
7+
OverlayRef,
8+
OverlayState,
9+
OverlayContainer,
10+
Overlay,
11+
PositionStrategy,
12+
ViewportRuler,
13+
ScrollStrategy,
14+
ScrollDispatcher,
15+
} from './index';
1316

1417

1518
describe('Overlay', () => {

src/lib/core/overlay/overlay.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,12 @@ import {
1212
ApplicationRef,
1313
Injector,
1414
NgZone,
15-
Provider,
1615
} from '@angular/core';
1716
import {OverlayState} from './overlay-state';
1817
import {DomPortalHost} from '../portal/dom-portal-host';
1918
import {OverlayRef} from './overlay-ref';
2019
import {OverlayPositionBuilder} from './position/overlay-position-builder';
21-
import {VIEWPORT_RULER_PROVIDER} from './position/viewport-ruler';
22-
import {OverlayContainer, OVERLAY_CONTAINER_PROVIDER} from './overlay-container';
20+
import {OverlayContainer} from './overlay-container';
2321
import {ScrollStrategy, ScrollStrategyOptions} from './scroll/index';
2422

2523

@@ -99,11 +97,3 @@ export class Overlay {
9997
return new OverlayRef(portalHost, pane, state, scrollStrategy, this._ngZone);
10098
}
10199
}
102-
103-
/** Providers for Overlay and its related injectables. */
104-
export const OVERLAY_PROVIDERS: Provider[] = [
105-
Overlay,
106-
OverlayPositionBuilder,
107-
VIEWPORT_RULER_PROVIDER,
108-
OVERLAY_CONTAINER_PROVIDER,
109-
];

src/lib/core/overlay/scroll/scroll-dispatcher.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import {inject, TestBed, async, fakeAsync, ComponentFixture, tick} from '@angular/core/testing';
22
import {NgModule, Component, ViewChild, ElementRef} from '@angular/core';
3-
import {ScrollDispatcher} from './scroll-dispatcher';
4-
import {OverlayModule} from '../overlay-directives';
5-
import {Scrollable} from './scrollable';
3+
import {OverlayModule, Scrollable, ScrollDispatcher} from '../index';
64
import {dispatchFakeEvent} from '../../testing/dispatch-events';
75

86
describe('Scroll Dispatcher', () => {

src/lib/sidenav/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {NgModule} from '@angular/core';
1010
import {CommonModule} from '@angular/common';
1111
import {MdCommonModule} from '../core';
1212
import {A11yModule} from '../core/a11y/index';
13-
import {OverlayModule} from '../core/overlay/overlay-directives';
13+
import {OverlayModule} from '../core/overlay/index';
1414
import {MdSidenav, MdSidenavContainer} from './sidenav';
1515

1616

src/lib/tooltip/tooltip.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ import {AnimationEvent} from '@angular/animations';
1616
import {By} from '@angular/platform-browser';
1717
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
1818
import {TooltipPosition, MdTooltip, MdTooltipModule, SCROLL_THROTTLE_MS} from './index';
19-
import {OverlayContainer} from '../core';
2019
import {Directionality, Direction} from '../core/bidi/index';
21-
import {OverlayModule} from '../core/overlay/overlay-directives';
20+
import {OverlayModule, Scrollable, OverlayContainer} from '../core/overlay/index';
2221
import {Platform} from '../core/platform/platform';
23-
import {Scrollable} from '../core/overlay/scroll/scrollable';
2422
import {dispatchFakeEvent} from '../core/testing/dispatch-events';
2523

2624

0 commit comments

Comments
 (0)