build: update tooling to no longer support view engine mode

Updates the build setup to no longer support the View Engine
mode through a Bazel define flag.

Author: devversion

.bazelrc

@@ -51,14 +51,11 @@ build:release --stamp
 build:snapshot-build --workspace_status_command="yarn -s ng-dev release build-env-stamp --mode=snapshot"
 build:snapshot-build --stamp
 
-################################
-# View Engine / Ivy toggle     #
-################################
-build:view-engine --define=angular_ivy_enabled=False
-build:ivy --define=angular_ivy_enabled=True
 
-# Set Ivy as the default
-build --config=ivy
+##################################
+# Always enable Ivy compilation  #
+##################################
+build --define=angular_ivy_enabled=True
 
 ################################
 # Remote Execution Setup       #

.circleci/config.yml

@@ -197,28 +197,6 @@ jobs:
       - run: bazel build --build_tag_filters=-docs-package,-release-package -- src/...
       - *slack_notify_on_failure
 
-  # -----------------------------------
-  # Job which ensures that all non-test Bazel targets build properly
-  # in View Engine configuration.
-  # -----------------------------------
-  view_engine_build:
-    <<: *job_defaults
-    resource_class: xlarge
-    environment:
-      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
-    steps:
-      - checkout_and_rebase
-      - *restore_cache
-      - *setup_bazel_ci_config
-      - *setup_bazel_remote_execution
-      - *yarn_install
-      - *setup_bazel_binary
-
-      # Exclude release and docs packages here as those will be built within
-      # the "build_release_packages" and "publish_snapshots" jobs.
-      - run: bazel build --build_tag_filters=-docs-package,-release-package --config=view-engine -- src/...
-      - *slack_notify_on_failure
-
   # --------------------------------------------------------------------------------------------
   # Job that runs API golden tests in "tools/public_api_guard".
   # This job fails whenever an API has been updated but not explicitly approved through goldens.
@@ -525,48 +503,6 @@ jobs:
     - run: bazel test --build_tag_filters=-e2e --test_tag_filters=-e2e --build_tests_only -- src/...
     - *slack_notify_on_failure
 
-  # ----------------------------------------------------------------------------
-  # Job that runs all Bazel tests against View Engine with the current Angular version
-  # specified in the project dev dependencies.
-  # ----------------------------------------------------------------------------
-  view_engine_test:
-    <<: *job_defaults
-    resource_class: xlarge
-    environment:
-      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
-    steps:
-      - checkout_and_rebase
-      - *restore_cache
-      - *setup_bazel_ci_config
-      - *setup_bazel_remote_execution
-      - *yarn_install
-      - *setup_bazel_binary
-
-      # Run project tests with NGC and View Engine.
-      - run: bazel test --build_tag_filters=-docs-package,-e2e --test_tag_filters=-e2e --config=view-engine --build_tests_only -- src/...
-      - *slack_notify_on_failure
-
-  # ----------------------------------------------------------------------------
-  # Job that runs all Bazel tests against View Engine from angular/angular#master.
-  # ----------------------------------------------------------------------------
-  view_engine_snapshot_test_cronjob:
-    <<: *job_defaults
-    resource_class: xlarge
-    environment:
-      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
-    steps:
-      - checkout_and_rebase
-      - *restore_cache
-      - *setup_bazel_ci_config
-      - *setup_bazel_remote_execution
-      - *setup_snapshot_builds
-      - *yarn_install_loose_lockfile
-      - *setup_bazel_binary
-
-      # Run project tests with NGC and View Engine.
-      - run: bazel test --build_tag_filters=-docs-package,-e2e --test_tag_filters=-e2e --config=view-engine --build_tests_only -- src/...
-      - *slack_notify_on_failure
-
   # ----------------------------------------------------------------------------
   # Job that runs all Bazel integration tests.
   # ----------------------------------------------------------------------------
@@ -584,7 +520,6 @@ jobs:
       - *setup_bazel_binary
 
       - run: yarn integration-tests:partial-ivy
-      - run: yarn integration-tests:view-engine
       # TODO: Re-enable when there are integration tests that should run with Ivy.
       # Currently this command fails as there are no tests.
       # - run: yarn integration-tests
@@ -654,10 +589,6 @@ workflows:
     jobs:
       - bazel_build:
           filters: *ignore_presubmit_branch_filter
-      - view_engine_build:
-          filters: *ignore_presubmit_branch_filter
-      - view_engine_test:
-          filters: *ignore_presubmit_branch_filter
       - api_golden_checks:
           filters: *ignore_presubmit_branch_filter
       - integration_tests:
@@ -702,8 +633,6 @@ workflows:
       # workflow. See: https://circleci.com/ideas/?idea=CCI-I-295
       - snapshot_tests_local_browsers:
           filters: *only_main_branch_filter
-      - view_engine_snapshot_test_cronjob:
-          filters: *only_main_branch_filter
       - mdc_snapshot_test_cronjob:
           filters: *only_main_branch_filter
       - integration_tests_snapshot:

integration/size-test/index.bzl

@@ -48,7 +48,6 @@ def size_test(name, file, deps):
         },
         deps = [
             ":%s_lib" % name,
-            "//tools:angular_ivy_enabled",
             "@npm//rollup-plugin-node-resolve",
             "@npm//@angular-devkit/build-optimizer",
         ],

integration/size-test/rollup.config.js

@@ -1,8 +1,5 @@
 const {buildOptimizer} = require('@angular-devkit/build-optimizer/src/build-optimizer/build-optimizer');
 const node = require('rollup-plugin-node-resolve');
-const {ivyEnabled} = require('angular_material/tools/angular_ivy_enabled');
-
-console.info(`Processing rollup bundle in ${ivyEnabled ? 'Ivy' : 'View Engine'} mode.`);
 
 const buildOptimizerPlugin = {
   name: 'build-optimizer',
@@ -30,9 +27,7 @@ module.exports = {
   plugins: [
     buildOptimizerPlugin,
     node({
-      mainFields: ivyEnabled ?
-          ['es2015_ivy_ngcc', 'module_ivy_ngcc','es2015', 'module'] :
-          ['es2015', 'module'],
+      mainFields: ['es2020', 'module'],
     }),
   ],
 };

integration/ts-compat/BUILD.bazel

@@ -38,11 +38,6 @@ typescript_version_packages = [
             "@npm//@types/node",
         ],
         entry_point = "test.js",
-        tags = [
-            # These tests run in view engine only as the release packages are
-            # built with View Engine and we want to reproduce this here.
-            "view-engine-only",
-        ],
     )
     for ts_pkg_name in typescript_version_packages
 ]

scripts/build-packages-dist.ts

@@ -45,27 +45,25 @@ if (module === require.main) {
 
 /** Builds the release packages for NPM. */
 export function performNpmReleaseBuild(): BuiltPackage[] {
-  return buildReleasePackages(false, defaultDistPath, /* isSnapshotBuild */ false);
+  return buildReleasePackages(defaultDistPath, /* isSnapshotBuild */ false);
 }
 
 /**
  * Builds the release packages as snapshot build. This means that the current
  * Git HEAD SHA is included in the version (for easier debugging and back tracing).
  */
 export function performDefaultSnapshotBuild(): BuiltPackage[] {
-  return buildReleasePackages(false, defaultDistPath, /* isSnapshotBuild */ true);
+  return buildReleasePackages(defaultDistPath, /* isSnapshotBuild */ true);
 }
 
 /**
  * Builds the release packages with the given compile mode and copies
  * the package output into the given directory.
  */
-function buildReleasePackages(useIvy: boolean, distPath: string,
-                              isSnapshotBuild: boolean): BuiltPackage[] {
+function buildReleasePackages(distPath: string, isSnapshotBuild: boolean): BuiltPackage[] {
 
   console.log('######################################');
   console.log('  Building release packages...');
-  console.log(`  Compiling with Ivy: ${useIvy}`);
   console.log('######################################');
 
   // List of targets to build. e.g. "src/cdk:npm_package", or "src/material:npm_package".
@@ -78,7 +76,6 @@ function buildReleasePackages(useIvy: boolean, distPath: string,
   // runs the workspace stamping script. The stamping script ensures that the
   // version placeholder is populated in the release output.
   const stampConfigArg = `--config=${isSnapshotBuild ? 'snapshot-build' : 'release'}`;
-  const ivySwitchConfigArg = `--config=${useIvy ? 'ivy' : 'view-engine'}`;
 
   // Walk through each release package and clear previous "npm_package" outputs. This is
   // a workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1219. We need to
@@ -91,7 +88,7 @@ function buildReleasePackages(useIvy: boolean, distPath: string,
     }
   });
 
-  exec(`${bazelCmd} build ${stampConfigArg} ${ivySwitchConfigArg} ${targets.join(' ')}`);
+  exec(`${bazelCmd} build ${stampConfigArg} ${targets.join(' ')}`);
 
   // Delete the distribution directory so that the output is guaranteed to be clean. Re-create
   // the empty directory so that we can copy the release packages into it later.

scripts/run-component-tests.js

@@ -35,9 +35,9 @@ shelljs.set('-e');
 shelljs.cd(projectDir);
 
 // Extracts the supported command line options.
-const {_: components, local, firefox, watch, 'view-engine': viewEngine} = minimist(args, {
-  boolean: ['local', 'firefox', 'watch', 'view-engine'],
-  default: {watch: true, 'view-engine': false},
+const {_: components, local, firefox, watch} = minimist(args, {
+  boolean: ['local', 'firefox', 'watch'],
+  default: {watch: true},
 });
 
 // Whether tests for all components should be run.
@@ -54,7 +54,6 @@ if (local && (components.length > 1 || all)) {
 
 const browserName = firefox ? 'firefox' : 'chromium';
 const bazelBinary = `yarn -s ${watch ? 'ibazel' : 'bazel'}`;
-const configFlag = viewEngine ? '--config=view-engine' : '';
 
 // If `all` has been specified as component, we run tests for all components
 // in the repository. The `--firefox` flag can be still specified.
@@ -68,7 +67,7 @@ if (all) {
   }
   shelljs.exec(
       `yarn -s bazel test --test_tag_filters=-e2e,browser:${browserName} ` +
-      `--build_tag_filters=browser:${browserName} --build_tests_only ${configFlag} //src/...`);
+      `--build_tag_filters=browser:${browserName} --build_tests_only //src/...`);
   return;
 }
 
@@ -89,7 +88,7 @@ const testLabels = components
     .map(t => `${getBazelPackageOfComponentName(t)}:${getTargetName(t)}`);
 
 // Runs Bazel for the determined test labels.
-shelljs.exec(`${bazelBinary} ${bazelAction} ${testLabels.join(' ')} ${configFlag}`);
+shelljs.exec(`${bazelBinary} ${bazelAction} ${testLabels.join(' ')}`);
 
 /**
  * Gets the Bazel package label for the specified component name. Throws if

tools/BUILD.bazel

@@ -7,20 +7,6 @@ exports_files([
     "system-rxjs-operators.js",
 ])
 
-config_setting(
-    name = "view_engine_mode",
-    values = {
-        "define": "angular_ivy_enabled=False",
-    },
-)
-
-# Bazel build setting for enabling partial compilation. The partial compilation
-# build setting can be set using `--//tools:partial_compilation=True`.
-bool_flag(
-    name = "partial_compilation",
-    build_setting_default = False,
-)
-
 # Bazel config setting that matches if the partial compilation flag is set to `True`.
 config_setting(
     name = "partial_compilation_enabled",

tools/release-checks/npm-package-output/output-validations.ts

@@ -17,7 +17,7 @@ const bazelManifestPath = /(angular_material|external)\//;
  * List of fields which are mandatory in entry-point "package.json" files and refer
  * to files in the release output.
  */
-const packageJsonPathFields = ['main', 'module', 'typings', 'es2015', 'fesm2015', 'esm2015'];
+const packageJsonPathFields = ['module', 'typings', 'fesm2015', 'fesm2020', 'esm2020'];
 
 /**
  * Checks the specified JavaScript file and ensures that it does not