fix(material/schematics): update JSON.parse usages to cast the result as a type

Update JSON.parse usages to be better typed rather than resulting in an
any type.

Author: josephperrott

src/material/schematics/ng-add/index.spec.ts

@@ -13,6 +13,10 @@ import {getWorkspace} from '@schematics/angular/utility/workspace';
 import {COLLECTION_PATH} from '../index.spec';
 import {addPackageToPackageJson} from './package-config';
 
+interface PackageJson {
+  dependencies: Record<string, string>;
+}
+
 describe('ng-add schematic', () => {
   let runner: SchematicTestRunner;
   let appTree: Tree;
@@ -43,7 +47,7 @@ describe('ng-add schematic', () => {
 
   /** Removes the specified dependency from the /package.json in the given tree. */
   function removePackageJsonDependency(tree: Tree, dependencyName: string) {
-    const packageContent = JSON.parse(getFileContent(tree, '/package.json'));
+    const packageContent = JSON.parse(getFileContent(tree, '/package.json')) as PackageJson;
     delete packageContent.dependencies[dependencyName];
     tree.overwrite('/package.json', JSON.stringify(packageContent, null, 2));
   }
@@ -55,7 +59,7 @@ describe('ng-add schematic', () => {
     removePackageJsonDependency(appTree, '@angular/animations');
 
     const tree = await runner.runSchematicAsync('ng-add', {}, appTree).toPromise();
-    const packageJson = JSON.parse(getFileContent(tree, '/package.json'));
+    const packageJson = JSON.parse(getFileContent(tree, '/package.json')) as PackageJson;
     const dependencies = packageJson.dependencies;
     const angularCoreVersion = dependencies['@angular/core'];
 
@@ -87,7 +91,7 @@ describe('ng-add schematic', () => {
     addPackageToPackageJson(appTree, '@angular/material', '^9.0.0');
 
     const tree = await runner.runSchematicAsync('ng-add', {}, appTree).toPromise();
-    const packageJson = JSON.parse(getFileContent(tree, '/package.json'));
+    const packageJson = JSON.parse(getFileContent(tree, '/package.json')) as PackageJson;
     const dependencies = packageJson.dependencies;
 
     expect(dependencies['@angular/material']).toBe('^9.0.0');

src/material/schematics/ng-add/package-config.ts

@@ -8,6 +8,10 @@
 
 import {Tree} from '@angular-devkit/schematics';
 
+interface PackageJson {
+  dependencies: Record<string, string>;
+}
+
 /**
  * Sorts the keys of the given object.
  * @returns A new object instance with sorted keys
@@ -21,7 +25,7 @@ export function addPackageToPackageJson(host: Tree, pkg: string, version: string
 
   if (host.exists('package.json')) {
     const sourceText = host.read('package.json')!.toString('utf-8');
-    const json = JSON.parse(sourceText);
+    const json = JSON.parse(sourceText) as PackageJson;
 
     if (!json.dependencies) {
       json.dependencies = {};
@@ -44,7 +48,7 @@ export function getPackageVersionFromPackageJson(tree: Tree, name: string): stri
     return null;
   }
 
-  const packageJson = JSON.parse(tree.read('package.json')!.toString('utf8'));
+  const packageJson = JSON.parse(tree.read('package.json')!.toString('utf8')) as PackageJson;
 
   if (packageJson.dependencies && packageJson.dependencies[name]) {
     return packageJson.dependencies[name];

src/material/schematics/ng-update/migrations/hammer-gestures-v9/hammer-gestures-migration.ts

@@ -59,6 +59,10 @@ interface IdentifierReference {
   isImport: boolean;
 }
 
+interface PackageJson {
+  dependencies: Record<string, string>;
+}
+
 export class HammerGesturesMigration extends DevkitMigration<null> {
   // Only enable this rule if the migration targets v9 or v10 and is running for a non-test
   // target. We cannot migrate test targets since they have a limited scope
@@ -853,7 +857,7 @@ export class HammerGesturesMigration extends DevkitMigration<null> {
       return false;
     }
 
-    const packageJson = JSON.parse(tree.read('/package.json')!.toString('utf8'));
+    const packageJson = JSON.parse(tree.read('/package.json')!.toString('utf8')) as PackageJson;
 
     // We do not handle the case where someone manually added "hammerjs" to the dev dependencies.
     if (packageJson.dependencies && packageJson.dependencies[HAMMER_MODULE_SPECIFIER]) {

src/material/schematics/ng-update/test-cases/v9/misc/hammer-migration-v9.spec.ts

@@ -5,6 +5,11 @@ import {createTestCaseSetup, resolveBazelPath} from '@angular/cdk/schematics/tes
 import {readFileSync} from 'fs';
 import {MIGRATION_PATH} from '../../../../index.spec';
 
+
+interface PackageJson {
+  dependencies: Record<string, string | undefined>;
+}
+
 describe('v9 HammerJS removal', () => {
   const GESTURE_CONFIG_TEMPLATE_PATH = resolveBazelPath(__dirname,
       '../../../migrations/hammer-gestures-v9/gesture-config.template');
@@ -55,11 +60,11 @@ describe('v9 HammerJS removal', () => {
     it('should remove hammerjs from "package.json" file', async () => {
       addPackageToPackageJson(tree, 'hammerjs', '0.0.0');
 
-      expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs']).toBe('0.0.0');
+      expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs']).toBe('0.0.0');
 
       await runMigration();
 
-      expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs'])
+      expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs'])
           .toBe(undefined);
 
       // expect that there is a "node-package" install task. The task is
@@ -803,7 +808,7 @@ describe('v9 HammerJS removal', () => {
   it('should not remove hammerjs if test target compilation scope does not contain hammerjs usage',
      async () => {
        addPackageToPackageJson(tree, 'hammerjs', '0.0.0');
-       expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs']).toBe('0.0.0');
+       expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs']).toBe('0.0.0');
 
        // we simulate a case where a component does not have any tests for. In that case,
        // the test target compilation scope does not include "test.component.ts" and the
@@ -820,14 +825,14 @@ describe('v9 HammerJS removal', () => {
 
        await runMigration();
 
-       expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs']).toBe('0.0.0');
+       expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs']).toBe('0.0.0');
      });
 
   it('should not remove hammerjs from "package.json" file if used in one project while ' +
       'unused in other project', async () => {
     addPackageToPackageJson(tree, 'hammerjs', '0.0.0');
 
-    expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs']).toBe('0.0.0');
+    expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs']).toBe('0.0.0');
 
     await runner.runExternalSchematicAsync('@schematics/angular', 'application',
       {name: 'second-project'}, tree).toPromise();
@@ -840,7 +845,7 @@ describe('v9 HammerJS removal', () => {
     await runMigration();
 
     expect(runner.tasks.some(t => t.name === 'node-package')).toBe(false);
-    expect(JSON.parse(tree.readContent('/package.json')).dependencies['hammerjs'])
+    expect((JSON.parse(tree.readContent('/package.json')) as PackageJson).dependencies['hammerjs'])
       .toBe('0.0.0');
   });