Skip to content

Commit 5c25fca

Browse files
crisbetoannieyw
authored andcommitted
build: fix compilation errors in utility scripts (#21488)
Fixes a few compilation errors in some utility scripts that haven't been caught by the CI. (cherry picked from commit 64c3917)
1 parent 211bee7 commit 5c25fca

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

tools/dev-server/dev-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class DevServer {
3939

4040
/** Starts the server on the given port. */
4141
async start() {
42-
return new Promise((resolve, reject) => {
42+
return new Promise<void>((resolve, reject) => {
4343
this.server.init(this.options, (err) => {
4444
if (err) {
4545
reject(err);

tools/release/changelog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export async function prependChangelogFromLatestTag(changelogPath: string, relea
6969
// actually prepend the new changelog to the existing one.
7070
const previousChangelogStream = createReadStream(changelogPath);
7171

72-
return new Promise((resolve, reject) => {
72+
return new Promise<void>((resolve, reject) => {
7373
// Sequentially merge the changelog output and the previous changelog stream, so that
7474
// the new changelog section comes before the existing versions. Afterwards, pipe into the
7575
// changelog file, so that the changes are reflected on file system.

tools/release/release-output/check-package.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function checkReleasePackage(
3737
releasesPath: string, packageName: string, expectedVersion: string): boolean {
3838
const packagePath = join(releasesPath, packageName);
3939
const failures = new Map() as PackageFailures;
40-
const addFailure = (message, filePath?) => {
40+
const addFailure = (message: string, filePath?: string) => {
4141
const filePaths = failures.get(message) || [];
4242
if (filePath) {
4343
filePaths.push(filePath);

0 commit comments

Comments
 (0)