Re-enable codelyzer lint, turn off ivy

Author: jelbourn

.bazelrc

@@ -38,11 +38,10 @@ test --test_output=errors
 build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js"
 
 ################################
-# Settings for Ivy             #
+# View Engine / Ivy toggle     #
 ################################
 
-# We want to compile with Ivy and with "ngtsc".
-# To build for ViewEngine, use --define=compile=legacy.
+# Use "legacy" for ViewEngine and "aot" for Ivy
 build --define=compile=aot
 
 #######################

package.json

@@ -35,8 +35,7 @@
     "format:bazel": "yarn -s bazel:buildifier --lint=fix --mode=fix",
     "format": "yarn -s format:ts && yarn -s format:bazel",
     "cherry-pick-patch": "ts-node --project tools/cherry-pick-patch/ tools/cherry-pick-patch/cherry-pick-patch.ts",
-    "check-rollup-globals": "ts-node --project scripts/ scripts/check-rollup-globals.ts",
-    "debug": "ngc -p ./src/cdk/coercion/tsconfig-build.json"
+    "check-rollup-globals": "ts-node --project scripts/ scripts/check-rollup-globals.ts"
   },
   "version": "9.0.0-next.0",
   "requiredAngularVersion": "^9.0.0-0 || ^10.0.0-0",
@@ -99,7 +98,7 @@
     "browser-sync": "^2.26.7",
     "chalk": "^2.4.2",
     "clang-format": "^1.2.4",
-    "codelyzer": "^5.1.2",
+    "codelyzer": "^5.2.0",
     "conventional-changelog": "^3.0.5",
     "dgeni": "^0.4.11",
     "dgeni-packages": "^0.27.1",

src/cdk/overlay/overlay-config.ts

@@ -74,7 +74,7 @@ export class OverlayConfig {
           // is not smart enough to see that the right-hand-side is actually an access of the same
           // exact type with the same exact key, meaning that the value type must be identical.
           // So we use `any` to work around this.
-          this[key] = (config)[key] as any;
+          this[key] = config[key] as any;
         }
       }
     }

tools/defaults.bzl

@@ -97,6 +97,8 @@ def ng_module(
         deps = local_deps,
         tsconfig = tsconfig,
         testonly = testonly,
+        # TODO(jelbourn): re-enable type checking after granular flags land in Angular.
+        type_check = False,
         **kwargs
     )
 

tslint.json

@@ -92,8 +92,7 @@
     // Codelyzer
     "template-banana-in-box": true,
     "contextual-lifecycle": true,
-    // TODO(jelbourn): re-enable this when it works with TS 3.6
-    // "contextual-decorator": true,
+    "contextual-decorator": true,
     "no-output-on-prefix": true,
     "template-no-negated-async": true,
     "use-lifecycle-interface": true,

yarn.lock

@@ -2950,10 +2950,10 @@ code-point-at@^1.0.0:
   resolved "https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77"
   integrity sha1-DQcLTQQ6W+ozovGkDi7bPZpMz3c=
 
-codelyzer@^5.1.2:
-  version "5.1.2"
-  resolved "https://registry.yarnpkg.com/codelyzer/-/codelyzer-5.1.2.tgz#e6c08269f8796483e57e6d9b7c29723572472b1d"
-  integrity sha512-1z7mtpwxcz5uUqq0HLO0ifj/tz2dWEmeaK+8c5TEZXAwwVxrjjg0118ODCOCCOcpfYaaEHxStNCaWVYo9FUPXw==
+codelyzer@^5.2.0:
+  version "5.2.0"
+  resolved "https://registry.yarnpkg.com/codelyzer/-/codelyzer-5.2.0.tgz#b0ee573a12779c996090e596c5c1755479d83758"
+  integrity sha512-izfUfhEOOgAizszPlEDxo71DK/C4wprZw0vkY6UWcOSTQvN1JyfXf9DXwaV7WX+/JC+hH0ShXfdtGLA9Rca7LA==
   dependencies:
     app-root-path "^2.2.1"
     aria-query "^3.0.0"