Address feedback

Author: devversion

src/lib/list/selection-list.spec.ts

@@ -539,7 +539,7 @@ describe('MatSelectionList with forms', () => {
         .map(optionDebugEl => optionDebugEl.componentInstance);
     });
 
-    it('should update the model if an option got selected', fakeAsync(() => {
+    it('should update the model if an option got selected programmatically', fakeAsync(() => {
       expect(fixture.componentInstance.selectedOptions.length)
         .toBe(0, 'Expected no options to be selected by default');
 
@@ -651,8 +651,8 @@ describe('MatSelectionList with forms', () => {
       fixture.componentInstance.formControl.setValue(['opt2', 'opt3']);
       fixture.detectChanges();
 
-      expect(listOptions[1].selected).toBe(true, 'Expected option to be selected.');
-      expect(listOptions[2].selected).toBe(true, 'Expected option to be selected.');
+      expect(listOptions[1].selected).toBe(true, 'Expected first option to be selected.');
+      expect(listOptions[2].selected).toBe(true, 'Expected second option to be selected.');
 
       fixture.componentInstance.formControl.setValue(null);
       fixture.detectChanges();

src/lib/list/selection-list.ts

@@ -352,17 +352,17 @@ export class MatSelectionList extends _MatSelectionListMixinBase implements Focu
   }
 
   /** Implemented as part of ControlValueAccessor. */
-  registerOnChange(fn: any): void {
+  registerOnChange(fn: (value: any) => void): void {
     this._onChange = fn;
   }
 
   /** Implemented as part of ControlValueAccessor. */
-  registerOnTouched(fn: any): void {
+  registerOnTouched(fn: () => void): void {
     this.onTouched = fn;
   }
 
   /** Returns the option with the specified value. */
-  private _getOptionFromValue(value: string): MatListOption | undefined {
+  private _getOptionByValue(value: string): MatListOption | undefined {
     return this.options.find(option => option.value === value);
   }
 
@@ -371,8 +371,8 @@ export class MatSelectionList extends _MatSelectionListMixinBase implements Focu
     this.options.forEach(option => option._setSelected(false));
 
     values
-      .map(value => this._getOptionFromValue(value))
-      .filter(option => !!option)
+      .map(value => this._getOptionByValue(value))
+      .filter(Boolean)
       .forEach(option => option!._setSelected(true));
   }