Skip to content

Commit 6777427

Browse files
crisbetojelbourn
authored andcommitted
build: fix builds not failing with compilation errors in unit tests (#9248)
Fixes the CI continuing to run even though it failed to compile, due to a couple of promises that weren't rejecting properly. This should avoids things like #9073 slipping through.
1 parent b6da765 commit 6777427

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

tools/package-tools/build-package.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export class BuildPackage {
107107
return ngcCompile(['-p', entryPointTsconfigPath]).catch(() => {
108108
const error = red(`Failed to compile ${secondaryEntryPoint} using ${entryPointTsconfigPath}`);
109109
console.error(error);
110+
return Promise.reject(error);
110111
});
111112
}
112113

tools/package-tools/compile-entry-point.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export async function compileEntryPoint(buildPackage: BuildPackage, tsconfigName
2222
return ngcCompile(ngcFlags).catch(() => {
2323
const error = red(`Failed to compile ${secondaryEntryPoint} using ${entryPointTsconfigPath}`);
2424
console.error(error);
25+
return Promise.reject(error);
2526
});
2627
}
2728

0 commit comments

Comments
 (0)