Skip to content

Commit 68d98c3

Browse files
devversionandrewseguin
authored andcommitted
build: update nodejs rules (#14622)
Updates to the latest version of the NodeJS rules that includes bazel-contrib/rules_nodejs@c40ceb9
1 parent 22b0ad6 commit 68d98c3

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

WORKSPACE

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
55
# Add NodeJS rules (explicitly used for sass bundle rules)
66
http_archive(
77
name = "build_bazel_rules_nodejs",
8-
# TODO(devversion): temporarily depend on a specific commit because we want to make sure that
9-
# our CI is not flaky until there is a new version of the NodeJS rules. See commit:
10-
# https://github.com/bazelbuild/rules_nodejs/commit/c40ceb960af4213164d4299d8fbc8220ebdd727f
11-
url = "https://github.com/bazelbuild/rules_nodejs/archive/c40ceb960af4213164d4299d8fbc8220ebdd727f.zip",
12-
strip_prefix = "rules_nodejs-c40ceb960af4213164d4299d8fbc8220ebdd727f",
8+
url = "https://github.com/bazelbuild/rules_nodejs/archive/0.16.4.zip",
9+
strip_prefix = "rules_nodejs-0.16.4",
1310
)
1411

1512
# Add TypeScript rules
@@ -83,7 +80,7 @@ check_bazel_version("0.18.0")
8380

8481
node_repositories(
8582
# For deterministic builds, specify explicit NodeJS and Yarn versions.
86-
node_version = "10.10.0",
83+
node_version = "10.13.0",
8784
# Use latest yarn version to support integrity field (added in yarn 1.10)
8885
yarn_version = "1.12.1",
8986
)

tools/release/publish-release.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ class PublishReleaseTask extends BaseReleaseTask {
242242

243243
/** Creates a specified tag and pushes it to the remote repository */
244244
private createAndPushReleaseTag(tagName: string, releaseNotes: string) {
245-
// TODO(devversion): find a way to extract the changelog part just for this version.
246245
if (!this.git.createTag('HEAD', tagName, releaseNotes)) {
247246
console.error(red(` ✘ Could not create the "${tagName}" tag.`));
248247
console.error(red(` Please make sure there is no existing tag with the same name.`));

0 commit comments

Comments
 (0)