Skip to content

Commit 6987b44

Browse files
committed
build: remove ng_package entry-point workaround
We recently had to switch all `ts_library` entry points to use `ng_module` because the `ng_package` rule did not properly handle `ts_library` targets as entry-points. angular/angular@217db9b fixed this issue upstream and we can now use `ts_library` instead of `ng_module` for vanilla TS entry-points.
1 parent 7f6972f commit 6987b44

File tree

22 files changed

+48
-44
lines changed

22 files changed

+48
-44
lines changed

src/cdk/coercion/BUILD.bazel

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ng_module", "ts_library")
3+
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "coercion",
77
srcs = glob(
88
["**/*.ts"],
99
exclude = ["**/*.spec.ts"],
1010
),
1111
module_name = "@angular/cdk/coercion",
12+
deps = [
13+
"@npm//@angular/core",
14+
],
1215
)
1316

1417
ts_library(

src/cdk/keycodes/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ng_module", "ts_library")
3+
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "keycodes",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/input/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/mdc-button/testing/BUILD.bazel

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],
@@ -17,6 +17,7 @@ ng_module(
1717
)
1818

1919
ng_test_library(
20+
c,
2021
name = "unit_tests_lib",
2122
srcs = glob(["**/*.spec.ts"]),
2223
deps = [

src/material-experimental/mdc-checkbox/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/mdc-chips/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/mdc-menu/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/mdc-slide-toggle/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material-experimental/select/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/autocomplete/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/button/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/checkbox/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/dialog/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/menu/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/progress-bar/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/progress-spinner/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/radio/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/sidenav/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/slide-toggle/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/slider/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/snack-bar/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

src/material/tabs/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
3+
load("//tools:defaults.bzl", "ng_test_library", "ng_web_test_suite", "ts_library")
44

5-
ng_module(
5+
ts_library(
66
name = "testing",
77
srcs = glob(
88
["**/*.ts"],

0 commit comments

Comments
 (0)