Skip to content

Commit 6c424ba

Browse files
committed
ci: migrate package archive uploading job to GHA
Migrate the package archive uploading job from CircleCI to Github Actions (cherry picked from commit 17f259d)
1 parent eceefd9 commit 6c424ba

File tree

2 files changed

+26
-21
lines changed

2 files changed

+26
-21
lines changed

.circleci/config.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -197,21 +197,6 @@ jobs:
197197
- 'releases/**/*'
198198
- *slack_notify_on_failure
199199

200-
upload_release_packages:
201-
<<: *job_defaults
202-
steps:
203-
- checkout_and_rebase
204-
- *restore_cache
205-
- *attach_release_output
206-
- *yarn_install
207-
208-
# Creates package archives and passes in an appropriate meaningful archive suffix. The
209-
# suffix consists of the pull request number and a short SHA describing the current `HEAD`.
210-
- run: ./scripts/create-package-archives.js --suffix "pr$CIRCLE_PR_NUMBER-$(git rev-parse --short HEAD)"
211-
# Upload archives to the CircleCI job artifacts.
212-
- store_artifacts:
213-
path: dist/release-archives
214-
215200
# ----------------------------------------
216201
# Job that publishes the docs site
217202
# ----------------------------------------
@@ -246,12 +231,6 @@ workflows:
246231
jobs:
247232
- build_release_packages:
248233
filters: *ignore_presubmit_branch_filter
249-
- upload_release_packages:
250-
# We don't want to run this job on push builds because for those, the
251-
# `publish_snapshots` runs, and publishes build artifacts.
252-
filters: *only_on_pull_requests_filter
253-
requires:
254-
- build_release_packages
255234
- deploy_docs_site:
256235
filters: *publish_branches_filter
257236
requires:

.github/workflows/ci.yml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,3 +270,29 @@ jobs:
270270
slack-message: 'Snapshot publishing failed for ${{ github.base_ref }} branch failed on build ${{ github.event.after }}: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}'
271271
env:
272272
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
273+
274+
upload_package_artifacts:
275+
if: ${{ github.event_name != 'push'}}
276+
runs-on: ubuntu-latest-4core
277+
steps:
278+
- name: Initialize environment
279+
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
280+
with:
281+
cache-node-modules: true
282+
- name: Setup Bazel
283+
uses: angular/dev-infra/github-actions/bazel/setup@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
284+
- name: Setup Bazel RBE
285+
uses: angular/dev-infra/github-actions/bazel/configure-remote@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
286+
- name: Install node modules
287+
run: yarn install --frozen-lockfile
288+
- name: Build and Verify Release Output
289+
run: yarn build-and-check-release-output
290+
- name: Verify tooling setup
291+
run: yarn check-tooling-setup
292+
- name: Build and create package artifacts
293+
run: ./scripts/create-package-archives.js --suffix "pr${{github.event.number}}-$(git rev-parse --short HEAD)"
294+
- name: Upload artifacts
295+
uses: actions/upload-artifact@v3
296+
with:
297+
name: Package Artifacts
298+
path: dist/release-archives

0 commit comments

Comments
 (0)