Skip to content

Commit 6d6495e

Browse files
committed
feat(material/core): switch option implementation to use MDC
Switches the implementation of `mat-option` and `mat-optgroup` to use MDC by default.
1 parent 6883100 commit 6d6495e

File tree

95 files changed

+1210
-850
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+1210
-850
lines changed

src/material-experimental/_index.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
// MDC-related themes
1818
@forward './mdc-core/core-theme' as mdc-core-* show mdc-core-theme, mdc-core-color,
1919
mdc-core-density, mdc-core-typography;
20-
@forward './mdc-core/option/option-theme' as mdc-option-* show mdc-option-color,
21-
mdc-option-typography, mdc-option-density, mdc-option-theme;
22-
@forward './mdc-core/option/optgroup-theme' as mdc-optgroup-* show mdc-optgroup-color,
23-
mdc-optgroup-typography, mdc-optgroup-density, mdc-optgroup-theme;
2420
@forward './mdc-autocomplete/autocomplete-theme' as mdc-autocomplete-* show mdc-autocomplete-color,
2521
mdc-autocomplete-typography, mdc-autocomplete-density, mdc-autocomplete-theme;
2622
@forward './mdc-button/button-theme' as mdc-button-* show mdc-button-color, mdc-button-typography,

src/material-experimental/config.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ entryPoints = [
88
"mdc-checkbox/testing",
99
"mdc-chips",
1010
"mdc-chips/testing",
11-
"mdc-core",
12-
"mdc-core/testing",
1311
"mdc-dialog",
1412
"mdc-dialog/testing",
1513
"mdc-list",

src/material-experimental/mdc-autocomplete/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ng_module(
1616
deps = [
1717
"//src/cdk/overlay",
1818
"//src/cdk/scrolling",
19-
"//src/material-experimental/mdc-core",
19+
"//src/material/core",
2020
"//src/material/autocomplete",
2121
"@npm//@angular/common",
2222
],
@@ -58,7 +58,7 @@ ng_test_library(
5858
"//src/cdk/platform",
5959
"//src/cdk/scrolling",
6060
"//src/cdk/testing/private",
61-
"//src/material-experimental/mdc-core",
61+
"//src/material/core",
6262
"//src/material/form-field",
6363
"//src/material/input",
6464
"@npm//@angular/forms",

src/material-experimental/mdc-autocomplete/autocomplete-trigger.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@
99
import {Directive, forwardRef} from '@angular/core';
1010
import {NG_VALUE_ACCESSOR} from '@angular/forms';
1111
import {_MatAutocompleteTriggerBase} from '@angular/material/autocomplete';
12-
import {
13-
_countGroupLabelsBeforeOption,
14-
_getOptionScrollPosition,
15-
} from '@angular/material-experimental/mdc-core';
12+
import {_countGroupLabelsBeforeOption, _getOptionScrollPosition} from '@angular/material/core';
1613

1714
/**
1815
* Provider that allows the autocomplete to register as a ControlValueAccessor.

src/material-experimental/mdc-autocomplete/autocomplete.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import {
3636
tick,
3737
} from '@angular/core/testing';
3838
import {FormControl, FormsModule, ReactiveFormsModule} from '@angular/forms';
39-
import {MatOption, MatOptionSelectionChange} from '@angular/material-experimental/mdc-core';
39+
import {MatOption, MatOptionSelectionChange} from '@angular/material/core';
4040
import {MatFormField, MatFormFieldModule} from '@angular/material/form-field';
4141
import {MatInputModule} from '@angular/material/input';
4242
import {By} from '@angular/platform-browser';

src/material-experimental/mdc-autocomplete/autocomplete.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
MAT_OPTION_PARENT_COMPONENT,
1919
MatOptgroup,
2020
MatOption,
21-
} from '@angular/material-experimental/mdc-core';
21+
} from '@angular/material/core';
2222
import {_MatAutocompleteBase} from '@angular/material/autocomplete';
2323
import {panelAnimation} from './animations';
2424

src/material-experimental/mdc-autocomplete/module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {NgModule} from '@angular/core';
10-
import {MatCommonModule, MatOptionModule} from '@angular/material-experimental/mdc-core';
10+
import {MatCommonModule, MatOptionModule} from '@angular/material/core';
1111
import {CommonModule} from '@angular/common';
1212
import {CdkScrollableModule} from '@angular/cdk/scrolling';
1313
import {OverlayModule} from '@angular/cdk/overlay';

src/material-experimental/mdc-autocomplete/testing/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ts_library(
1010
),
1111
deps = [
1212
"//src/cdk/testing",
13-
"//src/material-experimental/mdc-core/testing",
13+
"//src/material/core/testing",
1414
"//src/material/autocomplete/testing",
1515
],
1616
)

src/material-experimental/mdc-autocomplete/testing/autocomplete-harness.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
MatOptionHarness,
1313
OptgroupHarnessFilters,
1414
OptionHarnessFilters,
15-
} from '@angular/material-experimental/mdc-core/testing';
15+
} from '@angular/material/core/testing';
1616
import {_MatAutocompleteHarnessBase} from '@angular/material/autocomplete/testing';
1717
import {AutocompleteHarnessFilters} from './autocomplete-harness-filters';
1818

src/material-experimental/mdc-core/BUILD.bazel

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ ng_module(
1515
["**/*.ts"],
1616
exclude = ["**/*.spec.ts"],
1717
),
18-
assets = [
19-
":option/option.css",
20-
":option/optgroup.css",
21-
] + glob(["**/*.html"]),
18+
assets = glob(["**/*.html"]),
2219
deps = [
2320
"//src/material/core",
2421
"@npm//@angular/common",
@@ -36,26 +33,6 @@ sass_library(
3633
],
3734
)
3835

39-
sass_binary(
40-
name = "option_scss",
41-
src = "option/option.scss",
42-
deps = [
43-
"//:mdc_sass_lib",
44-
"//src/material:sass_lib",
45-
"//src/material/core:core_scss_lib",
46-
],
47-
)
48-
49-
sass_binary(
50-
name = "optgroup_scss",
51-
src = "option/optgroup.scss",
52-
deps = [
53-
"//:mdc_sass_lib",
54-
"//src/material:sass_lib",
55-
"//src/material/core:core_scss_lib",
56-
],
57-
)
58-
5936
#################
6037
# Test targets
6138
#################

src/material-experimental/mdc-core/_core-theme.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
@use 'sass:map';
22
@use '@angular/material' as mat;
33

4-
@use './option/option-theme';
5-
@use './option/optgroup-theme';
64
@use './elevation';
75

86

97
@mixin color($config-or-theme) {
108
$config: mat.get-color-config($config-or-theme);
119

12-
@include option-theme.color($config);
13-
@include optgroup-theme.color($config);
14-
1510
@if $config != null {
1611
// Provides external CSS classes for each elevation value. Each CSS class is formatted as
1712
// `mat-mdc-elevation-z$zValue` where `$zValue` corresponds to the z-space to which the
@@ -41,16 +36,10 @@
4136
@mixin typography($config-or-theme) {
4237
$config: mat.private-typography-to-2018-config(
4338
mat.get-typography-config($config-or-theme));
44-
45-
@include option-theme.typography($config-or-theme);
46-
@include optgroup-theme.typography($config-or-theme);
4739
}
4840

4941
@mixin density($config-or-theme) {
5042
$density-scale: mat.get-density-config($config-or-theme);
51-
52-
@include option-theme.density($density-scale);
53-
@include optgroup-theme.density($density-scale);
5443
}
5544

5645
// Mixin that renders all of the core styles that depend on the theme.

src/material-experimental/mdc-core/option/_optgroup-theme.import.scss

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/material-experimental/mdc-core/option/_optgroup-theme.scss

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/material-experimental/mdc-core/option/_option-theme.import.scss

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/material-experimental/mdc-core/option/_option-theme.scss

Lines changed: 0 additions & 85 deletions
This file was deleted.

src/material-experimental/mdc-core/option/optgroup.html

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/material-experimental/mdc-core/option/optgroup.scss

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/material-experimental/mdc-core/option/optgroup.ts

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)