build: enforce consistent readonly array type

Author: rafaelss95

src/cdk-experimental/popover-edit/popover-edit.spec.ts

@@ -1,20 +1,19 @@
+import {BidiModule, Direction} from '@angular/cdk/bidi';
 import {DataSource} from '@angular/cdk/collections';
-import {LEFT_ARROW, UP_ARROW, RIGHT_ARROW, DOWN_ARROW, TAB} from '@angular/cdk/keycodes';
+import {DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW, TAB, UP_ARROW} from '@angular/cdk/keycodes';
+import {OverlayContainer} from '@angular/cdk/overlay';
 import {CdkTableModule} from '@angular/cdk/table';
 import {dispatchKeyboardEvent} from '@angular/cdk/testing/private';
 import {CommonModule} from '@angular/common';
-import {Component, Directive, ElementRef, Type, ViewChild} from '@angular/core';
-import {ComponentFixture, fakeAsync, flush, TestBed, tick, inject} from '@angular/core/testing';
+import {Component, Directive, ElementRef, ViewChild} from '@angular/core';
+import {ComponentFixture, fakeAsync, flush, inject, TestBed, tick} from '@angular/core/testing';
 import {FormsModule, NgForm} from '@angular/forms';
-import {BidiModule, Direction} from '@angular/cdk/bidi';
-import {OverlayContainer} from '@angular/cdk/overlay';
 import {BehaviorSubject} from 'rxjs';
-
 import {
   CdkPopoverEditColspan,
   CdkPopoverEditModule,
-  HoverContentState,
   FormValueContainer,
+  HoverContentState,
   PopoverEditClickOutBehavior,
 } from './index';
 
@@ -359,12 +358,12 @@ class CdkTableInCell extends BaseTestComponent {
   }
 }
 
-const testCases: ReadonlyArray<[Type<BaseTestComponent>, string]> = [
+const testCases = [
   [VanillaTableOutOfCell, 'Vanilla HTML table; edit defined outside of cell'],
   [VanillaTableInCell, 'Vanilla HTML table; edit defined within cell'],
   [CdkFlexTableInCell, 'Flex cdk-table; edit defined within cell'],
   [CdkTableInCell, 'Table cdk-table; edit defined within cell'],
-];
+] as const;
 
 describe('CDK Popover Edit', () => {
   for (const [componentClass, label] of testCases) {
@@ -381,7 +380,7 @@ describe('CDK Popover Edit', () => {
         inject([OverlayContainer], (oc: OverlayContainer) => {
           overlayContainer = oc;
         })();
-        fixture = TestBed.createComponent(componentClass);
+        fixture = TestBed.createComponent<BaseTestComponent>(componentClass);
         component = fixture.componentInstance;
         fixture.detectChanges();
         tick(10);

src/cdk/collections/array-data-source.ts

@@ -6,17 +6,17 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Observable, isObservable, of as observableOf} from 'rxjs';
+import {isObservable, Observable, of as observableOf} from 'rxjs';
 import {DataSource} from './data-source';
 
 
 /** DataSource wrapper for a native array. */
 export class ArrayDataSource<T> extends DataSource<T> {
-  constructor(private _data: T[] | ReadonlyArray<T> | Observable<T[] | ReadonlyArray<T>>) {
+  constructor(private _data: readonly T[] | Observable<readonly T[]>) {
     super();
   }
 
-  connect(): Observable<T[] | ReadonlyArray<T>> {
+  connect(): Observable<readonly T[]> {
     return isObservable(this._data) ? this._data : observableOf(this._data);
   }
 

src/cdk/collections/data-source.ts

@@ -18,7 +18,7 @@ export abstract class DataSource<T> {
    *     data source.
    * @returns Observable that emits a new value when the data changes.
    */
-  abstract connect(collectionViewer: CollectionViewer): Observable<T[] | ReadonlyArray<T>>;
+  abstract connect(collectionViewer: CollectionViewer): Observable<readonly T[]>;
 
   /**
    * Disconnects a collection viewer (such as a data-table) from this data source. Can be used

src/cdk/drag-drop/drop-list-ref.ts

@@ -6,24 +6,24 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ElementRef, NgZone} from '@angular/core';
 import {Direction} from '@angular/cdk/bidi';
 import {coerceElement} from '@angular/cdk/coercion';
-import {ViewportRuler} from '@angular/cdk/scrolling';
 import {_getShadowRoot} from '@angular/cdk/platform';
-import {Subject, Subscription, interval, animationFrameScheduler} from 'rxjs';
+import {ViewportRuler} from '@angular/cdk/scrolling';
+import {ElementRef, NgZone} from '@angular/core';
+import {animationFrameScheduler, interval, Subject, Subscription} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
-import {moveItemInArray} from './drag-utils';
-import {DragDropRegistry} from './drag-drop-registry';
-import {DragRefInternal as DragRef, Point} from './drag-ref';
 import {
-  isPointerNearClientRect,
   adjustClientRect,
   getMutableClientRect,
   isInsideClientRect,
+  isPointerNearClientRect,
 } from './client-rect';
-import {ParentPositionTracker} from './parent-position-tracker';
+import {DragDropRegistry} from './drag-drop-registry';
+import {DragRefInternal as DragRef, Point} from './drag-ref';
 import {DragCSSStyleDeclaration} from './drag-styling';
+import {moveItemInArray} from './drag-utils';
+import {ParentPositionTracker} from './parent-position-tracker';
 
 /**
  * Proximity, as a ratio to width/height, at which a
@@ -160,10 +160,10 @@ export class DropListRef<T = any> {
   private _previousSwap = {drag: null as DragRef | null, delta: 0, overlaps: false};
 
   /** Draggable items in the container. */
-  private _draggables: ReadonlyArray<DragRef>;
+  private _draggables: readonly DragRef[];
 
   /** Drop lists that are connected to the current one. */
-  private _siblings: ReadonlyArray<DropListRef> = [];
+  private _siblings: readonly DropListRef[] = [];
 
   /** Direction in which the list is oriented. */
   private _orientation: 'horizontal' | 'vertical' = 'vertical';
@@ -427,7 +427,7 @@ export class DropListRef<T = any> {
   }
 
   /** Gets the scrollable parents that are registered with this drop container. */
-  getScrollableParents(): ReadonlyArray<HTMLElement> {
+  getScrollableParents(): readonly HTMLElement[] {
     return this._scrollableElements;
   }
 

src/cdk/drag-drop/parent-position-tracker.ts

@@ -7,7 +7,7 @@
  */
 
 import {ViewportRuler} from '@angular/cdk/scrolling';
-import {getMutableClientRect, adjustClientRect} from './client-rect';
+import {adjustClientRect, getMutableClientRect} from './client-rect';
 
 /** Object holding the scroll position of something. */
 interface ScrollPosition {
@@ -31,7 +31,7 @@ export class ParentPositionTracker {
   }
 
   /** Caches the positions. Should be called at the beginning of a drag sequence. */
-  cache(elements: HTMLElement[] | ReadonlyArray<HTMLElement>) {
+  cache(elements: readonly HTMLElement[]) {
     this.clear();
     this.positions.set(this._document, {
       scrollPosition: this._viewportRuler.getViewportScrollPosition(),

src/cdk/schematics/update-tool/utils/decorators.ts

@@ -24,7 +24,7 @@ export interface NgDecorator {
  * (e.g. "@angular/core") from a list of decorators.
  */
 export function getAngularDecorators(
-    typeChecker: ts.TypeChecker, decorators: ReadonlyArray<ts.Decorator>): NgDecorator[] {
+    typeChecker: ts.TypeChecker, decorators: readonly ts.Decorator[]): readonly NgDecorator[] {
   return decorators.map(node => ({node, importData: getCallDecoratorImport(typeChecker, node)}))
       .filter(({importData}) => importData && importData.moduleName.startsWith('@angular/'))
       .map(

src/cdk/scrolling/virtual-for-of.ts

@@ -6,15 +6,16 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import {coerceNumberProperty, NumberInput} from '@angular/cdk/coercion';
 import {
   ArrayDataSource,
   CollectionViewer,
   DataSource,
-  ListRange,
   isDataSource,
+  ListRange,
   _RecycleViewRepeaterStrategy,
-  _VIEW_REPEATER_STRATEGY,
   _ViewRepeaterItemInsertArgs,
+  _VIEW_REPEATER_STRATEGY,
 } from '@angular/cdk/collections';
 import {
   Directive,
@@ -34,8 +35,7 @@ import {
   TrackByFunction,
   ViewContainerRef,
 } from '@angular/core';
-import {coerceNumberProperty, NumberInput} from '@angular/cdk/coercion';
-import {Observable, Subject, of as observableOf, isObservable} from 'rxjs';
+import {isObservable, Observable, of as observableOf, Subject} from 'rxjs';
 import {pairwise, shareReplay, startWith, switchMap, takeUntil} from 'rxjs/operators';
 import {CdkVirtualScrollRepeater} from './virtual-scroll-repeater';
 import {CdkVirtualScrollViewport} from './virtual-scroll-viewport';
@@ -151,7 +151,7 @@ export class CdkVirtualForOf<T> implements
   }
 
   /** Emits whenever the data in the current DataSource changes. */
-  dataStream: Observable<T[] | ReadonlyArray<T>> = this._dataSourceChanges
+  dataStream: Observable<readonly T[]> = this._dataSourceChanges
   .pipe(
       // Start off with null `DataSource`.
       startWith(null!),
@@ -168,7 +168,7 @@ export class CdkVirtualForOf<T> implements
   private _differ: IterableDiffer<T> | null = null;
 
   /** The most recent data emitted from the DataSource. */
-  private _data: T[] | ReadonlyArray<T>;
+  private _data: readonly T[];
 
   /** The currently rendered items. */
   private _renderedItems: T[];
@@ -294,7 +294,7 @@ export class CdkVirtualForOf<T> implements
 
   /** Swap out one `DataSource` for another. */
   private _changeDataSource(oldDs: DataSource<T> | null, newDs: DataSource<T> | null):
-      Observable<T[] | ReadonlyArray<T>> {
+      Observable<readonly T[]> {
 
     if (oldDs) {
       oldDs.disconnect(this);

src/cdk/scrolling/virtual-scroll-repeater.ts

@@ -6,13 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Observable} from 'rxjs';
 import {ListRange} from '@angular/cdk/collections';
+import {Observable} from 'rxjs';
 
 /**
  * An item to be repeated by the VirtualScrollViewport
  */
 export interface CdkVirtualScrollRepeater<T> {
-  dataStream: Observable<T[] | ReadonlyArray<T>>;
+  dataStream: Observable<readonly T[]>;
   measureRangeSize(range: ListRange, orientation: 'horizontal' | 'vertical'): number;
 }

src/cdk/table/table.ts

@@ -11,13 +11,13 @@ import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {
   CollectionViewer,
   DataSource,
-  _DisposeViewRepeaterStrategy,
   isDataSource,
-  _VIEW_REPEATER_STRATEGY,
+  _DisposeViewRepeaterStrategy,
   _ViewRepeater,
   _ViewRepeaterItemChange,
   _ViewRepeaterItemInsertArgs,
   _ViewRepeaterOperation,
+  _VIEW_REPEATER_STRATEGY,
 } from '@angular/cdk/collections';
 import {Platform} from '@angular/cdk/platform';
 import {DOCUMENT} from '@angular/common';
@@ -90,7 +90,7 @@ export interface RowOutlet {
  * @docs-private
  */
 type CdkTableDataSourceInput<T> =
-    DataSource<T>|Observable<ReadonlyArray<T>|T[]>|ReadonlyArray<T>|T[];
+    readonly T[]|DataSource<T>|Observable<readonly T[]>;
 
 /**
  * Provides a handle for the table to grab the view container's ng-container to insert data rows.
@@ -207,7 +207,7 @@ export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDes
   private _document: Document;
 
   /** Latest data provided by the data source. */
-  protected _data: T[]|ReadonlyArray<T>;
+  protected _data: readonly T[];
 
   /** Subject that emits when the component has been destroyed. */
   private _onDestroy = new Subject<void>();
@@ -875,7 +875,7 @@ export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDes
       return;
     }
 
-    let dataStream: Observable<T[]|ReadonlyArray<T>>|undefined;
+    let dataStream: Observable<readonly T[]>|undefined;
 
     if (isDataSource(this.dataSource)) {
       dataStream = this.dataSource.connect(this);

src/cdk/tree/tree.ts

@@ -198,7 +198,7 @@ export class CdkTree<T> implements AfterContentChecked, CollectionViewer, OnDest
 
   /** Set up a subscription for the data provided by the data source. */
   private _observeRenderChanges() {
-    let dataStream: Observable<T[] | ReadonlyArray<T>> | undefined;
+    let dataStream: Observable<readonly T[]> | undefined;
 
     if (isDataSource(this._dataSource)) {
       dataStream = this._dataSource.connect(this);
@@ -217,7 +217,7 @@ export class CdkTree<T> implements AfterContentChecked, CollectionViewer, OnDest
   }
 
   /** Check for changes made in the data and render each change (node added/removed/moved). */
-  renderNodeChanges(data: T[] | ReadonlyArray<T>, dataDiffer: IterableDiffer<T> = this._dataDiffer,
+  renderNodeChanges(data: readonly T[], dataDiffer: IterableDiffer<T> = this._dataDiffer,
                     viewContainer: ViewContainerRef = this._nodeOutlet.viewContainer,
                     parentData?: T) {
     const changes = dataDiffer.diff(data);

src/components-examples/material/chips/chips-input/chips-input-example.ts

@@ -19,7 +19,7 @@ export class ChipsInputExample {
   selectable = true;
   removable = true;
   addOnBlur = true;
-  readonly separatorKeysCodes: number[] = [ENTER, COMMA];
+  readonly separatorKeysCodes = [ENTER, COMMA];
   fruits: Fruit[] = [
     {name: 'Lemon'},
     {name: 'Lime'},

src/material-experimental/column-resize/column-resize.spec.ts

@@ -1,21 +1,20 @@
+import {ColumnSize} from '@angular/cdk-experimental/column-resize';
+import {BidiModule} from '@angular/cdk/bidi';
+import {DataSource} from '@angular/cdk/collections';
+import {ESCAPE} from '@angular/cdk/keycodes';
+import {OverlayContainer} from '@angular/cdk/overlay';
+import {dispatchKeyboardEvent} from '@angular/cdk/testing/private';
 import {
+  ChangeDetectionStrategy,
   Component,
   Directive,
   ElementRef,
-  Type,
   ViewChild,
-  ChangeDetectionStrategy,
 } from '@angular/core';
-import {ComponentFixture, TestBed, fakeAsync, flushMicrotasks, inject} from '@angular/core/testing';
-import {BidiModule} from '@angular/cdk/bidi';
-import {DataSource} from '@angular/cdk/collections';
-import {dispatchKeyboardEvent} from '@angular/cdk/testing/private';
-import {ESCAPE} from '@angular/cdk/keycodes';
-import {OverlayContainer} from '@angular/cdk/overlay';
+import {ComponentFixture, fakeAsync, flushMicrotasks, inject, TestBed} from '@angular/core/testing';
 import {MatTableModule} from '@angular/material/table';
 import {BehaviorSubject} from 'rxjs';
-
-import {ColumnSize} from '@angular/cdk-experimental/column-resize';
+import {AbstractMatColumnResize} from './column-resize-directives/common';
 import {
   MatColumnResize,
   MatColumnResizeFlex,
@@ -24,7 +23,6 @@ import {
   MatDefaultEnabledColumnResizeFlex,
   MatDefaultEnabledColumnResizeModule,
 } from './index';
-import {AbstractMatColumnResize} from './column-resize-directives/common';
 
 function getDefaultEnabledDirectiveStrings() {
   return {
@@ -322,7 +320,7 @@ const approximateMatcher = {
   })
 };
 
-const testCases: ReadonlyArray<[Type<object>, Type<BaseTestComponent>, string]> = [
+const testCases = [
   [MatColumnResizeModule, MatResizeTest, 'opt-in table-based mat-table'],
   [MatColumnResizeModule, MatResizeOnPushTest, 'inside OnPush component'],
   [MatColumnResizeModule, MatResizeFlexTest, 'opt-in flex-based mat-table'],
@@ -342,7 +340,7 @@ const testCases: ReadonlyArray<[Type<object>, Type<BaseTestComponent>, string]>
     MatDefaultEnabledColumnResizeModule, MatResizeDefaultFlexRtlTest,
     'default enabled rtl flex-based mat-table'
   ],
-];
+] as const;
 
 describe('Material Popover Edit', () => {
   for (const [resizeModule, componentClass, label] of testCases) {