Skip to content

Commit 79797a4

Browse files
build: set up post approval changes commit action (#24957)
This action will enforce that all pull requests receive an approval from at least one googler on the final commit for the pull request. Historically, we have allowed all post approval changes regardless of authorship. Moving forward, with this change, we will only allow known googlers to perform post approval changes. When a post approval change occurs by a non-googler, the action will automatically rerequest a review from the latest googler who provided an approval on the change.
1 parent 5f5f9d6 commit 79797a4

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

.github/workflows/dev-infra.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,21 @@ on:
44
pull_request_target:
55
types: [opened, synchronize, reopened]
66

7+
# Declare default permissions as read only.
8+
permissions: read-all
9+
710
jobs:
811
labels:
912
runs-on: ubuntu-latest
1013
steps:
11-
- uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2.0.0
12-
- uses: angular/dev-infra/github-actions/commit-message-based-labels@405b6f6e874e6e297d00e8100bd0b5d31e00ea96
14+
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
15+
- uses: angular/dev-infra/github-actions/commit-message-based-labels@2a04da0754b050fb17d6cfc4a4b4fa8b5575ea86
16+
with:
17+
angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
18+
post_approval_changes:
19+
runs-on: ubuntu-latest
20+
steps:
21+
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
22+
- uses: angular/dev-infra/github-actions/post-approval-changes@2a04da0754b050fb17d6cfc4a4b4fa8b5575ea86
1323
with:
1424
angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}

0 commit comments

Comments
 (0)