Skip to content

Commit 7aa4f01

Browse files
committed
docs(cdk/menu): resolve accessibility issues with examples
Fixes the following accessibility issues with the CDK menu examples: * Some menu triggers were incorrectly marked as `cdkMenuItem` which meant that they had `role="menuitem"` even though they weren't inside menus. * All the menu examples had `outline: none` which made it difficult to track focus when navigating with the keyboard.
1 parent 8eaa7a6 commit 7aa4f01

File tree

8 files changed

+5
-11
lines changed

8 files changed

+5
-11
lines changed

src/components-examples/cdk/menu/cdk-menu-context/cdk-menu-context-example.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
.example-menu-item {
1111
background-color: transparent;
1212
cursor: pointer;
13-
outline: none;
1413
border: none;
1514

1615
user-select: none;

src/components-examples/cdk/menu/cdk-menu-inline/cdk-menu-inline-example.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
.example-menu-item {
1111
background-color: transparent;
1212
cursor: pointer;
13-
outline: none;
1413
border: none;
1514

1615
user-select: none;

src/components-examples/cdk/menu/cdk-menu-menubar/cdk-menu-menubar-example.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
.example-menu-bar-item {
22
cursor: pointer;
3-
outline: none;
43
border: none;
54

65
user-select: none;
@@ -35,7 +34,6 @@
3534
.example-menu .example-menu-item {
3635
background-color: transparent;
3736
cursor: pointer;
38-
outline: none;
3937
border: none;
4038

4139
user-select: none;

src/components-examples/cdk/menu/cdk-menu-standalone-menu/cdk-menu-standalone-menu-example.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
.example-standalone-item {
1212
background-color: transparent;
1313
cursor: pointer;
14-
outline: none;
1514
border: none;
1615

1716
user-select: none;

src/components-examples/cdk/menu/cdk-menu-standalone-menu/cdk-menu-standalone-menu-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<button cdkMenuItem [cdkMenuTriggerFor]="menu" class="example-standalone-item">Click me!</button>
1+
<button [cdkMenuTriggerFor]="menu" class="example-standalone-item">Click me!</button>
22

33
<ng-template #menu>
44
<div class="example-menu" cdkMenu>

src/components-examples/cdk/menu/cdk-menu-standalone-stateful-menu/cdk-menu-standalone-stateful-menu-example.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ hr {
2020
.example-standalone-item {
2121
background-color: transparent;
2222
cursor: pointer;
23-
outline: none;
2423
border: none;
2524

2625
user-select: none;

src/components-examples/cdk/menu/cdk-menu-standalone-stateful-menu/cdk-menu-standalone-stateful-menu-example.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<button cdkMenuItem [cdkMenuTriggerFor]="menu" class="example-standalone-item">Click me!</button>
1+
<button [cdkMenuTriggerFor]="menu" class="example-standalone-item">Click me!</button>
22

33
<ng-template #menu>
44
<div class="example-menu" cdkMenu>

src/dev-app/cdk-menu/cdk-menu-demo.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,9 @@ <h4>Custom Context Menu Position (Centered on Cursor)</h4>
160160

161161
<div class="example-menu-container">
162162
<h3>Radio items</h3>
163-
<button cdkMenuItem [cdkMenuTriggerFor]="sizeMenu">Size menu (items directly in menu)</button>
164-
<button cdkMenuItem [cdkMenuTriggerFor]="colorMenu">Color menu (items in menu group)</button>
165-
<button cdkMenuItem [cdkMenuTriggerFor]="sizeAndColorMenu">Size & Color menu (items in directly in menu & in menu group)</button>
163+
<button [cdkMenuTriggerFor]="sizeMenu">Size menu (items directly in menu)</button>
164+
<button [cdkMenuTriggerFor]="colorMenu">Color menu (items in menu group)</button>
165+
<button [cdkMenuTriggerFor]="sizeAndColorMenu">Size & Color menu (items in directly in menu & in menu group)</button>
166166

167167
<ng-template #sizeMenu>
168168
<div class="example-menu" cdkMenu>

0 commit comments

Comments
 (0)