Skip to content

Commit 85f95f0

Browse files
mmalerbajelbourn
authored andcommitted
build: make cdk-experimental and material-experimental build settings (#15843)
consistent with cdk and material.
1 parent 7529d86 commit 85f95f0

File tree

6 files changed

+17
-63
lines changed

6 files changed

+17
-63
lines changed
Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,17 @@
1-
// TypeScript config file that is used to compile the experimental package into ES2015.
1+
// TypeScript config file that is used to compile the cdk-experimental's ES2015 package through
2+
// Gulp. As the long term goal is to switch to Bazel, and we already want to run tests with Bazel,
3+
// we need to ensure the TypeScript build options are the same for Gulp and Bazel. We achieve this
4+
// by extending the generic Bazel build tsconfig which will be used for each entry-point.
25
{
6+
"extends": "../bazel-tsconfig-build.json",
37
"compilerOptions": {
48
"baseUrl": ".",
5-
"declaration": true,
6-
"stripInternal": false,
7-
"experimentalDecorators": true,
8-
"noUnusedParameters": true,
9-
"noUnusedLocals": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"noImplicitAny": true,
13-
"noImplicitThis": true,
14-
"importHelpers": true,
15-
"newLine": "lf",
16-
"module": "es2015",
17-
"moduleResolution": "node",
189
"outDir": "../../dist/packages/cdk-experimental",
1910
"rootDir": ".",
2011
"rootDirs": [
2112
".",
2213
"../../dist/packages/cdk-experimental"
2314
],
24-
"sourceMap": true,
25-
"inlineSources": true,
26-
"target": "es2015",
27-
"lib": ["es2015", "dom"],
28-
"skipLibCheck": true,
29-
"types": ["jasmine", "tslib"],
3015
"paths": {
3116
"@angular/cdk/*": ["../../dist/packages/cdk/*"],
3217
"@angular/cdk-experimental/*": ["../../dist/packages/cdk-experimental/*"]
@@ -43,8 +28,5 @@
4328
"flatModuleId": "@angular/cdk-experimental",
4429
"skipTemplateCodegen": true,
4530
"fullTemplateTypeCheck": true
46-
},
47-
"bazelOptions": {
48-
"suppressTsconfigOverrideWarnings": true
4931
}
5032
}

src/material-experimental/mdc-checkbox/checkbox.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,8 @@ import {
2727
ViewEncapsulation
2828
} from '@angular/core';
2929
import {ControlValueAccessor, NG_VALUE_ACCESSOR} from '@angular/forms';
30-
import {
31-
MAT_CHECKBOX_CLICK_ACTION,
32-
MatCheckboxClickAction,
33-
RippleRenderer,
34-
RippleTarget,
35-
ThemePalette
36-
} from '@angular/material';
30+
import {MAT_CHECKBOX_CLICK_ACTION, MatCheckboxClickAction} from '@angular/material/checkbox';
31+
import {RippleRenderer, RippleTarget, ThemePalette} from '@angular/material/core';
3732
import {ANIMATION_MODULE_TYPE} from '@angular/platform-browser/animations';
3833
import {MDCCheckboxAdapter, MDCCheckboxFoundation} from '@material/checkbox';
3934

src/material-experimental/mdc-checkbox/public-api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {_MatCheckboxRequiredValidatorModule} from '@angular/material';
9+
import {_MatCheckboxRequiredValidatorModule} from '@angular/material/checkbox';
1010

1111
export * from './checkbox';
1212
export * from './module';
@@ -27,4 +27,4 @@ export {
2727
* @breaking-change 9.0.0
2828
*/
2929
TransitionCheckState,
30-
} from '@angular/material';
30+
} from '@angular/material/checkbox';
Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,21 @@
1-
// TypeScript config file that is used to compile the experimental package into ES2015.
1+
// TypeScript config file that is used to compile the material-experimental's ES2015 package through
2+
// Gulp. As the long term goal is to switch to Bazel, and we already want to run tests with Bazel,
3+
// we need to ensure the TypeScript build options are the same for Gulp and Bazel. We achieve this
4+
// by extending the generic Bazel build tsconfig which will be used for each entry-point.
25
{
6+
"extends": "../bazel-tsconfig-build.json",
37
"compilerOptions": {
48
"baseUrl": ".",
5-
"declaration": true,
6-
"stripInternal": false,
7-
"experimentalDecorators": true,
8-
"noUnusedParameters": true,
9-
"noUnusedLocals": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"noImplicitAny": true,
13-
"noImplicitThis": true,
14-
"importHelpers": true,
15-
"newLine": "lf",
16-
"module": "es2015",
17-
"moduleResolution": "node",
189
"outDir": "../../dist/packages/material-experimental",
1910
"rootDir": ".",
2011
"rootDirs": [
2112
".",
2213
"../../dist/packages/material-experimental"
2314
],
24-
"sourceMap": true,
25-
"inlineSources": true,
26-
"target": "es2015",
27-
"lib": ["es2015", "dom"],
28-
"skipLibCheck": true,
29-
"types": ["jasmine", "tslib"],
3015
"paths": {
31-
"@angular/material/*": ["../../dist/packages/material/*"],
32-
"@angular/material": ["../../dist/packages/material"],
3316
"@angular/cdk/*": ["../../dist/packages/cdk/*"],
34-
"@angular/cdk": ["../../dist/packages/cdk"],
3517
"@angular/cdk-experimental/*": ["../../dist/packages/cdk-experimental/*"],
36-
"@angular/cdk-experimental": ["../../dist/packages/cdk-experimental"],
18+
"@angular/material/*": ["../../dist/packages/material/*"],
3719
"@angular/material-experimental/*": ["../../dist/packages/material-experimental/*"]
3820
}
3921
},
@@ -45,11 +27,8 @@
4527
"annotateForClosureCompiler": true,
4628
"strictMetadataEmit": true,
4729
"flatModuleOutFile": "index.js",
48-
"flatModuleId": "@angular/material-experimental",
30+
"flatModuleId": "@angular/cdk-experimental",
4931
"skipTemplateCodegen": true,
5032
"fullTemplateTypeCheck": true
51-
},
52-
"bazelOptions": {
53-
"suppressTsconfigOverrideWarnings": true
5433
}
5534
}

src/material-experimental/tsconfig.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
"baseUrl": ".",
77
"paths": {
88
"@angular/cdk/*": ["../cdk/*"],
9-
"@angular/cdk": ["../cdk"],
109
"@angular/material/*": ["../lib/*"],
11-
"@angular/material": ["../lib/public-api.ts"],
1210
"@angular/cdk-experimental/*": ["../cdk-experimental/*"],
1311
"@material/*": ["../../node_modules/@material/*/index.d.ts"]
1412
}

tools/gulp/packages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export const cdkPackage = new BuildPackage('cdk');
55
export const materialPackage = new BuildPackage('material', [cdkPackage]);
66
export const cdkExperimentalPackage = new BuildPackage('cdk-experimental', [cdkPackage]);
77
export const materialExperimentalPackage = new BuildPackage('material-experimental',
8-
[materialPackage]);
8+
[cdkPackage, cdkExperimentalPackage, materialPackage]);
99
export const momentAdapterPackage = new BuildPackage('material-moment-adapter', [materialPackage]);
1010
export const examplesPackage = new BuildPackage('material-examples', [
1111
cdkPackage,

0 commit comments

Comments
 (0)