build: switch tabs e2e to MDC

Removes the e2e app entry for the legacy tabs and renames the MDC tabs.

Author: crisbeto

.github/CODEOWNERS

@@ -249,7 +249,6 @@
 /src/e2e-app/expansion/**                                   @andrewseguin
 /src/e2e-app/grid-list/**                                   @andrewseguin
 /src/e2e-app/icon/**                                        @andrewseguin
-/src/e2e-app/legacy-tabs/**                                 @andrewseguin
 /src/e2e-app/list/**                                        @andrewseguin
 /src/e2e-app/button/**                                      @andrewseguin
 /src/e2e-app/mdc-card/**                                    @mmalerba
@@ -263,7 +262,7 @@
 /src/e2e-app/slide-toggle/**                                @crisbeto
 /src/e2e-app/mdc-slider/**                                  @andrewseguin
 /src/e2e-app/mdc-table/**                                   @andrewseguin
-/src/e2e-app/mdc-tabs/**                                    @crisbeto
+/src/e2e-app/tabs/**                                        @crisbeto
 /src/e2e-app/select/**                                      @crisbeto
 /src/e2e-app/sidenav/**                                     @mmalerba
 /src/e2e-app/stepper/**                                     @mmalerba

src/e2e-app/BUILD.bazel

@@ -52,7 +52,6 @@ ng_module(
         "//src/material/input",
         "//src/material/legacy-form-field",
         "//src/material/legacy-list",
-        "//src/material/legacy-tabs",
         "//src/material/menu",
         "//src/material/progress-bar",
         "//src/material/progress-spinner",

src/e2e-app/e2e-app/e2e-app-layout.ts

@@ -36,6 +36,5 @@ export class E2eAppLayout {
     {path: 'toolbar', title: 'Toolbar'},
     {path: 'virtual-scroll', title: 'Virtual Scroll'},
     {path: 'mdc-table', title: 'MDC Table'},
-    {path: 'mdc-tabs', title: 'MDC Tabs'},
   ];
 }

src/e2e-app/legacy-tabs/legacy-tabs-e2e-module.ts

@@ -11,7 +11,6 @@ import {E2eAppModule} from './e2e-app/e2e-app-module';
 import {ExpansionE2eModule} from './expansion/expansion-e2e-module';
 import {GridListE2eModule} from './grid-list/grid-list-e2e-module';
 import {IconE2eModule} from './icon/icon-e2e-module';
-import {LegacyTabsE2eModule} from './legacy-tabs/legacy-tabs-e2e-module';
 import {ListE2eModule} from './list/list-e2e-module';
 import {ButtonE2eModule} from './button/button-e2e-module';
 import {CheckboxE2eModule} from './checkbox/checkbox-e2e-module';
@@ -23,7 +22,7 @@ import {RadioE2eModule} from './radio/radio-e2e-module';
 import {SlideToggleE2eModule} from './slide-toggle/slide-toggle-e2e-module';
 import {MdcSliderE2eModule} from './mdc-slider/mdc-slider-e2e-module';
 import {MdcTableE2eModule} from './mdc-table/mdc-table-e2e-module';
-import {MdcTabsE2eModule} from './mdc-tabs/mdc-tabs-e2e-module';
+import {TabsE2eModule} from './tabs/tabs-e2e-module';
 import {E2E_APP_ROUTES} from './routes';
 import {SidenavE2eModule} from './sidenav/sidenav-e2e-module';
 import {StepperE2eModule} from './stepper/stepper-e2e-module';
@@ -48,7 +47,6 @@ const enableAnimations = window.location.search.includes('animations=true');
     ExpansionE2eModule,
     GridListE2eModule,
     IconE2eModule,
-    LegacyTabsE2eModule,
     ListE2eModule,
     ButtonE2eModule,
     CheckboxE2eModule,
@@ -60,7 +58,7 @@ const enableAnimations = window.location.search.includes('animations=true');
     MdcSliderE2eModule,
     SlideToggleE2eModule,
     MdcTableE2eModule,
-    MdcTabsE2eModule,
+    TabsE2eModule,
     SidenavE2eModule,
     StepperE2eModule,
     ToolbarE2eModule,

src/e2e-app/legacy-tabs/legacy-tabs-e2e.ts

@@ -7,7 +7,6 @@ import {Home} from './e2e-app/e2e-app-layout';
 import {ExpansionE2e} from './expansion/expansion-e2e';
 import {GridListE2E} from './grid-list/grid-list-e2e';
 import {IconE2E} from './icon/icon-e2e';
-import {LegacyTabsE2e} from './legacy-tabs/legacy-tabs-e2e';
 import {ListE2e} from './list/list-e2e';
 import {ButtonE2e} from './button/button-e2e';
 import {CheckboxE2e} from './checkbox/checkbox-e2e';
@@ -19,7 +18,7 @@ import {ProgressSpinnerE2e} from './progress-spinner/progress-spinner-e2e';
 import {RadioE2e} from './radio/radio-e2e';
 import {MdcSliderE2e} from './mdc-slider/mdc-slider-e2e';
 import {MdcTableE2e} from './mdc-table/mdc-table-e2e';
-import {MdcTabsE2e} from './mdc-tabs/mdc-tabs-e2e';
+import {TabsE2e} from './tabs/tabs-e2e';
 import {SelectE2e} from './select/select-e2e';
 import {SidenavE2E} from './sidenav/sidenav-e2e';
 import {StepperE2e} from './stepper/stepper-e2e';
@@ -43,13 +42,12 @@ export const E2E_APP_ROUTES: Routes = [
   {path: 'progress-spinner', component: ProgressSpinnerE2e},
   {path: 'radio', component: RadioE2e},
   {path: 'slide-toggle', component: SlideToggleE2e},
-  {path: 'legacy-tabs', component: LegacyTabsE2e},
+  {path: 'tabs', component: TabsE2e},
   {path: 'list', component: ListE2e},
   {path: 'button', component: ButtonE2e},
   {path: 'dialog', component: DialogE2E},
   {path: 'mdc-slider', component: MdcSliderE2e},
   {path: 'mdc-table', component: MdcTableE2e},
-  {path: 'mdc-tabs', component: MdcTabsE2e},
   {path: 'select', component: SelectE2e},
   {path: 'sidenav', component: SidenavE2E},
   {path: 'stepper', component: StepperE2e},

src/e2e-app/main-module.ts

@@ -10,10 +10,10 @@ import {NgModule} from '@angular/core';
 import {MatFormFieldModule} from '@angular/material/form-field';
 import {MatInputModule} from '@angular/material/input';
 import {MatTabsModule} from '@angular/material/tabs';
-import {MdcTabsE2e} from './mdc-tabs-e2e';
+import {TabsE2e} from './tabs-e2e';
 
 @NgModule({
   imports: [MatTabsModule, MatFormFieldModule, MatInputModule],
-  declarations: [MdcTabsE2e],
+  declarations: [TabsE2e],
 })
-export class MdcTabsE2eModule {}
+export class TabsE2eModule {}

src/e2e-app/mdc-tabs/mdc-tabs-e2e.html

@@ -9,7 +9,7 @@
 import {Component} from '@angular/core';
 
 @Component({
-  selector: 'mdc-tabs-e2e',
-  templateUrl: 'mdc-tabs-e2e.html',
+  selector: 'tabs-e2e',
+  templateUrl: 'tabs-e2e.html',
 })
-export class MdcTabsE2e {}
+export class TabsE2e {}

src/e2e-app/routes.ts

@@ -1,7 +1,5 @@
-load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
 load(
     "//tools:defaults.bzl",
-    "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
@@ -85,10 +83,7 @@ sass_binary(
 
 ng_test_library(
     name = "unit_test_sources",
-    srcs = glob(
-        ["**/*.spec.ts"],
-        exclude = ["**/*.e2e.spec.ts"],
-    ),
+    srcs = glob(["**/*.spec.ts"]),
     deps = [
         ":legacy-tabs",
         "//src/cdk/bidi",
@@ -109,22 +104,6 @@ ng_web_test_suite(
     deps = [":unit_test_sources"],
 )
 
-ng_e2e_test_library(
-    name = "e2e_test_sources",
-    srcs = glob(["**/*.e2e.spec.ts"]),
-    deps = [
-        "//src/cdk/testing/private/e2e",
-    ],
-)
-
-e2e_test_suite(
-    name = "e2e_tests",
-    deps = [
-        ":e2e_test_sources",
-        "//src/cdk/testing/private/e2e",
-    ],
-)
-
 filegroup(
     name = "source-files",
     srcs = glob(["**/*.ts"]),

src/e2e-app/mdc-tabs/mdc-tabs-e2e-module.ts renamed to src/e2e-app/tabs/tabs-e2e-module.ts

@@ -1,13 +1,13 @@
 import {browser, by, element, ElementArrayFinder, Key, ExpectedConditions} from 'protractor';
 import {pressKeys} from '../../cdk/testing/private/e2e';
 
-describe('MDC-based tabs', () => {
+describe('tabs', () => {
   describe('basic behavior', () => {
     let tabLabels: ElementArrayFinder;
     let tabBodies: ElementArrayFinder;
 
     beforeEach(async () => {
-      await browser.get('/mdc-tabs');
+      await browser.get('/tabs');
       tabLabels = element.all(by.css('.mat-mdc-tab'));
       tabBodies = element.all(by.css('mat-tab-body'));
     });