Skip to content

Commit 920102a

Browse files
committed
refactor: disable strict metadata emit for legacy build output
Workaround for angular/angular#33451. This makes sense at the current time since the Bazel output does *never* work with strict metadata emit... and considering that with Ivy there is no metadata anyway, it could be disabled in the meanwhile.
1 parent 2ab27c6 commit 920102a

File tree

179 files changed

+23
-200
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

179 files changed

+23
-200
lines changed

src/cdk-experimental/dialog/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk-experimental/dialog",
1211
"skipTemplateCodegen": true,

src/cdk-experimental/popover-edit/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk-experimental/popover-edit",
1211
"skipTemplateCodegen": true,

src/cdk-experimental/scrolling/auto-size-virtual-scroll.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,6 @@ export function _autoSizeVirtualScrollStrategyFactory(autoSizeDir: CdkAutoSizeVi
427427
}
428428

429429

430-
/** @dynamic Needed for "ngAcceptInputType" members. */
431430
/** A virtual scroll strategy that supports unknown or dynamic size items. */
432431
@Directive({
433432
selector: 'cdk-virtual-scroll-viewport[autosize]',

src/cdk-experimental/scrolling/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk-experimental/scrolling",
1110
"skipTemplateCodegen": true,

src/cdk-experimental/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"angularCompilerOptions": {
2525
"enableIvy": false,
2626
"annotateForClosureCompiler": true,
27-
"strictMetadataEmit": true,
2827
"flatModuleOutFile": "index.js",
2928
"flatModuleId": "@angular/cdk-experimental",
3029
"skipTemplateCodegen": true,

src/cdk-experimental/tsconfig-tests.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
}
1515
},
1616
"angularCompilerOptions": {
17-
"strictMetadataEmit": true,
1817
"skipTemplateCodegen": true,
1918
"emitDecoratorMetadata": true,
2019

src/cdk/a11y/focus-trap/focus-trap.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ export class FocusTrapFactory {
356356
}
357357
}
358358

359-
/** @dynamic Needed for "ngAcceptInputType" members. */
360359
/** Directive for trapping focus within a region. */
361360
@Directive({
362361
selector: '[cdkTrapFocus]',

src/cdk/a11y/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/a11y",
1110
"skipTemplateCodegen": true,

src/cdk/accordion/accordion-item.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {Subscription} from 'rxjs';
2424
/** Used to generate unique ID for each accordion item. */
2525
let nextId = 0;
2626

27-
/** @dynamic Needed for "ngAcceptInputType" members. */
2827
/**
2928
* An basic directive expected to be extended and decorated as a component. Sets up all
3029
* events and attributes needed to be managed by a CdkAccordion parent.

src/cdk/accordion/accordion.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {Subject} from 'rxjs';
1313
/** Used to generate unique ID for each accordion. */
1414
let nextId = 0;
1515

16-
/** @dynamic Needed for "ngAcceptInputType" members. */
1716
/**
1817
* Directive whose purpose is to manage the expanded state of CdkAccordionItem children.
1918
*/

src/cdk/accordion/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/accordion",
1110
"skipTemplateCodegen": true,

src/cdk/bidi/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/bidi",
1110
"skipTemplateCodegen": true,

src/cdk/clipboard/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/clipboard",
1211
"skipTemplateCodegen": true,

src/cdk/coercion/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/coercion",
1110
"skipTemplateCodegen": true,

src/cdk/collections/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/collections",
1110
"skipTemplateCodegen": true,

src/cdk/drag-drop/directives/drag-handle.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {Subject} from 'rxjs';
1212
import {CDK_DRAG_PARENT} from '../drag-parent';
1313
import {toggleNativeDragInteractions} from '../drag-styling';
1414

15-
/** @dynamic Needed for "ngAcceptInputType" members. */
1615
/** Handle that can be used to drag and CdkDrag instance. */
1716
@Directive({
1817
selector: '[cdkDragHandle]',

src/cdk/drag-drop/directives/drag.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ export function CDK_DRAG_CONFIG_FACTORY(): DragRefConfig {
6767
return {dragStartThreshold: 5, pointerDirectionChangeThreshold: 5};
6868
}
6969

70-
/** @dynamic Needed for "ngAcceptInputType" members. */
7170
/** Element that can be moved inside a CdkDropList container. */
7271
@Directive({
7372
selector: '[cdkDrag]',

src/cdk/drag-drop/directives/drop-list-group.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import {Directive, OnDestroy, Input} from '@angular/core';
1010
import {coerceBooleanProperty} from '@angular/cdk/coercion';
1111

12-
/** @dynamic Needed for "ngAcceptInputType" members. */
1312
/**
1413
* Declaratively connects sibling `cdkDropList` instances together. All of the `cdkDropList`
1514
* elements that are placed inside a `cdkDropListGroup` will be connected to each other

src/cdk/drag-drop/directives/drop-list.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ let _uniqueIdCounter = 0;
4141
*/
4242
export interface CdkDropListInternal extends CdkDropList {}
4343

44-
/** @dynamic Needed for "ngAcceptInputType" members. */
4544
/** Container that wraps a set of draggable items. */
4645
@Directive({
4746
selector: '[cdkDropList], cdk-drop-list',

src/cdk/drag-drop/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/drag-drop",
1110
"skipTemplateCodegen": true,

src/cdk/keycodes/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/keycodes",
1110
"skipTemplateCodegen": true,

src/cdk/layout/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/layout",
1110
"skipTemplateCodegen": true,

src/cdk/observers/observe-content.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class ContentObserver implements OnDestroy {
124124
}
125125
}
126126

127-
/** @dynamic Needed for "ngAcceptInputType" members. */
127+
128128
/**
129129
* Directive that triggers a callback whenever the content of
130130
* its associated element has changed.

src/cdk/observers/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/observers",
1110
"skipTemplateCodegen": true,

src/cdk/overlay/overlay-directives.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class CdkOverlayOrigin {
9393
public elementRef: ElementRef) { }
9494
}
9595

96-
/** @dynamic Needed for "ngAcceptInputType" members. */
96+
9797
/**
9898
* Directive to facilitate declarative creation of an
9999
* Overlay using a FlexibleConnectedPositionStrategy.

src/cdk/overlay/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/overlay",
1110
"skipTemplateCodegen": true,

src/cdk/platform/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/platform",
1110
"skipTemplateCodegen": true,

src/cdk/portal/portal-directives.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class TemplatePortalDirective extends CdkPortal {}
5555
*/
5656
export type CdkPortalOutletAttachedRef = ComponentRef<any> | EmbeddedViewRef<any> | null;
5757

58-
/** @dynamic Needed for "ngAcceptInputType" members. */
58+
5959
/**
6060
* Directive version of a PortalOutlet. Because the directive *is* a PortalOutlet, portals can be
6161
* directly attached to it, enabling declarative use.

src/cdk/portal/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/portal",
1110
"skipTemplateCodegen": true,

src/cdk/scrolling/fixed-size-virtual-scroll.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export function _fixedSizeVirtualScrollStrategyFactory(fixedSizeDir: CdkFixedSiz
162162
return fixedSizeDir._scrollStrategy;
163163
}
164164

165-
/** @dynamic Needed for "ngAcceptInputType" members. */
165+
166166
/** A virtual scroll strategy that supports fixed-size items. */
167167
@Directive({
168168
selector: 'cdk-virtual-scroll-viewport[itemSize]',

src/cdk/scrolling/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/scrolling",
1211
"skipTemplateCodegen": true,

src/cdk/stepper/stepper.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ export interface StepperOptions {
104104
displayDefaultIndicatorType?: boolean;
105105
}
106106

107-
/** @dynamic Needed for "ngAcceptInputType" members. */
108107
@Component({
109108
moduleId: module.id,
110109
selector: 'cdk-step',
@@ -239,7 +238,6 @@ export class CdkStep implements OnChanges {
239238
static ngAcceptInputType_completed: boolean | string;
240239
}
241240

242-
/** @dynamic Needed for "ngAcceptInputType" members. */
243241
@Directive({
244242
selector: '[cdkStepper]',
245243
exportAs: 'cdkStepper',

src/cdk/stepper/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/stepper",
1211
"skipTemplateCodegen": true,

src/cdk/table/cell.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class CdkColumnDefBase {}
4949
const _CdkColumnDefBase: CanStickCtor&typeof CdkColumnDefBase =
5050
mixinHasStickyInput(CdkColumnDefBase);
5151

52-
/** @dynamic Needed for "ngAcceptInputType" members. */
5352
/**
5453
* Column definition for the CDK table.
5554
* Defines a set of cells available for a table column.

src/cdk/table/row.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ class CdkHeaderRowDefBase extends BaseRowDef {}
8181
const _CdkHeaderRowDefBase: CanStickCtor&typeof CdkHeaderRowDefBase =
8282
mixinHasStickyInput(CdkHeaderRowDefBase);
8383

84-
/** @dynamic Needed for "ngAcceptInputType" members. */
8584
/**
8685
* Header row definition for the CDK table.
8786
* Captures the header row's template and other header properties such as the columns to display.
@@ -110,7 +109,6 @@ class CdkFooterRowDefBase extends BaseRowDef {}
110109
const _CdkFooterRowDefBase: CanStickCtor&typeof CdkFooterRowDefBase =
111110
mixinHasStickyInput(CdkFooterRowDefBase);
112111

113-
/** @dynamic Needed for "ngAcceptInputType" members. */
114112
/**
115113
* Footer row definition for the CDK table.
116114
* Captures the footer row's template and other footer properties such as the columns to display.

src/cdk/table/table.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ export interface RenderRow<T> {
145145
rowDef: CdkRowDef<T>;
146146
}
147147

148-
/** @dynamic Needed for "ngAcceptInputType" members. */
149148
/**
150149
* A data table that can render a header row, data rows, and a footer row.
151150
* Uses the dataSource input to determine the data to be rendered. The data can be provided either

src/cdk/table/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/table",
1211
"skipTemplateCodegen": true,

src/cdk/testing/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/testing",
1211
"skipTemplateCodegen": true,

src/cdk/text-field/autosize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {Platform} from '@angular/cdk/platform';
2020
import {auditTime, takeUntil} from 'rxjs/operators';
2121
import {fromEvent, Subject} from 'rxjs';
2222

23-
/** @dynamic Needed for "ngAcceptInputType" members. */
23+
2424
/** Directive to automatically resize a textarea to fit its content. */
2525
@Directive({
2626
selector: 'textarea[cdkTextareaAutosize]',

src/cdk/text-field/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
],
66
"angularCompilerOptions": {
77
"annotateForClosureCompiler": true,
8-
"strictMetadataEmit": true,
98
"flatModuleOutFile": "index.js",
109
"flatModuleId": "@angular/cdk/text-field",
1110
"skipTemplateCodegen": true,

src/cdk/tree/padding.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {CdkTree, CdkTreeNode} from './tree';
1616
/** Regex used to split a string on its CSS units. */
1717
const cssUnitPattern = /([A-Za-z%]+)$/;
1818

19-
/** @dynamic Needed for "ngAcceptInputType" members. */
2019
/**
2120
* Indent for the children tree dataNodes.
2221
* This directive will add left-padding to the node to show hierarchy.

src/cdk/tree/toggle.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {Directive, HostListener, Input} from '@angular/core';
1111

1212
import {CdkTree, CdkTreeNode} from './tree';
1313

14-
/** @dynamic Needed for "ngAcceptInputType" members. */
1514
/**
1615
* Node toggle to expand/collapse the node.
1716
*/

src/cdk/tree/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
],
77
"angularCompilerOptions": {
88
"annotateForClosureCompiler": true,
9-
"strictMetadataEmit": true,
109
"flatModuleOutFile": "index.js",
1110
"flatModuleId": "@angular/cdk/tree",
1211
"skipTemplateCodegen": true

src/cdk/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"angularCompilerOptions": {
2424
"enableIvy": false,
2525
"annotateForClosureCompiler": true,
26-
"strictMetadataEmit": true,
2726
"flatModuleOutFile": "index.js",
2827
"flatModuleId": "@angular/cdk",
2928
"skipTemplateCodegen": true,

src/cdk/tsconfig-tests.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"typings.d.ts"
1919
],
2020
"angularCompilerOptions": {
21-
"strictMetadataEmit": true,
2221
"skipTemplateCodegen": true,
2322
"emitDecoratorMetadata": true,
2423
"fullTemplateTypeCheck": true,

src/google-maps/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"angularCompilerOptions": {
2121
"enableIvy": false,
2222
"annotateForClosureCompiler": true,
23-
"strictMetadataEmit": true,
2423
"flatModuleOutFile": "index.js",
2524
"flatModuleId": "@angular/google-maps",
2625
"skipTemplateCodegen": true,

src/google-maps/tsconfig-tests.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
]
1313
},
1414
"angularCompilerOptions": {
15-
"strictMetadataEmit": true,
1615
"skipTemplateCodegen": true,
1716
"emitDecoratorMetadata": true,
1817
"fullTemplateTypeCheck": true,

0 commit comments

Comments
 (0)