Skip to content

Commit 9668468

Browse files
Victoria WeiVictoria Wei
authored andcommitted
Saved space by combining conditionals within for loop in both files
1 parent 284a8fe commit 9668468

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

src/demo-app/tree/dynamic-tree-demo/dynamic-database.ts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,22 +100,16 @@ export class DynamicDataSource {
100100
}
101101
node.isLoading = true;
102102

103-
let count = 0;
104-
105103
setTimeout(() => {
106104
if (expand) {
107105
const nodes = children.map(name =>
108106
new DynamicFlatNode(name, node.level + 1, this.database.isExpandable(name)));
109107
this.data.splice(index + 1, 0, ...nodes);
110108
} else {
111-
for (let i = index + 1; i < this.data.length; i++) {
112-
if (this.data[i].level > node.level) {
113-
count++;
114-
} else {
115-
break;
116-
}
117-
}
118-
this.data.splice(index + 1, count);
109+
let count = 0;
110+
for (let i = index + 1; i < this.data.length
111+
&& this.data[i].level > node.level; i++, count++) {}
112+
this.data.splice(index + 1, count);
119113
}
120114

121115
// notify the change

src/material-examples/tree-dynamic/tree-dynamic-example.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,21 +94,15 @@ export class DynamicDataSource {
9494

9595
node.isLoading = true;
9696

97-
let count = 0;
98-
9997
setTimeout(() => {
10098
if (expand) {
10199
const nodes = children.map(name =>
102100
new DynamicFlatNode(name, node.level + 1, this.database.isExpandable(name)));
103101
this.data.splice(index + 1, 0, ...nodes);
104102
} else {
105-
for (let i = index + 1; i < this.data.length; i++) {
106-
if (this.data[i].level > node.level) {
107-
count++;
108-
} else {
109-
break;
110-
}
111-
}
103+
let count = 0;
104+
for (let i = index + 1; i < this.data.length
105+
&& this.data[i].level > node.level; i++, count++) {}
112106
this.data.splice(index + 1, count);
113107
}
114108

0 commit comments

Comments
 (0)