fix(cdk/testing): TestElement sendKeys method should throw if no keys have been specified

Previously, calling `sendKeys` without any keys resulted in a runtime
exception `Cannot read X of undefined` error being thrown. This is because
the first element of the passed arguments to `sendKeys` has been considered
always truthy. This assumption is wrong since arbitrary amount of arguments
can be passed due to the spread parameter.

To ensure consistent and reasonable behavior of this function, we fix
the runtime exception mentioned above, but throw if no keys have been
determined (not necessarily only if the arguments length is zero).

Author: devversion

src/cdk/testing/protractor/protractor-element.ts

@@ -6,7 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ElementDimensions, ModifierKeys, TestElement, TestKey} from '@angular/cdk/testing';
+import {
+  ElementDimensions,
+  getNoKeysSpecifiedError,
+  ModifierKeys,
+  TestElement,
+  TestKey
+} from '@angular/cdk/testing';
 import {browser, ElementFinder, Key} from 'protractor';
 
 /** Maps the `TestKey` constants to Protractor's `Key` constants. */
@@ -111,7 +117,7 @@ export class ProtractorElement implements TestElement {
     const first = modifiersAndKeys[0];
     let modifiers: ModifierKeys;
     let rest: (string | TestKey)[];
-    if (typeof first !== 'string' && typeof first !== 'number') {
+    if (first !== undefined && typeof first !== 'string' && typeof first !== 'number') {
       modifiers = first;
       rest = modifiersAndKeys.slice(1);
     } else {
@@ -126,6 +132,12 @@ export class ProtractorElement implements TestElement {
         // so avoid it if no modifier keys are required.
         .map(k => modifierKeys.length > 0 ? Key.chord(...modifierKeys, k) : k);
 
+    // Throw an error if no keys have been specified. Calling this function with no
+    // keys should not result in a focus event being dispatched unexpectedly.
+    if (keys.length === 0) {
+      throw getNoKeysSpecifiedError();
+    }
+
     return this.element.sendKeys(...keys);
   }
 

src/cdk/testing/test-element.ts

@@ -91,13 +91,13 @@ export interface TestElement {
 
   /**
    * Sends the given string to the input as a series of key presses. Also fires input events
-   * and attempts to add the string to the Element's value.
+   * and attempts to add the string to the Element's value. Throws if no keys have been specified.
    */
   sendKeys(...keys: (string | TestKey)[]): Promise<void>;
 
   /**
    * Sends the given string to the input as a series of key presses. Also fires input events
-   * and attempts to add the string to the Element's value.
+   * and attempts to add the string to the Element's value. Throws if no keys have been specified.
    */
   sendKeys(modifiers: ModifierKeys, ...keys: (string | TestKey)[]): Promise<void>;
 
@@ -128,3 +128,11 @@ export interface TestElement {
   /** Checks whether the element is focused. */
   isFocused(): Promise<boolean>;
 }
+
+/**
+ * Returns an error which reports that no keys have been specified.
+ * @docs-private
+ */
+export function getNoKeysSpecifiedError() {
+  return Error('No keys have been specified.');
+}

src/cdk/testing/testbed/fake-events/type-in-element.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ModifierKeys} from '@angular/cdk/testing';
+import {getNoKeysSpecifiedError, ModifierKeys} from '@angular/cdk/testing';
 import {dispatchFakeEvent, dispatchKeyboardEvent} from './dispatch-events';
 import {triggerFocus} from './element-focus';
 
@@ -20,7 +20,7 @@ export function isTextInput(element: Element): element is HTMLInputElement | HTM
 }
 
 /**
- * Focuses an input, sets its value and dispatches
+ * If keys have been specified, focuses an input, sets its value and dispatches
  * the `input` event, simulating the user typing.
  * @param element Element onto which to set the value.
  * @param keys The keys to send to the element.
@@ -30,7 +30,7 @@ export function typeInElement(
     element: HTMLElement, ...keys: (string | {keyCode?: number, key?: string})[]): void;
 
 /**
- * Focuses an input, sets its value and dispatches
+ * If keys have been specified, focuses an input, sets its value and dispatches
  * the `input` event, simulating the user typing.
  * @param element Element onto which to set the value.
  * @param modifiers Modifier keys that are held while typing.
@@ -40,11 +40,12 @@ export function typeInElement(
 export function typeInElement(element: HTMLElement, modifiers: ModifierKeys,
                               ...keys: (string | {keyCode?: number, key?: string})[]): void;
 
-export function typeInElement(element: HTMLElement, ...modifiersAndKeys: any) {
+export function typeInElement(element: HTMLElement, ...modifiersAndKeys: any[]) {
   const first = modifiersAndKeys[0];
   let modifiers: ModifierKeys;
   let rest: (string | {keyCode?: number, key?: string})[];
-  if (typeof first !== 'string' && first.keyCode === undefined && first.key === undefined) {
+  if (first !== undefined && typeof first !== 'string' && first.keyCode === undefined &&
+      first.key === undefined) {
     modifiers = first;
     rest = modifiersAndKeys.slice(1);
   } else {
@@ -56,6 +57,12 @@ export function typeInElement(element: HTMLElement, ...modifiersAndKeys: any) {
           k.split('').map(c => ({keyCode: c.toUpperCase().charCodeAt(0), key: c})) : [k])
       .reduce((arr, k) => arr.concat(k), []);
 
+  // Throw an error if no keys have been specified. Calling this function with no
+  // keys should not result in a focus event being dispatched unexpectedly.
+  if (keys.length === 0) {
+    throw getNoKeysSpecifiedError();
+  }
+
   triggerFocus(element);
   for (const key of keys) {
     dispatchKeyboardEvent(element, 'keydown', key.keyCode, key.key, modifiers);

src/cdk/testing/tests/cross-environment.spec.ts

@@ -9,6 +9,7 @@
 import {
   ComponentHarness,
   ComponentHarnessConstructor,
+  getNoKeysSpecifiedError,
   HarnessLoader,
   TestElement,
 } from '@angular/cdk/testing';
@@ -303,6 +304,17 @@ export function crossEnvironmentSpecs(
       harness = await getMainComponentHarnessFromEnvironment();
     });
 
+    async function expectAsyncError(fn: () => Promise<void>, expected: Error) {
+      let error: Error|null = null;
+      try {
+        await fn();
+      } catch (e) {
+        error = e;
+      }
+      expect(error).not.toBe(null);
+      expect(error!.message).toBe(expected.message);
+    }
+
     it('should be able to clear', async () => {
       const input = await harness.input();
       await input.sendKeys('Yi');
@@ -312,6 +324,13 @@ export function crossEnvironmentSpecs(
       expect(await input.getProperty('value')).toBe('');
     });
 
+    it('sendKeys method should throw if no keys have been specified', async () => {
+      const input = await harness.input();
+      await expectAsyncError(() => input.sendKeys(), getNoKeysSpecifiedError());
+      await expectAsyncError(() => input.sendKeys(''), getNoKeysSpecifiedError());
+      await expectAsyncError(() => input.sendKeys('', ''), getNoKeysSpecifiedError());
+    });
+
     it('should be able to click', async () => {
       const counter = await harness.counter();
       expect(await counter.text()).toBe('0');

tools/public_api_guard/cdk/testing.d.ts

@@ -40,6 +40,8 @@ export interface ElementDimensions {
     width: number;
 }
 
+export declare function getNoKeysSpecifiedError(): Error;
+
 export declare abstract class HarnessEnvironment<E> implements HarnessLoader, LocatorFactory {
     protected rawRootElement: E;
     rootElement: TestElement;