Skip to content

Commit 9d613c7

Browse files
crisbetovictoriaaa234
authored andcommitted
chore(overlay): remove unused properties from checks (#11752)
Removes a few properties that were left in the `ngOnChanges` checks, because the `SimpleChanges` isn't typed and didn't catch that the properties were removed.
1 parent 6b6bddb commit 9d613c7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/cdk/overlay/overlay-directives.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,15 +232,15 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
232232

233233
ngOnChanges(changes: SimpleChanges) {
234234
if (this._position) {
235-
if (changes['positions'] || changes['_deprecatedPositions']) {
235+
if (changes['positions']) {
236236
this._position.withPositions(this.positions);
237237
}
238238

239239
if (changes['lockPosition']) {
240240
this._position.withLockedPosition(this.lockPosition);
241241
}
242242

243-
if (changes['origin'] || changes['_deprecatedOrigin']) {
243+
if (changes['origin']) {
244244
this._position.setOrigin(this.origin.elementRef);
245245

246246
if (this.open) {
@@ -249,7 +249,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
249249
}
250250
}
251251

252-
if (changes['open'] || changes['_deprecatedOpen']) {
252+
if (changes['open']) {
253253
this.open ? this._attachOverlay() : this._detachOverlay();
254254
}
255255
}

0 commit comments

Comments
 (0)