build: set up ts-circular-deps check to prevent new circular deps (#18899)

Author: josephperrott

.circleci/config.yml

@@ -292,6 +292,7 @@ jobs:
       - run: yarn ownerslint
       - run: yarn stylelint
       - run: yarn tslint
+      - run: yarn -s ts-circular-deps:check
 
       - *save_cache
 

.github/CODEOWNERS

@@ -313,3 +313,4 @@
 /.github/**                                        @angular/dev-infra-components @jelbourn
 /.vscode/**                                        @angular/dev-infra-components @mmalerba
 /src/*                                             @jelbourn
+/goldens/ts-circular-deps.json                     @angular/dev-infra-components

goldens/ts-circular-deps.json

@@ -0,0 +1,63 @@
+[
+  [
+    "src/cdk-experimental/dialog/dialog-config.ts",
+    "src/cdk-experimental/dialog/dialog-container.ts"
+  ],
+  [
+    "src/cdk-experimental/popover-edit/edit-event-dispatcher.ts",
+    "src/cdk-experimental/popover-edit/edit-ref.ts"
+  ],
+  [
+    "src/cdk/drag-drop/drag-ref.ts",
+    "src/cdk/drag-drop/drop-list-ref.ts"
+  ],
+  [
+    "src/cdk/drag-drop/directives/drag.ts",
+    "src/cdk/drag-drop/drag-events.ts"
+  ],
+  [
+    "src/cdk/drag-drop/directives/drop-list.ts",
+    "src/cdk/drag-drop/directives/drag.ts",
+    "src/cdk/drag-drop/drag-events.ts"
+  ],
+  [
+    "src/cdk/drag-drop/directives/drop-list.ts",
+    "src/cdk/drag-drop/directives/drag.ts"
+  ],
+  [
+    "src/cdk/overlay/keyboard/overlay-keyboard-dispatcher.ts",
+    "src/cdk/overlay/overlay-ref.ts"
+  ],
+  [
+    "src/cdk/schematics/testing/index.ts",
+    "src/cdk/schematics/testing/test-case-setup.ts"
+  ],
+  [
+    "src/cdk/scrolling/scroll-dispatcher.ts",
+    "src/cdk/scrolling/scrollable.ts"
+  ],
+  [
+    "src/cdk/scrolling/virtual-scroll-viewport.ts",
+    "src/cdk/scrolling/virtual-for-of.ts"
+  ],
+  [
+    "src/cdk/scrolling/virtual-scroll-strategy.ts",
+    "src/cdk/scrolling/virtual-scroll-viewport.ts"
+  ],
+  [
+    "src/cdk/testing/private/e2e/actions.ts",
+    "src/cdk/testing/private/e2e/query.ts"
+  ],
+  [
+    "src/material/core/ripple/ripple-ref.ts",
+    "src/material/core/ripple/ripple-renderer.ts"
+  ],
+  [
+    "src/material/datepicker/datepicker.ts",
+    "src/material/datepicker/datepicker-input.ts"
+  ],
+  [
+    "src/material/grid-list/grid-list.ts",
+    "src/material/grid-list/tile-styler.ts"
+  ]
+]

package.json

@@ -41,7 +41,9 @@
     "ownerslint": "ts-node --project scripts/ scripts/ownerslint.ts",
     "tslint": "tslint -c tslint.json --project ./tsconfig.json",
     "stylelint": "stylelint \"src/**/*.+(css|scss)\" --config .stylelintrc.json --syntax scss",
-    "resync-caretaker-app": "ts-node --project scripts scripts/caretaking/resync-caretaker-app-prs.ts"
+    "resync-caretaker-app": "ts-node --project scripts scripts/caretaking/resync-caretaker-app-prs.ts",
+    "ts-circular-deps:check": "yarn -s ts-circular-deps check --config ./src/circular-deps-test.conf.js",
+    "ts-circular-deps:approve": "yarn -s ts-circular-deps approve --config ./src/circular-deps-test.conf.js"
   },
   "version": "9.2.0",
   "dependencies": {
@@ -67,6 +69,7 @@
     "@angular-devkit/schematics": "^9.0.7",
     "@angular/bazel": "^9.1.0",
     "@angular/compiler-cli": "^9.1.0",
+    "@angular/dev-infra-private": "angular/dev-infra-private-builds#cdf6637",
     "@angular/platform-browser-dynamic": "^9.1.0",
     "@angular/platform-server": "^9.1.0",
     "@angular/router": "^9.1.0",

src/circular-deps-test.conf.js

@@ -0,0 +1,16 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+module.exports = {
+  baseDir: '../',
+  goldenFile: '../goldens/ts-circular-deps.json',
+  // The test should not capture deprecated packages such as `http`, or the `webworker` platform.
+  glob: `./**/*.ts`,
+  // Command that will be displayed if the golden needs to be updated.
+  approveCommand: 'yarn ts-circular-deps:approve',
+  resolveModule: () => {}
+};

yarn.lock

@@ -69,6 +69,10 @@
   resolved "https://registry.yarnpkg.com/@angular/core/-/core-9.1.0.tgz#9dfc386bd1461e0fd4786031fd245da04371421c"
   integrity sha512-RVlyegdIAij0P1wLY5ObIdsBAzvmHkHfElnmfiNKhaDftP6U/3zRtaKDu0bq0jvn1WCQ8zXxFQ8AWyKZwyFS+w==
 
+"@angular/dev-infra-private@angular/dev-infra-private-builds#cdf6637":
+  version "0.0.0"
+  resolved "https://codeload.github.com/angular/dev-infra-private-builds/tar.gz/cdf6637ad14278a32f1b644de5abb4a58002478b"
+
 "@angular/elements@^9.1.0":
   version "9.1.0"
   resolved "https://registry.yarnpkg.com/@angular/elements/-/elements-9.1.0.tgz#fc18691306ca7d1e1257c5817b6ca04901988eff"