Skip to content

Commit a49cd4b

Browse files
crisbetoandrewseguin
authored andcommitted
docs: update reviews guide to remove lgtm label (#20257)
The reviews guide was referring to the `lgtm` label which was removed recently. (cherry picked from commit 9425ae5)
1 parent 22d645c commit a49cd4b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CODE_REVIEWS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
* Links to any relevant issues.
1313
* Screenshots (for visual changes or new additions)
1414
2. Reviews provide comments and the author responds / makes changes. Repeat until LGTM.
15-
3. One or more of the reviewers applies the "LGTM" label.
16-
4. Once the LGTM label is applied, either the author or the reviewer can add the "merge-ready"
15+
3. One or more of the reviewers approve the pull request.
16+
4. Once the PR is approved, either the author or the reviewer can add the "merge-ready"
1717
label to indicate that the PR is ready to be merged.
1818
5. The party responsible for merging PRs will do so.
1919

0 commit comments

Comments
 (0)