build: build all bazel ng_module targets with strict template type checking

Author: devversion

.circleci/config.yml

@@ -404,10 +404,6 @@ jobs:
       # UMD format which is used by Bazel when running tests. UMD processing is in
       # progress and tracked with FW-85.
       - run: node ./scripts/circleci/setup-angular-snapshots.js --tag 8.1.0-next.1-ivy-aot+82e0b4a
-      # Disable type checking when building with Ivy. This is necessary because
-      # type checking is not complete yet and can incorrectly break compilation.
-      # Issue is tracked with FW-1004.
-      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
       # Run project tests with ngtsc and the Ivy Angular packages.
       - run: yarn bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
       - run: yarn bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e
@@ -430,10 +426,6 @@ jobs:
 
       # Setup Angular ivy snapshots built with ngtsc.
       - run: node ./scripts/circleci/setup-angular-snapshots.js --tag master-ivy-aot
-      # Disable type checking when building with Ivy. This is necessary because
-      # type checking is not complete yet and can incorrectly break compilation.
-      # Issue is tracked with FW-1004.
-      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
       # Run project tests with ngtsc and the Ivy Angular packages.
       - run: yarn bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
       - run: yarn bazel test src/... --build_tag_filters=-docs-package --define=compile=aot --test_tag_filters=-e2e

tools/defaults.bzl

@@ -11,11 +11,6 @@ _DEFAULT_TSCONFIG_BUILD = "//src:bazel-tsconfig-build.json"
 _DEFAULT_TSCONFIG_TEST = "//src:bazel-tsconfig-test.json"
 _DEFAULT_TS_TYPINGS = "@npm//typescript:typescript__typings"
 
-# Whether Angular type checking should be enabled or not. Enabled by
-# default but will be overwritten when running snapshots tests with Ivy
-# since type-checking is not complete yet. See FW-1004.
-_ENABLE_NG_TYPE_CHECKING = True
-
 # Re-exports to simplify build file load statements
 markdown_to_html = _markdown_to_html
 
@@ -40,7 +35,7 @@ def ts_library(tsconfig = None, deps = [], testonly = False, **kwargs):
         **kwargs
     )
 
-def ng_module(deps = [], tsconfig = None, testonly = False, **kwargs):
+def ng_module(deps = [], tsconfig = None, type_check = True, testonly = False, **kwargs):
     if not tsconfig:
         tsconfig = _getDefaultTsConfig(testonly)
 
@@ -60,7 +55,7 @@ def ng_module(deps = [], tsconfig = None, testonly = False, **kwargs):
             local_deps = local_deps + [d]
 
     _ng_module(
-        type_check = _ENABLE_NG_TYPE_CHECKING,
+        type_check = type_check,
         deps = local_deps,
         tsconfig = tsconfig,
         testonly = testonly,