Skip to content

Commit b489fdd

Browse files
Youssef Taghlabiandrewseguin
authored andcommitted
chore(focus-origin-monitor): remove unused method parameter (#4636)
* Remove the unused `renderer` parameter in the `focusvia` method.
1 parent 4658c85 commit b489fdd

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

src/demo-app/style/style-demo.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<button #b class="demo-focusable" cdkMonitorElementFocus>focus me!</button>
22
<button (click)="b.focus()">focus programmatically</button>
33

4-
<button (click)="fom.focusVia(b, renderer, 'mouse')">focusVia: mouse</button>
5-
<button (click)="fom.focusVia(b, renderer, 'touch')">focusVia: touch</button>
6-
<button (click)="fom.focusVia(b, renderer, 'keyboard')">focusVia: keyboard</button>
7-
<button (click)="fom.focusVia(b, renderer, 'program')">focusVia: program</button>
4+
<button (click)="fom.focusVia(b, 'mouse')">focusVia: mouse</button>
5+
<button (click)="fom.focusVia(b, 'touch')">focusVia: touch</button>
6+
<button (click)="fom.focusVia(b, 'keyboard')">focusVia: keyboard</button>
7+
<button (click)="fom.focusVia(b, 'program')">focusVia: program</button>
88

99
<div>Active classes: {{b.classList}}</div>
1010

src/lib/checkbox/checkbox.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ export class MdCheckbox extends _MdCheckboxMixinBase
372372

373373
/** Focuses the checkbox. */
374374
focus(): void {
375-
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, this._renderer, 'keyboard');
375+
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, 'keyboard');
376376
}
377377

378378
_onInteractionEvent(event: Event) {

src/lib/core/style/focus-origin-monitor.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe('FocusOriginMonitor', () => {
131131
}));
132132

133133
it('focusVia keyboard should simulate keyboard focus', async(() => {
134-
focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'keyboard');
134+
focusOriginMonitor.focusVia(buttonElement, 'keyboard');
135135
fixture.detectChanges();
136136

137137
setTimeout(() => {
@@ -148,7 +148,7 @@ describe('FocusOriginMonitor', () => {
148148
}));
149149

150150
it('focusVia mouse should simulate mouse focus', async(() => {
151-
focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'mouse');
151+
focusOriginMonitor.focusVia(buttonElement, 'mouse');
152152
fixture.detectChanges();
153153

154154
setTimeout(() => {
@@ -165,7 +165,7 @@ describe('FocusOriginMonitor', () => {
165165
}));
166166

167167
it('focusVia mouse should simulate mouse focus', async(() => {
168-
focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'touch');
168+
focusOriginMonitor.focusVia(buttonElement, 'touch');
169169
fixture.detectChanges();
170170

171171
setTimeout(() => {
@@ -182,7 +182,7 @@ describe('FocusOriginMonitor', () => {
182182
}));
183183

184184
it('focusVia program should simulate programmatic focus', async(() => {
185-
focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'program');
185+
focusOriginMonitor.focusVia(buttonElement, 'program');
186186
fixture.detectChanges();
187187

188188
setTimeout(() => {

src/lib/core/style/focus-origin-monitor.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,9 @@ export class FocusOriginMonitor {
126126
/**
127127
* Focuses the element via the specified focus origin.
128128
* @param element The element to focus.
129-
* @param renderer The renderer to use to invoke the focus method on the element.
130129
* @param origin The focus origin.
131130
*/
132-
focusVia(element: HTMLElement, renderer: Renderer2, origin: FocusOrigin): void {
131+
focusVia(element: HTMLElement, origin: FocusOrigin): void {
133132
this._setOriginForCurrentEventQueue(origin);
134133
element.focus();
135134
}

src/lib/radio/radio.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ export class MdRadioButton implements OnInit, AfterViewInit, OnDestroy {
462462

463463
/** Focuses the radio button. */
464464
focus(): void {
465-
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, this._renderer, 'keyboard');
465+
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, 'keyboard');
466466
}
467467

468468
/**

src/lib/slide-toggle/slide-toggle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export class MdSlideToggle extends _MdSlideToggleMixinBase
199199

200200
/** Focuses the slide-toggle. */
201201
focus() {
202-
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, this._renderer, 'keyboard');
202+
this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, 'keyboard');
203203
}
204204

205205
/** Whether the slide-toggle is checked. */

0 commit comments

Comments
 (0)