fix(menu): wrong icon margin in rtl (#4225)

crisbeto · mmalerba · commit ba6b9bb17a1d · 2017-04-25T16:39:55.000-07:00
Fixes the menu having a wrong margin for the icon in rtl due to the ltr margin not being reset.
diff --git a/src/lib/core/style/_menu-common.scss b/src/lib/core/style/_menu-common.scss
@@ -11,6 +11,7 @@ $mat-menu-overlay-max-width: 280px !default;   // 56 * 5
 $mat-menu-item-height: 48px !default;
 $mat-menu-font-size: 16px !default;
 $mat-menu-side-padding: 16px !default;
+$mat-menu-icon-margin: 16px !default;
 
 @mixin mat-menu-base() {
   @include mat-elevation(8);
@@ -44,10 +45,11 @@ $mat-menu-side-padding: 16px !default;
   }
 
   .mat-icon {
-    margin-right: 16px;
+    margin-right: $mat-menu-icon-margin;
 
     [dir='rtl'] & {
-      margin-left: 16px;
+      margin-left: $mat-menu-icon-margin;
+      margin-right: 0;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ $mat-menu-overlay-max-width: 280px !default; // 56 * 5`
`11`	`11`	`$mat-menu-item-height: 48px !default;`
`12`	`12`	`$mat-menu-font-size: 16px !default;`
`13`	`13`	`$mat-menu-side-padding: 16px !default;`
	`14`	`+$mat-menu-icon-margin: 16px !default;`
`14`	`15`
`15`	`16`	`@mixin mat-menu-base() {`
`16`	`17`	`@include mat-elevation(8);`
`@@ -44,10 +45,11 @@ $mat-menu-side-padding: 16px !default;`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`.mat-icon {`
`47`		`- margin-right: 16px;`
	`48`	`+ margin-right: $mat-menu-icon-margin;`
`48`	`49`
`49`	`50`	`[dir='rtl'] & {`
`50`		`- margin-left: 16px;`
	`51`	`+ margin-left: $mat-menu-icon-margin;`
	`52`	`+ margin-right: 0;`
`51`	`53`	`}`
`52`	`54`	`}`
`53`	`55`	`}`