lint issues

Author: annieyw

tools/highlight-files/BUILD.bazel

@@ -8,9 +8,9 @@ ts_library(
     srcs = glob(["**/*.ts"]),
     tsconfig = ":tsconfig.json",
     deps = [
-        "@npm//@types/node",
+        "//tools/region-parser",
         "@npm//@types/fs-extra",
-        "//tools/region-parser"
+        "@npm//@types/node",
     ],
 )
 

tools/highlight-files/highlight-files.ts

@@ -43,14 +43,14 @@ if (require.main === module) {
         const parsed = regionParser(readFileSync(execPath, 'utf8'), fileExtension);
         for (const [regionName, regionSnippet] of Object.entries(parsed.regions)) {
             // Create files for each found region
-            if (!regionName) continue;
-            const highlightedCodeSnippet = highlightCodeBlock(regionSnippet, fileExtension);
+            if (!regionName) { continue; }
+            const highlightedRegion = highlightCodeBlock(regionSnippet, fileExtension);
             // Convert "my-component-example.ts" into "my-component-example_region-ts.html"
-            const basePathOutputPath = basePath.replace(`.${fileExtension}`,
+            const regionBaseOutputPath = basePath.replace(`.${fileExtension}`,
               `_${regionName}-${fileExtension}.html`);
-            const outputPath = join(outDir, basePathOutputPath);
-            ensureDirSync(dirname(outputPath));
-            writeFileSync(outputPath, highlightedCodeSnippet);
+            const regionOutputPath = join(outDir, regionBaseOutputPath);
+            ensureDirSync(dirname(regionOutputPath));
+            writeFileSync(regionOutputPath, highlightedRegion);
         }
         // Convert "my-component-example.ts" into "my-component-example-ts.html"
         const baseOutputPath = basePath.replace(`.${fileExtension}`, `-${fileExtension}.html`);

tools/highlight-files/index.bzl

@@ -30,7 +30,6 @@ def _highlight_files(ctx):
     # be processed by the highlight binary.
     args.add_all(input_files)
 
-
     # Run the highlight-files executable that highlights the specified source files.
     ctx.actions.run(
         inputs = input_files,

tools/package-docs-content/BUILD.bazel

@@ -7,7 +7,7 @@ nodejs_binary(
     name = "package-docs-content",
     data = [
         ":sources",
-        "@npm//fs-extra"
+        "@npm//fs-extra",
     ],
     entry_point = ":package-docs-content.ts",
 )
@@ -17,7 +17,7 @@ ts_library(
     srcs = glob(["**/*.ts"]),
     tsconfig = ":tsconfig.json",
     deps = [
-        "@npm//@types/node",
         "@npm//@types/fs-extra",
+        "@npm//@types/node",
     ],
 )

tools/package-docs-content/index.bzl

@@ -13,15 +13,12 @@ def _package_docs_content(ctx):
     # repeat `docs-content` is for
     output_dir = ctx.actions.declare_directory("%s/%s" % (ctx.attr.name, ctx.attr.name))
 
-
-
     # Support passing arguments through a parameter file. This is necessary because on Windows
     # there is an argument limit and we need to handle a large amount of input files. Bazel
     # switches between parameter file and normal argument passing based on the operating system.
     # Read more here: https://docs.bazel.build/versions/master/skylark/lib/Args.html#use_param_file
     args.use_param_file(param_file_arg = "--param-file=%s", use_always = True)
 
-
     # Walk through each defined input target and the associated section and compute the
     # output file which will be added to the executable arguments.
     for input_target, section_name in ctx.attr.srcs.items():
@@ -44,8 +41,6 @@ def _package_docs_content(ctx):
             else:
                 expected_out_path = "%s/%s" % (output_dir.path, section_relative_file_name)
 
-
-
             # Pass the input file path and the output file path to the packager executable. We need
             # to do this for each file because we cannot determine the general path to the output
             # directory in a reliable way because Bazel targets cannot just "declare" a directory.

tools/region-parser/region-parser.ts

@@ -14,7 +14,8 @@ export function regionParser(contents: string, fileType: string) {
  * @param fileType string
  * @returns {contents: string, regions: {[regionName: string]: string}}
  */
-function regionParserImpl(contents: string, fileType: string): {contents: string, regions: {[regionName: string]: string}} {
+function regionParserImpl(contents: string, fileType: string)
+  : {contents: string, regions: {[regionName: string]: string}} {
     const regionMatchers: {[fileType: string]: {[region: string]: RegExp}} = {
         ts: inlineC,
         js: inlineC,
@@ -23,7 +24,7 @@ function regionParserImpl(contents: string, fileType: string): {contents: string
         css: blockC,
         json: inlineC,
         'json.annotated': inlineC
-    }
+    };
     const regionMatcher = regionMatchers[fileType];
     const openRegions: string[] = [];
     const regionMap: RegionMap = {};
@@ -46,7 +47,8 @@ function regionParserImpl(contents: string, fileType: string): {contents: string
                     if (region) {
                         if (region.open) {
                             throw new Error(
-                              `Tried to open a region, named "${regionName}", that is already open`);
+                              `Tried to open a region, named "${regionName}", that is already open`
+                            );
                         }
                         region.open = true;
                     } else {
@@ -90,15 +92,16 @@ function regionParserImpl(contents: string, fileType: string): {contents: string
         }
         return {
             contents: lines.join('\n'),
-            regions: mapObject(regionMap, (regionName: string, region: Region) => leftAlign(region.lines).join('\n'))
+            regions: mapObject(regionMap, (regionName: string, region: Region) =>
+              leftAlign(region.lines).join('\n'))
         };
     } else {
         return {contents, regions: {}};
     }
 }
 
 function mapObject(obj: RegionMap, mapper: (regionName: string, region: Region) => string) {
-    const mappedObj:{[regionName: string]: string} = {};
+    const mappedObj: {[regionName: string]: string} = {};
     Object.keys(obj).forEach((key: string) => { mappedObj[key] = mapper(key, obj[key]); });
     return mappedObj;
 }