Skip to content

Commit c44f4aa

Browse files
devversionjelbourn
authored andcommitted
refactor(tab-nav-bar): remove duplicate disableRipple property (#9388)
* Removes the duplicate initialization of the `disableRipple` property on the `MatTabNav`.
1 parent 5b38a73 commit c44f4aa

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/lib/tabs/tab-nav-bar/tab-nav-bar.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ import {MatInkBar} from '../ink-bar';
5555
export class MatTabNavBase {
5656
constructor(public _elementRef: ElementRef) {}
5757
}
58-
export const _MatTabNavMixinBase = mixinDisableRipple(mixinColor(MatTabNavBase, 'primary'));
58+
export const _MatTabNavMixinBase = mixinColor(MatTabNavBase, 'primary');
5959

6060
/**
6161
* Navigation component matching the styles of the tab group header.
@@ -65,7 +65,7 @@ export const _MatTabNavMixinBase = mixinDisableRipple(mixinColor(MatTabNavBase,
6565
moduleId: module.id,
6666
selector: '[mat-tab-nav-bar]',
6767
exportAs: 'matTabNavBar, matTabNav',
68-
inputs: ['color', 'disableRipple'],
68+
inputs: ['color'],
6969
templateUrl: 'tab-nav-bar.html',
7070
styleUrls: ['tab-nav-bar.css'],
7171
host: {'class': 'mat-tab-nav-bar'},
@@ -74,7 +74,7 @@ export const _MatTabNavMixinBase = mixinDisableRipple(mixinColor(MatTabNavBase,
7474
changeDetection: ChangeDetectionStrategy.OnPush,
7575
})
7676
export class MatTabNav extends _MatTabNavMixinBase implements AfterContentInit, CanColor,
77-
CanDisableRipple, OnDestroy {
77+
OnDestroy {
7878

7979
/** Subject that emits when the component has been destroyed. */
8080
private _onDestroy = new Subject<void>();
@@ -105,6 +105,7 @@ export class MatTabNav extends _MatTabNavMixinBase implements AfterContentInit,
105105
private _backgroundColor: ThemePalette;
106106

107107
/** Whether ripples should be disabled for all links or not. */
108+
@Input()
108109
get disableRipple() { return this._disableRipple; }
109110
set disableRipple(value: boolean) {
110111
this._disableRipple = coerceBooleanProperty(value);

0 commit comments

Comments
 (0)