Skip to content

Commit d14e77f

Browse files
crisbetoamysorto
authored andcommitted
test(material/menu): referring to wrong overlay element (#23186)
Attempts to fix the recent flakiness in menu tests. It seems like we were destroying and recreating an overlay container at one point, but we were referring to the element of the previous. (cherry picked from commit 3ae6124)
1 parent c26264f commit d14e77f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/material-experimental/mdc-menu/menu.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,7 @@ describe('MDC-based MatMenu', () => {
12441244
TestBed.resetTestingModule();
12451245

12461246
const newFixture = createComponent(SimpleMenu, [], [FakeIcon]);
1247-
1247+
overlayContainerElement = TestBed.inject(OverlayContainer).getContainerElement();
12481248
newFixture.detectChanges();
12491249
newFixture.componentInstance.trigger.openMenu();
12501250
newFixture.detectChanges();

src/material/menu/menu.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,7 @@ describe('MatMenu', () => {
12411241
TestBed.resetTestingModule();
12421242

12431243
const newFixture = createComponent(SimpleMenu, [], [FakeIcon]);
1244-
1244+
overlayContainerElement = TestBed.inject(OverlayContainer).getContainerElement();
12451245
newFixture.detectChanges();
12461246
newFixture.componentInstance.trigger.openMenu();
12471247
newFixture.detectChanges();

0 commit comments

Comments
 (0)