File tree Expand file tree Collapse file tree 4 files changed +10
-5
lines changed Expand file tree Collapse file tree 4 files changed +10
-5
lines changed Original file line number Diff line number Diff line change @@ -141,6 +141,8 @@ API docs.
141
141
142
142
143
143
#### Getters and Setters
144
+ * Only use getters and setters for ` @Input ` properties or when otherwise required for API
145
+ compatibility.
144
146
* Avoid long or complex getters and setters. If the logic of an accessor would take more than
145
147
three lines, introduce a new method to contain the logic.
146
148
* A getter should immediately precede its corresponding setter.
@@ -205,6 +207,9 @@ specific error being caught and why it cannot be prevented.
205
207
` align ` because the former much more exactly communicates what the property means.
206
208
* Except for ` @Input ` properties, use ` is ` and ` has ` prefixes for boolean properties / methods.
207
209
210
+ ##### Observables
211
+ * Don't suffix observables with ` $ ` .
212
+
208
213
##### Classes
209
214
Classes should be named based on what they're responsible for. Names should capture what the code
210
215
* does* , not how it is used:
Original file line number Diff line number Diff line change @@ -246,7 +246,7 @@ The easiest way to ensure this is to import one of the provided date modules:
246
246
</tr >
247
247
<tr >
248
248
<th align="left" scope="row">Supported locales</th>
249
- <td><a href="https://github.com/moment/moment/tree/develop/src/locale) for details ">See project</a></td>
249
+ <td><a href="https://github.com/moment/moment/tree/develop/src/locale">See project for details </a></td>
250
250
</tr >
251
251
<tr >
252
252
<th align="left" scope="row">Dependencies</th>
Original file line number Diff line number Diff line change @@ -57,7 +57,7 @@ export class MatFooterRowDef extends CdkFooterRowDef {
57
57
export class MatRowDef < T > extends CdkRowDef < T > {
58
58
}
59
59
60
- /** Footer template container that contains the cell outlet. Adds the right class and role. */
60
+ /** Header template container that contains the cell outlet. Adds the right class and role. */
61
61
@Component ( {
62
62
selector : 'mat-header-row, tr[mat-header-row]' ,
63
63
template : CDK_ROW_TEMPLATE ,
Original file line number Diff line number Diff line change @@ -1579,9 +1579,9 @@ accepts@~1.3.7:
1579
1579
negotiator "0.6.2"
1580
1580
1581
1581
acorn@^7.1.0:
1582
- version "7.1.0 "
1583
- resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.0 .tgz#949d36f2c292535da602283586c2477c57eb2d6c "
1584
- integrity sha512-kL5CuoXA/dgxlBbVrflsflzQ3PAas7RYZB52NOm/6839iVYJgKMJ3cQJD+t2i5+qFa8h3MDpEOJiS64E8JLnSQ ==
1582
+ version "7.1.1 "
1583
+ resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.1 .tgz#e35668de0b402f359de515c5482a1ab9f89a69bf "
1584
+ integrity sha512-add7dgA5ppRPxCFJoAGfMDi7PIBXq1RtGo7BhbLaxwrXPOmw8gq48Y9ozT01hUKy9byMjlR20EJhu5zlkErEkg ==
1585
1585
1586
1586
adm-zip@^0.4.9:
1587
1587
version "0.4.14"
You can’t perform that action at this time.
0 commit comments