Skip to content

Commit d171ab0

Browse files
authored
Merge branch '9.1.x' into build/update-angular-latest
2 parents 21bbaba + 25571f5 commit d171ab0

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

CODING_STANDARDS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ API docs.
141141

142142

143143
#### Getters and Setters
144+
* Only use getters and setters for `@Input` properties or when otherwise required for API
145+
compatibility.
144146
* Avoid long or complex getters and setters. If the logic of an accessor would take more than
145147
three lines, introduce a new method to contain the logic.
146148
* A getter should immediately precede its corresponding setter.
@@ -205,6 +207,9 @@ specific error being caught and why it cannot be prevented.
205207
`align` because the former much more exactly communicates what the property means.
206208
* Except for `@Input` properties, use `is` and `has` prefixes for boolean properties / methods.
207209

210+
##### Observables
211+
* Don't suffix observables with `$`.
212+
208213
##### Classes
209214
Classes should be named based on what they're responsible for. Names should capture what the code
210215
*does*, not how it is used:

src/material/datepicker/datepicker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ The easiest way to ensure this is to import one of the provided date modules:
246246
</tr>
247247
<tr>
248248
<th align="left" scope="row">Supported locales</th>
249-
<td><a href="https://github.com/moment/moment/tree/develop/src/locale) for details">See project</a></td>
249+
<td><a href="https://github.com/moment/moment/tree/develop/src/locale">See project for details</a></td>
250250
</tr>
251251
<tr>
252252
<th align="left" scope="row">Dependencies</th>

src/material/table/row.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class MatFooterRowDef extends CdkFooterRowDef {
5757
export class MatRowDef<T> extends CdkRowDef<T> {
5858
}
5959

60-
/** Footer template container that contains the cell outlet. Adds the right class and role. */
60+
/** Header template container that contains the cell outlet. Adds the right class and role. */
6161
@Component({
6262
selector: 'mat-header-row, tr[mat-header-row]',
6363
template: CDK_ROW_TEMPLATE,

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,9 +1579,9 @@ accepts@~1.3.7:
15791579
negotiator "0.6.2"
15801580

15811581
acorn@^7.1.0:
1582-
version "7.1.0"
1583-
resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.0.tgz#949d36f2c292535da602283586c2477c57eb2d6c"
1584-
integrity sha512-kL5CuoXA/dgxlBbVrflsflzQ3PAas7RYZB52NOm/6839iVYJgKMJ3cQJD+t2i5+qFa8h3MDpEOJiS64E8JLnSQ==
1582+
version "7.1.1"
1583+
resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.1.tgz#e35668de0b402f359de515c5482a1ab9f89a69bf"
1584+
integrity sha512-add7dgA5ppRPxCFJoAGfMDi7PIBXq1RtGo7BhbLaxwrXPOmw8gq48Y9ozT01hUKy9byMjlR20EJhu5zlkErEkg==
15851585

15861586
adm-zip@^0.4.9:
15871587
version "0.4.14"

0 commit comments

Comments
 (0)