Skip to content

Commit d4476f5

Browse files
committed
fix lint and tests
1 parent cea7fc4 commit d4476f5

File tree

4 files changed

+86
-1
lines changed

4 files changed

+86
-1
lines changed

src/material/divider/testing/BUILD.bazel

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,33 @@ filegroup(
1818
name = "source-files",
1919
srcs = glob(["**/*.ts"]),
2020
)
21+
22+
ng_test_library(
23+
name = "harness_tests_lib",
24+
srcs = ["shared.spec.ts"],
25+
deps = [
26+
":testing",
27+
"//src/cdk/testing",
28+
"//src/cdk/testing/testbed",
29+
"//src/material/divider",
30+
"@npm//@angular/platform-browser",
31+
],
32+
)
33+
34+
ng_test_library(
35+
name = "unit_tests_lib",
36+
srcs = glob(
37+
["**/*.spec.ts"],
38+
exclude = ["shared.spec.ts"],
39+
),
40+
deps = [
41+
":harness_tests_lib",
42+
":testing",
43+
"//src/material/divider",
44+
],
45+
)
46+
47+
ng_web_test_suite(
48+
name = "unit_tests",
49+
deps = [":unit_tests_lib"],
50+
)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import {MatDividerModule} from '@angular/material/divider';
2+
import {MatDividerHarness} from './divider-harness';
3+
import {runHarnessTests} from './shared.spec';
4+
5+
describe('Non-MDC-based MatButtonHarness', () => {
6+
runHarnessTests(MatDividerModule, MatDividerHarness);
7+
});
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
import {HarnessLoader} from '@angular/cdk/testing';
2+
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
3+
import {Component} from '@angular/core';
4+
import {ComponentFixture, TestBed} from '@angular/core/testing';
5+
import {MatDividerModule} from '@angular/material/divider';
6+
import {MatDividerHarness} from './divider-harness';
7+
8+
/** Shared tests to run on both the original and MDC-based dividers. */
9+
export function runHarnessTests(
10+
dividerModule: typeof MatDividerModule, dividerHarness: typeof MatDividerHarness) {
11+
let fixture: ComponentFixture<DividerHarnessTest>;
12+
let loader: HarnessLoader;
13+
14+
beforeEach(async () => {
15+
await TestBed.configureTestingModule({
16+
imports: [dividerModule],
17+
declarations: [DividerHarnessTest],
18+
}).compileComponents();
19+
20+
fixture = TestBed.createComponent(DividerHarnessTest);
21+
fixture.detectChanges();
22+
loader = TestbedHarnessEnvironment.loader(fixture);
23+
});
24+
25+
it('should load all button harnesses', async () => {
26+
const dividers = await loader.getAllHarnesses(dividerHarness);
27+
expect(dividers.length).toBe(2);
28+
});
29+
30+
it('should check if divider is inset', async () => {
31+
const dividers = await loader.getAllHarnesses(dividerHarness);
32+
expect(await dividers[0].isInset()).toBe(false);
33+
expect(await dividers[1].isInset()).toBe(true);
34+
});
35+
36+
it('should get divider orientation', async () => {
37+
const dividers = await loader.getAllHarnesses(dividerHarness);
38+
expect(await dividers[0].getOrientation()).toBe('horizontal');
39+
expect(await dividers[1].getOrientation()).toBe('vertical');
40+
});
41+
}
42+
43+
@Component({
44+
template: `
45+
<mat-divider></mat-divider>
46+
<mat-divider inset vertical></mat-divider>
47+
`
48+
})
49+
class DividerHarnessTest {}

src/material/list/testing/list-harness.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ export class MatSelectionListHarness extends MatListHarnessBase<
263263
return new HarnessPredicate(MatSelectionListHarness, options);
264264
}
265265

266-
private _selected = this.locatorForAll(MatListOptionHarness.with({selected: true}));
267266
_itemHarness = MatListOptionHarness;
268267

269268
/** Whether the selection list is disabled. */

0 commit comments

Comments
 (0)