Skip to content

Commit d7cafe4

Browse files
committed
fix(tabs): no longer use OnPush
This resolves an issue with ivy where the template content would be checked out of sync with the tab view. See #15440 for additional context.
1 parent 8dffd8e commit d7cafe4

File tree

4 files changed

+0
-4
lines changed

4 files changed

+0
-4
lines changed

src/material/tabs/tab-body.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ export class MatTabBodyPortal extends CdkPortalOutlet implements OnInit, OnDestr
108108
templateUrl: 'tab-body.html',
109109
styleUrls: ['tab-body.css'],
110110
encapsulation: ViewEncapsulation.None,
111-
changeDetection: ChangeDetectionStrategy.OnPush,
112111
animations: [matTabsAnimations.translateTab],
113112
host: {
114113
'class': 'mat-tab-body',

src/material/tabs/tab-group.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ const _MatTabGroupMixinBase: CanColorCtor & CanDisableRippleCtor & typeof MatTab
8484
templateUrl: 'tab-group.html',
8585
styleUrls: ['tab-group.css'],
8686
encapsulation: ViewEncapsulation.None,
87-
changeDetection: ChangeDetectionStrategy.OnPush,
8887
inputs: ['color', 'disableRipple'],
8988
host: {
9089
'class': 'mat-tab-group',

src/material/tabs/tab-header.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ import {MatPaginatedTabHeader} from './paginated-tab-header';
4848
inputs: ['selectedIndex'],
4949
outputs: ['selectFocusedIndex', 'indexFocused'],
5050
encapsulation: ViewEncapsulation.None,
51-
changeDetection: ChangeDetectionStrategy.OnPush,
5251
host: {
5352
'class': 'mat-tab-header',
5453
'[class.mat-tab-header-pagination-controls-enabled]': '_showPaginationControls',

src/material/tabs/tab.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ const _MatTabMixinBase: CanDisableCtor & typeof MatTabBase =
3838
selector: 'mat-tab',
3939
templateUrl: 'tab.html',
4040
inputs: ['disabled'],
41-
changeDetection: ChangeDetectionStrategy.OnPush,
4241
encapsulation: ViewEncapsulation.None,
4342
exportAs: 'matTab',
4443
})

0 commit comments

Comments
 (0)