build: enable no-unused-variable lint rule

* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker
* In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.

Author: devversion

e2e/components/checkbox-e2e.spec.ts

@@ -10,7 +10,6 @@ describe('checkbox', () => {
     it('should be checked when clicked, and unchecked when clicked again', async () => {
       let checkboxEl = element(by.id('test-checkbox'));
       let inputEl = element(by.css('input[id=input-test-checkbox]'));
-      let checked: string;
 
       screenshot('start');
       checkboxEl.click();

e2e/components/icon-e2e.spec.ts

@@ -1,5 +1,4 @@
 import {browser, by, element} from 'protractor';
-import {screenshot} from '../screenshot';
 
 
 describe('icon', () => {

e2e/components/menu-e2e.spec.ts

@@ -1,4 +1,4 @@
-import {Key, protractor, browser, by, element, ElementFinder} from 'protractor';
+import {Key, protractor, browser, by, element} from 'protractor';
 import {screenshot} from '../screenshot';
 import {
   expectToExist,

src/demo-app/overlay/overlay-demo.ts

@@ -11,6 +11,9 @@ import {
     OverlayState,
     OverlayOrigin,
     ComponentPortal,
+    // This import is only used to define a generic type. The current TypeScript version incorrectly
+    // considers such imports as unused (https://github.com/Microsoft/TypeScript/issues/14953)
+    // tslint:disable-next-line:no-unused-variable
     Portal,
     TemplatePortalDirective,
 } from '@angular/material';

src/lib/chips/chip-list.ts

@@ -20,7 +20,7 @@ import {
 import {MdChip} from './chip';
 import {FocusKeyManager} from '../core/a11y/focus-key-manager';
 import {coerceBooleanProperty} from '../core/coercion/boolean-property';
-import {SPACE, LEFT_ARROW, RIGHT_ARROW, TAB} from '../core/keyboard/keycodes';
+import {SPACE, LEFT_ARROW, RIGHT_ARROW} from '../core/keyboard/keycodes';
 import {Subscription} from 'rxjs/Subscription';
 
 /**

src/lib/core/a11y/activedescendant-key-manager.ts

@@ -6,7 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {QueryList} from '@angular/core';
 import {ListKeyManager, CanDisable} from './list-key-manager';
 
 /**

src/lib/core/data-table/cell.ts

@@ -47,10 +47,8 @@ export class CdkColumnDef {
   },
 })
 export class CdkHeaderCell {
-  constructor(private columnDef: CdkColumnDef,
-              private elementRef: ElementRef,
-              private renderer: Renderer2) {
-    this.renderer.addClass(elementRef.nativeElement, `cdk-column-${columnDef.name}`);
+  constructor(columnDef: CdkColumnDef, elementRef: ElementRef, renderer: Renderer2) {
+    renderer.addClass(elementRef.nativeElement, `cdk-column-${columnDef.name}`);
   }
 }
 
@@ -63,9 +61,7 @@ export class CdkHeaderCell {
   },
 })
 export class CdkCell {
-  constructor(private columnDef: CdkColumnDef,
-              private elementRef: ElementRef,
-              private renderer: Renderer2) {
-    this.renderer.addClass(elementRef.nativeElement, `cdk-column-${columnDef.name}`);
+  constructor(columnDef: CdkColumnDef, elementRef: ElementRef, renderer: Renderer2) {
+    renderer.addClass(elementRef.nativeElement, `cdk-column-${columnDef.name}`);
   }
 }

src/lib/core/data-table/data-table.ts

@@ -27,7 +27,7 @@ import {
   ViewEncapsulation
 } from '@angular/core';
 import {CollectionViewer, DataSource} from './data-source';
-import {BaseRowDef, CdkCellOutlet, CdkHeaderRowDef, CdkRowDef} from './row';
+import {CdkCellOutlet, CdkHeaderRowDef, CdkRowDef} from './row';
 import {CdkCellDef, CdkColumnDef, CdkHeaderCellDef} from './cell';
 import {Observable} from 'rxjs/Observable';
 import {BehaviorSubject} from 'rxjs/BehaviorSubject';

src/lib/core/datetime/native-date-adapter.spec.ts

@@ -1,16 +1,9 @@
 import {NativeDateAdapter} from './native-date-adapter';
 import {Platform} from '../platform/index';
-
+import {DEC, FEB, JAN, MAR} from '../testing/date-shortcuts';
 
 const SUPPORTS_INTL = typeof Intl != 'undefined';
 
-
-// When constructing a Date, the month is zero-based. This can be confusing, since people are
-// used to seeing them one-based. So we create these aliases to make reading the tests easier.
-const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8, OCT = 9,
-      NOV = 10, DEC = 11;
-
-
 describe('NativeDateAdapter', () => {
   let adapter;
   let platform;

src/lib/core/option/optgroup.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Component, ViewEncapsulation, ContentChildren, QueryList, Input} from '@angular/core';
+import {Component, ViewEncapsulation, Input} from '@angular/core';
 import {mixinDisabled, CanDisable} from '../common-behaviors/disabled';
 
 // Boilerplate for applying mixins to MdOptgroup.

src/lib/core/option/option.ts

@@ -12,7 +12,6 @@ import {
   EventEmitter,
   Input,
   Output,
-  NgModule,
   ViewEncapsulation,
   Inject,
   Optional,

src/lib/core/overlay/overlay-directives.ts

@@ -27,12 +27,14 @@ import {TemplatePortal} from '../portal/portal';
 import {OverlayState} from './overlay-state';
 import {
     ConnectionPositionPair,
+    // This import is only used to define a generic type. The current TypeScript version incorrectly
+    // considers such imports as unused (https://github.com/Microsoft/TypeScript/issues/14953)
+    // tslint:disable-next-line:no-unused-variable
     ConnectedOverlayPositionChange
 } from './position/connected-position';
 import {PortalModule} from '../portal/portal-directives';
 import {ConnectedPositionStrategy} from './position/connected-position-strategy';
 import {Dir, LayoutDirection} from '../rtl/dir';
-import {Scrollable} from './scroll/scrollable';
 import {ScrollStrategy} from './scroll/scroll-strategy';
 import {coerceBooleanProperty} from '../coercion/boolean-property';
 import {ESCAPE} from '../keyboard/keycodes';

src/lib/core/overlay/overlay.spec.ts

@@ -8,8 +8,7 @@ import {OverlayState} from './overlay-state';
 import {OverlayRef} from './overlay-ref';
 import {PositionStrategy} from './position/position-strategy';
 import {OverlayModule} from './overlay-directives';
-import {ViewportRuler} from './position/viewport-ruler';
-import {ScrollStrategy, ScrollDispatcher} from './scroll/index';
+import {ScrollStrategy} from './scroll/index';
 
 
 describe('Overlay', () => {
@@ -333,7 +332,6 @@ describe('Overlay', () => {
       overlayRef.attach(componentPortal);
       viewContainerFixture.detectChanges();
 
-      let backdrop = overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
       let completeHandler = jasmine.createSpy('backdrop complete handler');
 
       overlayRef.backdropClick().subscribe(null, null, completeHandler);

src/lib/core/overlay/scroll/scroll-strategy-options.ts

@@ -7,7 +7,6 @@
  */
 
 import {Injectable} from '@angular/core';
-import {ScrollStrategy} from './scroll-strategy';
 import {CloseScrollStrategy} from './close-scroll-strategy';
 import {NoopScrollStrategy} from './noop-scroll-strategy';
 import {BlockScrollStrategy} from './block-scroll-strategy';

src/lib/core/testing/date-shortcuts.ts

@@ -0,0 +1,14 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+/**
+ * When constructing a Date, the month is zero-based. This can be confusing, since people are
+ * used to seeing them one-based. So we create these aliases to make writing the tests easier.
+ */
+export const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8,
+    OCT = 9, NOV = 10, DEC = 11;

src/lib/datepicker/calendar.spec.ts

@@ -25,13 +25,7 @@ import {MdDatepickerIntl} from './datepicker-intl';
 import {MdNativeDateModule} from '../core/datetime/index';
 import {NoConflictStyleCompatibilityMode} from '../core';
 import {MdButtonModule} from '../button/index';
-
-
-// When constructing a Date, the month is zero-based. This can be confusing, since people are
-// used to seeing them one-based. So we create these aliases to make reading the tests easier.
-const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8, OCT = 9,
-      NOV = 10, DEC = 11;
-
+import {AUG, DEC, FEB, JAN, JUL, NOV, MAR, MAY, JUN, SEP} from '../core/testing/date-shortcuts';
 
 describe('MdCalendar', () => {
   beforeEach(async(() => {

src/lib/datepicker/datepicker.spec.ts

@@ -14,13 +14,7 @@ import {
   dispatchMouseEvent,
   dispatchKeyboardEvent,
 } from '../core/testing/dispatch-events';
-
-
-// When constructing a Date, the month is zero-based. This can be confusing, since people are
-// used to seeing them one-based. So we create these aliases to make reading the tests easier.
-const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8, OCT = 9,
-      NOV = 10, DEC = 11;
-
+import {DEC, JAN} from '../core/testing/date-shortcuts';
 
 describe('MdDatepicker', () => {
   describe('with MdNativeDateModule', () => {

src/lib/datepicker/month-view.spec.ts

@@ -4,13 +4,7 @@ import {By} from '@angular/platform-browser';
 import {MdMonthView} from './month-view';
 import {MdCalendarBody} from './calendar-body';
 import {MdNativeDateModule, DateAdapter, NativeDateAdapter} from '../core/datetime/index';
-
-
-// When constructing a Date, the month is zero-based. This can be confusing, since people are
-// used to seeing them one-based. So we create these aliases to make reading the tests easier.
-const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8, OCT = 9,
-      NOV = 10, DEC = 11;
-
+import {JAN, MAR} from '../core/testing/date-shortcuts';
 
 describe('MdMonthView', () => {
   beforeEach(async(() => {

src/lib/datepicker/year-view.spec.ts

@@ -4,13 +4,7 @@ import {By} from '@angular/platform-browser';
 import {MdYearView} from './year-view';
 import {MdCalendarBody} from './calendar-body';
 import {MdNativeDateModule, DateAdapter, NativeDateAdapter} from '../core/datetime/index';
-
-
-// When constructing a Date, the month is zero-based. This can be confusing, since people are
-// used to seeing them one-based. So we create these aliases to make reading the tests easier.
-const JAN = 0, FEB = 1, MAR = 2, APR = 3, MAY = 4, JUN = 5, JUL = 6, AUG = 7, SEP = 8, OCT = 9,
-      NOV = 10, DEC = 11;
-
+import {FEB, JAN, MAR} from '../core/testing/date-shortcuts';
 
 describe('MdYearView', () => {
   beforeEach(async(() => {

src/lib/dialog/dialog-container.ts

@@ -12,7 +12,6 @@ import {
   ViewChild,
   ViewEncapsulation,
   NgZone,
-  OnDestroy,
   ElementRef,
   EventEmitter,
   Inject,

src/lib/dialog/dialog.spec.ts

@@ -313,7 +313,7 @@ describe('MdDialog', () => {
   });
 
   it('should allow setting the layout direction', () => {
-    let dialogRef = dialog.open(PizzaMsg, { direction: 'rtl' });
+    dialog.open(PizzaMsg, { direction: 'rtl' });
 
     viewContainerFixture.detectChanges();
 

src/lib/expansion/index.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {NgModule, ModuleWithProviders} from '@angular/core';
+import {NgModule} from '@angular/core';
 import {CommonModule} from '@angular/common';
 import {CompatibilityModule, UNIQUE_SELECTION_DISPATCHER_PROVIDER} from '../core';
 import {

src/lib/select/select.spec.ts

@@ -16,7 +16,7 @@ import {MdSelect} from './select';
 import {getMdSelectDynamicMultipleError, getMdSelectNonArrayValueError} from './select-errors';
 import {MdOption} from '../core/option/option';
 import {Dir} from '../core/rtl/dir';
-import {DOWN_ARROW, UP_ARROW, ENTER, SPACE, HOME, END, TAB} from '../core/keyboard/keycodes';
+import {DOWN_ARROW, UP_ARROW, SPACE, HOME, END, TAB} from '../core/keyboard/keycodes';
 import {
   ControlValueAccessor, FormControl, FormsModule, NG_VALUE_ACCESSOR, ReactiveFormsModule
 } from '@angular/forms';

src/lib/snack-bar/snack-bar-container.ts

@@ -26,7 +26,6 @@ import {
 import {
   BasePortalHost,
   ComponentPortal,
-  TemplatePortal,
   PortalHostDirective,
 } from '../core';
 import {MdSnackBarConfig} from './snack-bar-config';

src/tsconfig.json

@@ -4,9 +4,7 @@ import {BrowserModule} from '@angular/platform-browser';
 import {
   MdAutocompleteModule,
   MdButtonModule,
-  MdButtonToggleModule,
   MdCardModule,
-  MdCheckboxModule,
   MdChipsModule,
   MdDatepickerModule,
   MdDialogModule,

src/universal-app/kitchen-sink/kitchen-sink.ts

@@ -7,9 +7,7 @@ import {buildConfig} from 'material2-build-tools';
 const stylesGlob = '+(tools|src)/**/*.+(css|scss)';
 
 /** List of flags that will passed to the different TSLint tasks. */
-const tsLintBaseFlags = [
-  '-c', 'tslint.json', '+(src|e2e|tools)/**/*.ts', '--exclude', '**/node_modules/**/*'
-];
+const tsLintBaseFlags = ['-c', 'tslint.json', '--project', './tsconfig.json'];
 
 /** Path to the output of the Material package. */
 const materialOutPath = join(buildConfig.outputDir, 'packages', 'material');

tools/gulp/tasks/lint.ts

@@ -6,10 +6,6 @@ import {remapSourcemap} from './sourcemap-remap';
 import {transpileFile} from './typescript-transpile';
 import {buildConfig} from './build-config';
 
-// There are no type definitions available for these imports.
-const uglify = require('uglify-js');
-const sorcery = require('sorcery');
-
 /** Directory where all bundles will be created in. */
 const bundlesDir = join(buildConfig.outputDir, 'bundles');
 

tools/package-tools/build-bundles.ts

@@ -28,15 +28,13 @@ export function setGithubStatus(commitSHA: string,
     'Content-Type': 'application/json'
   };
 
-  return new Promise((resolve) => {
+  return new Promise((resolve, reject) => {
     request({
       url: `https://api.github.com/repos/${repoSlug}/statuses/${commitSHA}`,
       method: 'POST',
       form: data,
       headers: headers
-    }, function (error: any, response: any) {
-      console.log(response.statusCode);
-      resolve(response.statusCode);
-    });
-  });
+    }, (error: any, response: any) => error ? reject(error) : resolve(response.statusCode));
+
+});
 }

tools/screenshot-test/functions/util/github.ts

@@ -46,15 +46,15 @@ export class ViewerComponent {
   }
 
   approve() {
-    this._service.approvePullRequest().then((result) => {
+    this._service.approvePullRequest().then(() => {
       this.snackBar.open(`Approved`, '', this.messageDuration);
     }).catch((error) => {
       this.snackBar.open(`Error ${error}`, '', this.messageDuration);
     });
   }
 
   updateGithubStatus() {
-    this._service.updatePullRequestResult().then((result) => {
+    this._service.updatePullRequestResult().then(() => {
       this.snackBar.open(`Approved`, '', this.messageDuration);
     }).catch((error) => {
       this.snackBar.open(error.message, '', this.messageDuration);