add collectionviewer to disconnect

Author: andrewseguin

src/demo-app/data-table/person-data-source.ts

@@ -13,7 +13,7 @@ export class PersonDataSource extends DataSource<any> {
 
   connect(): Observable<UserData[]> {
     const displayDataChanges = [
-        this._paginator.page,
+      this._paginator.page,
       this._sort.mdSortChange,
       this._peopleDatabase.dataChange
     ];
@@ -26,6 +26,10 @@ export class PersonDataSource extends DataSource<any> {
     });
   }
 
+  disconnect() {
+    // No-op
+  }
+
   /** Returns a sorted copy of the database data. */
   getSortedData(): UserData[] {
     const data = this._peopleDatabase.data.slice();

src/lib/core/data-table/data-source.ts

@@ -14,5 +14,5 @@ export interface CollectionViewer {
 
 export abstract class DataSource<T> {
   abstract connect(collectionViewer: CollectionViewer): Observable<T[]>;
-  disconnect() {}
+  abstract disconnect(collectionViewer: CollectionViewer): void;
 }

src/lib/core/data-table/data-table.ts

@@ -185,7 +185,7 @@ export class CdkTable<T> implements CollectionViewer {
     this._onDestroy.next();
     this._onDestroy.complete();
     if (this.dataSource) {
-      this.dataSource.disconnect();
+      this.dataSource.disconnect(this);
     }
   }
 
@@ -242,7 +242,7 @@ export class CdkTable<T> implements CollectionViewer {
     this._data = [];
 
     if (this._dataSource) {
-      this.dataSource.disconnect();
+      this.dataSource.disconnect(this);
     }
     this._dataSource = dataSource;
 

src/lib/sort/sort.spec.ts

@@ -203,6 +203,7 @@ class FakeDataSource extends DataSource<any> {
   connect(collectionViewer: CollectionViewer): Observable<any[]> {
     return map.call(collectionViewer.viewChange, () => []);
   }
+  disconnect() {}
 }
 
 @Component({

src/lib/table/table.spec.ts

@@ -68,6 +68,8 @@ class FakeDataSource extends DataSource<TestData> {
     return this._dataChange;
   }
 
+  disconnect() {}
+
   addData() {
     const nextIndex = this.data.length + 1;